resource/aws_acm_certificate: Various small improvements and fixes

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3855
Closes #6082
Closes #8755
Closes #12075
Reference: #13053

Release note for CHANGELOG:

ENHANCEMENTS:

* resource/aws_acm_certificate: Add `status` attribute

BUG FIXES:

* resource/aws_acm_certificate: Detect `AMAZON_ISSUED` type `validation_method` value directly from API response instead of custom logic
* resource/aws_acm_certificate: Increase deletion retries from 10 minutes to 20 minutes (better support API Gateway Custom Domain deletion)

Other changes:

• Documents subject_alternative_names argument removal procedures
• Improves potentially confusing error message during asynchronous ACM validation assignment

Output from acceptance testing:

--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (36.64s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (37.74s)
--- PASS: TestAccAWSAcmCertificate_wildcard (38.86s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (39.08s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (39.11s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (39.35s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (39.62s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (41.62s)
--- PASS: TestAccAWSAcmCertificate_san_single (41.93s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (42.00s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (42.05s)
--- PASS: TestAccAWSAcmCertificate_root (42.07s)
--- PASS: TestAccAWSAcmCertificate_privateCert (47.46s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (54.51s)
--- PASS: TestAccAWSAcmCertificate_tags (85.67s)

(For good measure)

--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (18.78s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (24.29s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (155.47s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (180.47s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (192.25s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (403.12s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (404.30s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (404.71s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (440.41s)

[anGie44]

Changes LGTM 👍 though noticed theres 2 tests listed below that failed in TC; they're in the queue to run in case further validation is needed?

Output of acceptance tests in TC:

--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (14.84s)
--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (15.10s)
--- PASS: TestAccAWSAcmCertificate_root (17.62s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (18.34s)
--- PASS: TestAccAWSAcmCertificate_wildcard (19.42s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (19.72s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (19.52s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (19.84s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (16.28s)
--- PASS: TestAccAWSAcmCertificate_privateCert (21.54s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (22.10s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (22.08s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (22.02s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (22.42s)
--- PASS: TestAccAWSAcmCertificate_san_single (22.51s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (24.92s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (11.91s)
--- PASS: TestAccAWSAcmCertificate_tags (34.79s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (55.19s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (54.70s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (93.13s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (137.09s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (203.96s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (223.42s)

--- FAIL: TestAccAWSAcmCertificate_san_multiple (16.84s) -- appears flaky
--- FAIL: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (60.22s) -- appears flaky
--- FAIL: TestAccAWSAcmCertificateDataSource_singleIssued (5.30s) -- not found in region error/historically failing
--- FAIL: TestAccAWSAcmCertificateDataSource_multipleIssued (5.57s) -- not found in region error/historically failing -- attribute check error/historically failing 

[ghost]

This has been released in version 2.65.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!