Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Add subcategories to docs for display on the Terraform Registry #10684

Merged
merged 5 commits into from
Nov 6, 2019

Conversation

justincampbell
Copy link
Contributor

We will soon be displaying documentation for this provider both on terraform.io and on the Terraform Registry.

Documentation displayed on the Terraform Registry will not use the ERB layout containing the existing navigation, and will instead build the navigation dynamically based on the directory and YAML frontmatter of a file. For providers that group similar resources and data sources by service or use case (subcategories), we'll need to add this information to the Markdown source file.

This PR modifies resource and data source documentation source files by adding a subcategory to the metadata if those files are currently grouped on terraform.io.

For more information about how documentation is rendered on the Terraform Registry, please see this reference: Terraform Registry - Provider Documentation.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make docscheck
$ # exited 0

@justincampbell justincampbell requested a review from a team October 30, 2019 18:20
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Oct 30, 2019
@justincampbell justincampbell force-pushed the terraform-registry-docs-preparation branch from 3e82e64 to 7a138e0 Compare October 30, 2019 18:49
@bflad bflad added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 30, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @justincampbell 🚀 Verified all the subcategories match up appropriately.

Before we merge, we should likely go through any affected pull requests (new resource/data source or those adjusting renamed files) to decide how we should handle them.

@@ -1,4 +1,5 @@
---
subcategory: "EC2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this pull request, but this is confusingly in Autoscaling for the data source and EC2 for the resource. Technically, I think it should be in Autoscaling since that's the service API.

@justincampbell
Copy link
Contributor Author

@bflad Updated this to not rename any files! Let me know if it's ok to merge soon.

@justincampbell justincampbell force-pushed the terraform-registry-docs-preparation branch 2 times, most recently from 975ae18 to 8a56e46 Compare November 6, 2019 22:03
This check ensures that all resource and data source docs have a subcategory specified, so that the Terraform Registry can properly render the docs navigation.
This was removed, but should show up in the subcategory on the Terraform Registry, and not the top-level data sources folder.
We will soon be displaying documentation for this provider both on [terraform.io](https://www.terraform.io/docs/providers/index.html) and on [the Terraform Registry](https://registry.terraform.io/providers).

Documentation displayed on the Terraform Registry will not use the ERB layout containing the existing navigation, and will instead build the navigation dynamically based on the directory and YAML frontmatter of a file. For providers that group similar resources and data sources by service or use case (subcategories), we'll need to add this information to the Markdown source file.

This modifies Resource and Data Source documentation source files by adding a subcategory to the metadata if those files were grouped previously.

For more information about how documentation is rendered on the Terraform Registry, please see this reference: [Terraform Registry - Provider Documentation](https://www.terraform.io/docs/registry/providers/docs.html).
@justincampbell justincampbell force-pushed the terraform-registry-docs-preparation branch from 8a56e46 to 6050201 Compare November 6, 2019 22:04
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Thanks so much for allowing the ingress to support the legacy file extensions! 🚀

@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants