Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/cloudtrail - add support for exclude_management_event_sources to event_selector #11680

Closed
wants to merge 16 commits into from
Closed

r/cloudtrail - add support for exclude_management_event_sources to event_selector #11680

wants to merge 16 commits into from

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 20, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11448 , Relates #11682

Release note for CHANGELOG:

resource_aws_cloudtrail: add support for `exclude_management_event_sources` argument in `event_selector` block.

resource_aws_cloudtrail: added plan time validations to `cloud_watch_logs_role_arn`, `cloud_watch_logs_group_arn`, `sns_topic_name`, `event_selector.data_resource.values`.

resource_aws_cloudtrail: added `sns_topic_arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudTrail/Trail'
        --- PASS: TestAccAWSCloudTrail/Trail/disappears (102.18s)
        --- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (118.36s)
        --- PASS: TestAccAWSCloudTrail/Trail/logValidation (181.54s)
        --- PASS: TestAccAWSCloudTrail/Trail/kmsKey (130.94s)
        --- PASS: TestAccAWSCloudTrail/Trail/basic (165.84s)
        --- PASS: TestAccAWSCloudTrail/Trail/enableLogging (234.62s)
        --- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (229.30s)
	--- PASS: TestAccAWSCloudTrail/Trail/eventSelectorWExclude (106.84s)
        --- PASS: TestAccAWSCloudTrail/Trail/eventSelector (187.04s)
        --- PASS: TestAccAWSCloudTrail/Trail/tags (228.16s)
        --- PASS: TestAccAWSCloudTrail/Trail/sns (229.32s)
        --- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (181.60s)
        --- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (4.11s)

@DrFaust92 DrFaust92 requested a review from a team January 20, 2020 19:24
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 20, 2020
@DrFaust92
Copy link
Collaborator Author

@bflad, i was just testing changes to the cloudtrail resource and saw you opened an issue regarding retries. i removed a check of one of mentioned issues for the update function as i kept failing. should i handle it on create as well?

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jan 20, 2020
@DrFaust92 DrFaust92 changed the title [WIP]r/cloudtrail - add support for exclude_management_event_sources to event_selector r/cloudtrail - add support for exclude_management_event_sources to event_selector Jan 20, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 1, 2020
@DrFaust92
validate name len
621d79b 
use %w for errors
use enums
use sdk wrappers
@DrFaust92
refactor tests
b56929a
@DrFaust92
Copy link
Collaborator Author

closing this as its a rebase nightmare, will open separate PRs for refactoring tests (and other validations) and for exclude_management_event_sources

@DrFaust92 DrFaust92 closed this Sep 2, 2020
@ghost
Copy link

ghost commented Oct 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_cloudtrail resource: add support for exclude_management_event_sources to event_selector
2 participants
@DrFaust92 @bflad