Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/cloudtrail - add support for exclude_management_event_sources to event_selector #11680

Closed
wants to merge 16 commits into from
Closed

r/cloudtrail - add support for exclude_management_event_sources to event_selector #11680

wants to merge 16 commits into from

Commits on Jul 24, 2020

  1. added plan time validations to cloud_watch_logs_role_arn, `cloud_wa… 

    …tch_logs_group_arn`, `sns_topic_name`, `event_selector.data_resource.values`

added `sns_topic_arn` attribute
added exclude_management_event_sources support
    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    1452130 View commit details
    Browse the repository at this point in the history

  2. add sns arn to docs

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    956d213 View commit details
    Browse the repository at this point in the history

  3. add disappears test case 

    refactor tests
    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    84295fb View commit details
    Browse the repository at this point in the history

  4. refactor tests

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    9925ae5 View commit details
    Browse the repository at this point in the history

  5. fix event selector tests + refactor tags test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    934a7e4 View commit details
    Browse the repository at this point in the history

  6. fix lambda check + rename tests(?)

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    d0d32a5 View commit details
    Browse the repository at this point in the history

  7. actually fix lambda test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    b68bf45 View commit details
    Browse the repository at this point in the history

  8. fix tags2 case

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    92507d7 View commit details
    Browse the repository at this point in the history

  9. fix big mistake :D

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    e09f1bc View commit details
    Browse the repository at this point in the history

  10. tests keep failing if this isnt empty + fix cloudwatch test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5d884e4 View commit details
    Browse the repository at this point in the history

  11. add sns test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    c535e05 View commit details
    Browse the repository at this point in the history

  12. add arn test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    3c5cb25 View commit details
    Browse the repository at this point in the history

  13. disappears test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    8d2a804 View commit details
    Browse the repository at this point in the history

  14. validate name len 

    use %w for errors
use enums
use sdk wrappers
    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    621d79b View commit details
    Browse the repository at this point in the history

  15. refactor tests

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    b56929a View commit details
    Browse the repository at this point in the history

  16. fix kms test

    @DrFaust92
    DrFaust92 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    9eb97b7 View commit details
    Browse the repository at this point in the history