resource/aws_lb_listener: Prevent panics on creation and refresh when API throttled #12617
Conversation
… API throttled Reference: #11640 The previous code was incorrectly not setting the response object when entering final retry logic (`isResourceTimeoutError`) that occurs during API throttling. Since inducing throttling errors is not guaranteed via the acceptance testing without potentially very larges amounts of infrastructure, this change is only verified against regressions. Output from acceptance testing: ``` --- PASS: TestAccAWSLBListener_basic (187.33s) --- PASS: TestAccAWSLBListener_https (189.02s) --- PASS: TestAccAWSLBListener_DefaultAction_Order (189.74s) --- PASS: TestAccAWSLBListener_fixedResponse (194.36s) --- PASS: TestAccAWSLBListener_redirect (194.86s) --- PASS: TestAccAWSLBListener_oidc (196.38s) --- PASS: TestAccAWSLBListener_cognito (196.86s) --- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (205.20s) --- PASS: TestAccAWSLBListener_BackwardsCompatibility (205.18s) --- PASS: TestAccAWSLBListener_Protocol_Tls (605.87s) --- PASS: TestAccAWSLBListener_basicUdp (679.00s) ```
bflad
added
bug
ghost
added
needs-triage
bflad
removed
the
needs-triage
There was a problem hiding this comment.
LGTM 🚀
--- PASS: TestAccAWSLBListener_cognito (175.59s)
--- PASS: TestAccAWSLBListener_redirect (181.94s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (183.14s)
--- PASS: TestAccAWSLBListener_https (184.84s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (184.92s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (185.43s)
--- PASS: TestAccAWSLBListener_oidc (203.72s)
--- PASS: TestAccAWSLBListener_fixedResponse (203.97s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (204.88s)
--- PASS: TestAccAWSLBListener_basic (205.98s)
--- PASS: TestAccAWSLBListener_basicUdp (218.65s)
|
This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
… API throttled (hashicorp#12617) Reference: hashicorp#11640 The previous code was incorrectly not setting the response object when entering final retry logic (`isResourceTimeoutError`) that occurs during API throttling. Since inducing throttling errors is not guaranteed via the acceptance testing without potentially very larges amounts of infrastructure, this change is only verified against regressions. Output from acceptance testing: ``` --- PASS: TestAccAWSLBListener_basic (187.33s) --- PASS: TestAccAWSLBListener_https (189.02s) --- PASS: TestAccAWSLBListener_DefaultAction_Order (189.74s) --- PASS: TestAccAWSLBListener_fixedResponse (194.36s) --- PASS: TestAccAWSLBListener_redirect (194.86s) --- PASS: TestAccAWSLBListener_oidc (196.38s) --- PASS: TestAccAWSLBListener_cognito (196.86s) --- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (205.20s) --- PASS: TestAccAWSLBListener_BackwardsCompatibility (205.18s) --- PASS: TestAccAWSLBListener_Protocol_Tls (605.87s) --- PASS: TestAccAWSLBListener_basicUdp (679.00s) ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Community Note
Closes #11640
Release note for CHANGELOG:
The previous code was incorrectly not setting the response object when entering final retry logic (
isResourceTimeoutError) that occurs during API throttling. Since inducing throttling errors is not guaranteed via the acceptance testing without potentially very larges amounts of infrastructure, this change is only verified against regressions.Output from acceptance testing: