Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lb_listener: Prevent panics on creation and refresh when API throttled #12617

Merged
merged 1 commit into from
Apr 28, 2020

Commits on Apr 1, 2020

  1. resource/aws_lb_listener: Prevent panics on creation and refresh when…

    … API throttled
    
    Reference: #11640
    
    The previous code was incorrectly not setting the response object when entering final retry logic (`isResourceTimeoutError`) that occurs during API throttling. Since inducing throttling errors is not guaranteed via the acceptance testing without potentially very larges amounts of infrastructure, this change is only verified against regressions.
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSLBListener_basic (187.33s)
    --- PASS: TestAccAWSLBListener_https (189.02s)
    --- PASS: TestAccAWSLBListener_DefaultAction_Order (189.74s)
    --- PASS: TestAccAWSLBListener_fixedResponse (194.36s)
    --- PASS: TestAccAWSLBListener_redirect (194.86s)
    --- PASS: TestAccAWSLBListener_oidc (196.38s)
    --- PASS: TestAccAWSLBListener_cognito (196.86s)
    --- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (205.20s)
    --- PASS: TestAccAWSLBListener_BackwardsCompatibility (205.18s)
    --- PASS: TestAccAWSLBListener_Protocol_Tls (605.87s)
    --- PASS: TestAccAWSLBListener_basicUdp (679.00s)
    ```
    bflad committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    288a445 View commit details
    Browse the repository at this point in the history