add Elem attribute to fields of schema.TypeMap per S006 linter rule

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9955

Release note for CHANGELOG:

add elem attribute to fields of typemap per linter S006 rule

Output from acceptance testing:

-- PASS: TestAccAWSInspectorResourceGroup
-- PASS: TestExpandS3AnalyticsFilter
-- PASS: TestAccDataSourceAWSLBListener
-- PASS: TestAccAWSAmiDataSource
-- PASS: TestAccAWSLBListenerRule
-- PASS: TestAccAWSEMRCluster
-- PASS: TestAccAWSSpotInstanceRequestInterruptHibernate
-- PASS: TestAccAWSGlueTrigger
-- PASS: TestAccAWSSSMAssociation
-- PASS: TestLBListenerARNFromRuleARN
-- PASS: TestAccAWSLBListener
-- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility
-- PASS: TestAccAWSS3BucketAnalyticsConfiguration
-- PASS: TestFlattenS3AnalyticsFilter
-- PASS: TestFlattenS3StorageClassAnalysis
-- PASS: TestAccAWSGlueConnection
-- PASS: TestAccAWSCloudWatchMetricAlarm
-- PASS: TestAccAWSAutoScalingGroup
-- PASS: TestAccAWSSagemakerModel
-- PASS: TestAccAWSCloudFormationStack
-- PASS: TestAccAWSSpotInstanceRequestInterruptStop
-- PASS: TestAccAWSCloudWatchEventTarget
-- PASS: TestAccAWSGlueJob
-- PASS: TestAccAWSCloudFrontDistribution
-- PASS: TestExpandS3StorageClassAnalysis
-- PASS: TestAccAWSSpotInstanceRequest
-- PASS: TestAccAWSSpotFleetRequest
-- PASS: TestAccAWSIotThing
-- PASS: TestAccAWSAPIGatewayStage
-- PASS: TestAccAWSCognitoIdentityProvider
-- PASS: TestAccAWSElasticTranscoderPreset
-- PASS: TestAccDataSourceAWSS3BucketObject
-- PASS: TestAccDataSourceAwsSecretsManagerSecret
-- PASS: TestAccAWSDlmLifecyclePolicy
-- PASS: TestAccAWSElasticSearchDomain
-- PASS: TestAccAWSDataElasticsearchDomain
-- PASS: TestAccAWSBudgetsBudget

With the exception of the following failing tests:

TestAccAWSCloudFormationStackInstance_ParameterOverrides
TestAccAWSCloudFormationStack_RetainStack
TestAccAWSCloudFormationStack_basic
TestAccAWSCloudFormationStack_disappears
TestAccAWSCloudFormationStackInstance_disappears_StackSet
TestAccAWSCloudFrontDistribution_RetainOnDelete
TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage

[bflad]

Once the GNUmakefile is updated and CI verifies, LGTM! The only really concerning one here to me was the aws_autoscaling_group resource tags attribute as this is an extremely uncommon implementation (which I'm not sure is tested well in the SDK), but this change doesn't seem to be affecting it as double checked below:

--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (44.00s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (45.60s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (47.18s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (51.18s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (59.39s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (79.75s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (44.86s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (116.07s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (139.47s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (133.07s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (177.29s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (101.10s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (139.31s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (78.11s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (60.67s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (203.71s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (114.20s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (175.67s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (50.55s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (234.50s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (42.23s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (53.65s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (73.67s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (79.95s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (265.00s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (281.96s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (284.21s)
--- PASS: TestAccAWSAutoScalingGroup_tags (287.24s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (287.69s)
--- PASS: TestAccAWSAutoScalingGroup_basic (298.34s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (133.59s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (348.10s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (349.75s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (403.45s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (728.06s)

[ghost]

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!