Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Catalog PortfolioPrincipalAssociation resource added #13837

Commits on Jun 25, 2018

  1. refactoring artifact definition

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    f6321f3 View commit details
    Browse the repository at this point in the history
  2. wip adding artifact block

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    8915edc View commit details
    Browse the repository at this point in the history
  3. refactoring to support new format

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    f365893 View commit details
    Browse the repository at this point in the history
  4. minor code cleanup

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    bfa2bc2 View commit details
    Browse the repository at this point in the history
  5. update based on code review

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    9227706 View commit details
    Browse the repository at this point in the history
  6. updates based on code review

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    9370c2d View commit details
    Browse the repository at this point in the history
  7. refactoring to updated template structure

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    0e57346 View commit details
    Browse the repository at this point in the history
  8. fix test

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    07107de View commit details
    Browse the repository at this point in the history
  9. minor code / test cleanup

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    ea45424 View commit details
    Browse the repository at this point in the history
  10. adding comment

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    051a1a0 View commit details
    Browse the repository at this point in the history
  11. reading template url, fix import

    bw-intuit authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    5179004 View commit details
    Browse the repository at this point in the history
  12. refactored, added acceptance tests and documentation

    trung authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    88f81f0 View commit details
    Browse the repository at this point in the history
  13. minor fixes

    trung authored and Trung Nguyen committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    22148da View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. initial testing

    Felix Candelario committed May 23, 2020
    Configuration menu
    Copy the full SHA
    8870e42 View commit details
    Browse the repository at this point in the history
  2. hope and prayer

    Felix Candelario committed May 23, 2020
    Configuration menu
    Copy the full SHA
    e887f5f View commit details
    Browse the repository at this point in the history
  3. found the work of @trung and getting it up and running

    Felix Candelario committed May 23, 2020
    Configuration menu
    Copy the full SHA
    b261bbd View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. intial creation working

    Felix Candelario committed May 25, 2020
    Configuration menu
    Copy the full SHA
    c01782c View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. updates

    Felix Candelario committed May 26, 2020
    Configuration menu
    Copy the full SHA
    bea44a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Merge remote-tracking branch 'trung/f-service-catalog' into sc-produc…

    …t-and-pp
    
    fix trivial conflicts where master has changed how resources are listed (in website and in aws/provider),
    to reference servicecatalog_product in the right way
    
    also revert the mode change against the servicecatalog_portfolio markdown
    ahgittin committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    383dbfd View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'frc9/master' into sc-product-and-pp

    only pulling in the relevant provisioned-product changes
    ahgittin committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    975fd2d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    848689c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    413cd8a View commit details
    Browse the repository at this point in the history
  5. revert go.mod and go.sum

    ahgittin committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    dee8315 View commit details
    Browse the repository at this point in the history
  6. fix error handling on PP

    ahgittin committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    56493a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1d8c7a6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bfaadb1 View commit details
    Browse the repository at this point in the history
  9. provisioned product - create, read, and delete minimally working

    * create needs to block for completion, then the test (as written) will work in our account
    * then we need product_portfolio_association and make the test work in any account (create a product, not hard-coded)
    * then other TODOs marked in code
    ahgittin committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    243dc9a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Merge branch 'master' into sc-product-and-pp

    * master: (79 commits)
      Update CHANGELOG for hashicorp#8457
      resource/aws_ec2_tag: Finish implementation
      CodeArtifact new service support (hashicorp#13735)
      internal/keyvaluetags: Support servicediscovery and worklink (hashicorp#13732)
      tests/provider: Remove TravisCI (hashicorp#13730)
      update method params in web_acl test check
      Update CHANGELOG for hashicorp#12688
      Fix rebase change
      Fix docs
      Improve error message
      Apply review comments
      Refactor after rebase
      Apply review comments
      Apply changes based on review
      Format test config
      Fix failing build
      Add calculated wcus attribute
      Add documentation
      Add rule_group_reference_statement
      Add rate_based_statement
      ...
    kemitix committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    440ef4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    676b9d0 View commit details
    Browse the repository at this point in the history
  3. sc-product: generate idempotencyToken as resource id

    Match the same method used in other places within the provider to create idempotency tokens.
    kemitix committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    eb1a397 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    258271d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    93fbd22 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    24f04a2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1818eac View commit details
    Browse the repository at this point in the history
  8. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    3b98f38 View commit details
    Browse the repository at this point in the history
  9. sc-product-portfolio-assoc: crud

    TODO - pagination for readResource
    TODO - acceptance tests
    TODO - rename methods for consistency
    kemitix committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    63763ef View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. add docs for service catalog provisioned product and portfolio-produc…

    …t association
    
    minor tweaks to the SC product doc also
    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7a15c8c View commit details
    Browse the repository at this point in the history
  2. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    222fea6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    971ac5b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    edc5efd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b24619a View commit details
    Browse the repository at this point in the history
  6. update PP and add'l fields

    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    25ab24a View commit details
    Browse the repository at this point in the history
  7. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    07c104a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    610384d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4e025ed View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3c661c6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1b8d9f3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e1327f5 View commit details
    Browse the repository at this point in the history
  13. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    515b1cd View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0b7e87e View commit details
    Browse the repository at this point in the history
  15. fix ID syntax for portfolio-product-association -- all tests passing,…

    … importing
    
    but PP test is still using a pre-existing product :( because it needs a launch path
    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7377257 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c94fab4 View commit details
    Browse the repository at this point in the history
  17. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    035dfac View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    59fa151 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. add portfolio-principal association, and use it for product provision…

    …ing test
    
    working to provision the product. but deletions don't work as it is trying to delete the product before the association to portfolio is deleted.
    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c34bb97 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    d22fcd8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    888aa0b View commit details
    Browse the repository at this point in the history
  4. sc-portfolio-assocs: only fetch pages when assoc not yet found

    Avoids fetching all pages then searching the results for the matching record.
    kemitix committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    06af8fb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9294fb1 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'sc-product-and-pp' of github.com:cloudsoft/terraform-pr…

    …ovider-aws into sc-product-and-pp
    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    80ff8af View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f096f5d View commit details
    Browse the repository at this point in the history
  8. SC provisioned-product test passing!

    just needed s3 permissions. and the stock import test doesn't like the different provider.
    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f5ca63e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ae3e74d View commit details
    Browse the repository at this point in the history
  10. apply gofmt

    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bc84989 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9793677 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b8b8b4b View commit details
    Browse the repository at this point in the history
  13. fix most linter-flagged issues

    "Description" omitted, and one use of "provider" is needed (for aliases)
    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    866f047 View commit details
    Browse the repository at this point in the history
  14. address go lint issues

    ahgittin committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    19fca67 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    603d288 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Configuration menu
    Copy the full SHA
    eee00a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08716d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70ac64a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    625c9b7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2dcb083 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    85d33e4 View commit details
    Browse the repository at this point in the history
  7. restore portfolio-principal-association additions for now, focus on i…

    …ncremental PR with just this code, for review
    
    This reverts commit 625c9b7.
    ahgittin committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8cfecab View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    46303a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. add and update all tests, all passing

    * disappears, import, various updates
    * portfolio updated to retry on delete if it is in use while other things are being cleaned up
    * read has retry logic to deal with ID being returned instead of ARN for just-created roles
    ahgittin committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    a7f6049 View commit details
    Browse the repository at this point in the history
  2. Fix two linter problems

    ahgittin committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ccba736 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    11d3c81 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Configuration menu
    Copy the full SHA
    40a91d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87e6ab0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd79364 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f1b3c20 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    be3065b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1294114 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Merge branch 'master' into f-servicecatalog-portfolio-principal-assoc…

    …iation
    
    Conflicts:
    	website/aws.erb - no longer needed (drop our changes)
    ahgittin committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    33be215 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8bae8b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08e3b91 View commit details
    Browse the repository at this point in the history