-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Catalog PortfolioProductAssociation #13864
Service Catalog PortfolioProductAssociation #13864
Conversation
…t-and-pp fix trivial conflicts where master has changed how resources are listed (in website and in aws/provider), to reference servicecatalog_product in the right way also revert the mode change against the servicecatalog_portfolio markdown
only pulling in the relevant provisioned-product changes
* create needs to block for completion, then the test (as written) will work in our account * then we need product_portfolio_association and make the test work in any account (create a product, not hard-coded) * then other TODOs marked in code
* master: (79 commits) Update CHANGELOG for hashicorp#8457 resource/aws_ec2_tag: Finish implementation CodeArtifact new service support (hashicorp#13735) internal/keyvaluetags: Support servicediscovery and worklink (hashicorp#13732) tests/provider: Remove TravisCI (hashicorp#13730) update method params in web_acl test check Update CHANGELOG for hashicorp#12688 Fix rebase change Fix docs Improve error message Apply review comments Refactor after rebase Apply review comments Apply changes based on review Format test config Fix failing build Add calculated wcus attribute Add documentation Add rule_group_reference_statement Add rate_based_statement ...
Match the same method used in other places within the provider to create idempotency tokens.
…io-product-association
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
Conflicts: website/aws.erb - no longer needed (drop our changes)
…io-product-association Conflicts: website/aws.erb - no longer needed (drop our changes)
…io-product-association
This has been updated as per the 18 Aug notification to use the v2 sdk and remove |
@ahgittin Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider! |
@ahgittin @cloudsoft Thank you very much for all your work on this PR! I'm excited to work with you on this. However, in order to work with this PR, I need two things:
Since we look forward to adding this feature to the AWS Provider, we need you to make these changes by March 11, 2021. If you are unable to do this, we understand and thank you for your work. However, we will not be able to use this contribution. |
Replaced by #18074 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This PR adds support for the
aws_servicecatalog_portfolio_product_association
.This part of the provisioned_product dependencies in #13797 and will be included there, but this PR has the changes for that one resource isolated for easier review, done in such a way that this PR can be merged on its own. As a product association depends on product, this depends on and builds the PR for
aws_servicecatalog_product
#13834. Once that is reviewed and merged the incremental difference in this PR should be much smaller.All comments to date on #13797 (and lessons since then) have been incorporated here. This is ready for review.
Community Note
Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
Release note for
CHANGELOG
:New Resource:
aws_servicecatalog_portfolio_product_association
Output from acceptance testing: