Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Update hardcoded AZs (Redshift) #14720

Merged
merged 1 commit into from
Aug 20, 2020
Merged

tests/provider: Update hardcoded AZs (Redshift) #14720

merged 1 commit into from
Aug 20, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 18, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995
Fixes #13575

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud partition):

--- PASS: TestAccAWSRedshiftSubnetGroup_basic (22.17s) (Normally fails)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (18.10s) (Normally fails)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (19.39s) (Normally fails)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (17.07s) (Normally fails)
--- FAIL: TestAccAWSRedshiftCluster_snapshotCopy (515.49s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (573.56s) (Normally fails)
--- FAIL: TestAccAWSRedshiftCluster_changeEncryption1 (579.13s) (Normally fails)
--- FAIL: TestAccAWSRedshiftCluster_changeEncryption2 (586.81s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_basic (708.77s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (963.11s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1210.85s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (1585.51s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1779.88s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_tags (1869.08s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (2126.80s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (2157.86s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (2220.04s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2447.26s) (Normally fails)
--- FAIL: TestAccAWSRedshiftCluster_updateNodeCount (3832.42s) (Normally fails)

Output from acceptance testing (commercial/standard partition):

--- FAIL: TestAccAWSRedshiftSubnetGroup_updateDescription (22.37s) (Normally fails)
--- FAIL: TestAccAWSRedshiftSubnetGroup_tags (22.99s) (Normally fails)
--- FAIL: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (23.41s) (Normally fails)
--- FAIL: TestAccAWSRedshiftSubnetGroup_basic (23.52s) (Normally fails)
--- FAIL: TestAccAWSRedshiftCluster_publiclyAccessible (33.30s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (323.21s)
--- PASS: TestAccAWSRedshiftCluster_tags (374.74s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (651.72s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (664.60s)
--- PASS: TestAccAWSRedshiftCluster_basic (1582.86s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (1602.79s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1816.29s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1940.33s)
--- FAIL: TestAccAWSRedshiftCluster_changeEncryption1 (1975.03s) (Normally fails)
--- FAIL: TestAccAWSRedshiftCluster_updateNodeType (1993.89s) (Normally fails)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (2139.78s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (2211.94s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (2504.73s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3478.20s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 18, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 18, 2020
@YakDriver YakDriver force-pushed the t-hardaz-redshift branch 2 times, most recently from 30c7559 to b92fbcc Compare August 18, 2020 19:19
@YakDriver YakDriver marked this pull request as ready for review August 18, 2020 19:20
@YakDriver YakDriver requested a review from a team August 18, 2020 19:20
@YakDriver YakDriver mentioned this pull request Aug 18, 2020
Closed
@bflad bflad self-assigned this Aug 19, 2020
bflad
bflad approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor consistency adjustment, otherwise looks good 🚀

Output from acceptance testing in AWS Commercial (failure due to default timeouts, will submit separate issue):

--- PASS: TestAccAWSRedshiftSubnetGroup_basic (35.33s)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (44.44s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (47.44s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (56.60s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (533.88s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (539.49s)
--- PASS: TestAccAWSRedshiftCluster_basic (1008.33s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1452.71s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1464.48s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (1620.46s)
--- PASS: TestAccAWSRedshiftCluster_tags (1674.28s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1872.37s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (2013.19s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2161.06s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (2412.34s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (2667.80s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (3084.20s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3204.58s)
--- FAIL: TestAccAWSRedshiftCluster_updateNodeCount (3628.00s)

Output from acceptance testing in AWS GovCloud (US) (failures due to default timeouts and potential PreCheck, will submit separate issue(s)):

--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (540.23s)
--- PASS: TestAccAWSRedshiftSubnetGroup_basic (11.10s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (18.79s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (20.56s)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (18.68s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (929.26s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1193.47s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1556.44s)
--- FAIL: TestAccAWSRedshiftCluster_updateNodeType (2433.99s)
--- FAIL: TestAccAWSRedshiftCluster_updateNodeCount (2453.80s)
--- FAIL: TestAccAWSRedshiftCluster_changeEncryption2 (2633.01s)
--- FAIL: TestAccAWSRedshiftCluster_changeEncryption1 (2695.43s)
--- FAIL: TestAccAWSRedshiftCluster_basic (2719.56s)
--- PASS: TestAccAWSRedshiftCluster_tags (2790.51s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (3028.01s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (3573.63s)
--- FAIL: TestAccAWSRedshiftCluster_snapshotCopy (3583.54s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (3584.42s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (3585.52s)

aws/resource_aws_redshift_cluster_test.go Outdated Show resolved Hide resolved
@bflad bflad linked an issue Aug 20, 2020 that may be closed by this pull request
Redshift Cluster acceptance tests fail in GovCloud #13575
Closed
@bflad
Copy link
Contributor

bflad commented Aug 20, 2020

I've linked this to #13575 since I believe it covers it.

@bflad bflad mentioned this pull request Aug 20, 2020
Closed
3 tasks
@YakDriver YakDriver force-pushed the t-hardaz-redshift branch 3 times, most recently from 873c690 to 324627f Compare August 20, 2020 15:23
@YakDriver YakDriver merged commit 27f41f1 into master Aug 20, 2020
@YakDriver YakDriver deleted the t-hardaz-redshift branch August 20, 2020 15:39
@YakDriver YakDriver added this to the v3.3.0 milestone Aug 20, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/redshift Issues and PRs that pertain to the redshift service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Redshift Cluster acceptance tests fail in GovCloud
2 participants
@YakDriver @bflad