Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "id" fields from schema definitions #1626

Merged
merged 3 commits into from
Oct 26, 2017
Merged

remove "id" fields from schema definitions #1626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bfc1c8
remove "id" fields from schema definitions
jbardin Sep 8, 2017
37da2b0
replace Set and Get of "id" with Id and SetId
jbardin Sep 9, 2017
ac556d7
Put Optional 'id' fields back to data sources
radeksimko Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions aws/data_source_aws_security_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ func dataSourceAwsSecurityGroup() *schema.Resource {
},
"filter": ec2CustomFiltersSchema(),

"id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"arn": {
Type: schema.TypeString,
Computed: true,
Expand Down
6 changes: 0 additions & 6 deletions aws/data_source_aws_subnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ func dataSourceAwsSubnet() *schema.Resource {

"filter": ec2CustomFiltersSchema(),

"id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"state": {
Type: schema.TypeString,
Optional: true,
Expand Down
6 changes: 0 additions & 6 deletions aws/data_source_aws_vpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ func dataSourceAwsVpc() *schema.Resource {

"filter": ec2CustomFiltersSchema(),

"id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"instance_tenancy": {
Type: schema.TypeString,
Computed: true,
Expand Down
5 changes: 0 additions & 5 deletions aws/data_source_aws_vpc_peering_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ func dataSourceAwsVpcPeeringConnection() *schema.Resource {
Read: dataSourceAwsVpcPeeringConnectionRead,

Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},
"status": {
Type: schema.TypeString,
Optional: true,
Expand Down
5 changes: 0 additions & 5 deletions aws/data_source_aws_vpn_gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ func dataSourceAwsVpnGateway() *schema.Resource {
Read: dataSourceAwsVpnGatewayRead,

Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},
"state": {
Type: schema.TypeString,
Optional: true,
Expand Down
5 changes: 0 additions & 5 deletions aws/opsworks_layers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ var (

func (lt *opsworksLayerType) SchemaResource() *schema.Resource {
resourceSchema := map[string]*schema.Schema{
"id": &schema.Schema{
Type: schema.TypeString,
Computed: true,
},

"auto_assign_elastic_ips": &schema.Schema{
Type: schema.TypeBool,
Optional: true,
Expand Down
4 changes: 0 additions & 4 deletions aws/resource_aws_ami.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,6 @@ func resourceAwsAmiCommonSchema(computed bool) map[string]*schema.Schema {
}

return map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Computed: true,
},
"image_location": {
Type: schema.TypeString,
Optional: !computed,
Expand Down
4 changes: 0 additions & 4 deletions aws/resource_aws_opsworks_application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ func resourceAwsOpsworksApplication() *schema.Resource {
Update: resourceAwsOpsworksApplicationUpdate,
Delete: resourceAwsOpsworksApplicationDelete,
Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Computed: true,
},
"name": {
Type: schema.TypeString,
Required: true,
Expand Down
5 changes: 0 additions & 5 deletions aws/resource_aws_opsworks_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ func resourceAwsOpsworksInstance() *schema.Resource {
},

Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Computed: true,
},

"agent_version": {
Type: schema.TypeString,
Optional: true,
Expand Down
4 changes: 0 additions & 4 deletions aws/resource_aws_opsworks_permission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ func resourceAwsOpsworksPermission() *schema.Resource {
Read: resourceAwsOpsworksPermissionRead,

Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Computed: true,
},
"allow_ssh": {
Type: schema.TypeBool,
Computed: true,
Expand Down
4 changes: 0 additions & 4 deletions aws/resource_aws_opsworks_rds_db_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ func resourceAwsOpsworksRdsDbInstance() *schema.Resource {
Read: resourceAwsOpsworksRdsDbInstanceRead,

Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Computed: true,
},
"stack_id": {
Type: schema.TypeString,
Required: true,
Expand Down
5 changes: 0 additions & 5 deletions aws/resource_aws_opsworks_stack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ func resourceAwsOpsworksStack() *schema.Resource {
Computed: true,
},

"id": {
Type: schema.TypeString,
Computed: true,
},

"name": {
Type: schema.TypeString,
Required: true,
Expand Down
5 changes: 0 additions & 5 deletions aws/resource_aws_opsworks_user_profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ func resourceAwsOpsworksUserProfile() *schema.Resource {
Delete: resourceAwsOpsworksUserProfileDelete,

Schema: map[string]*schema.Schema{
"id": {
Type: schema.TypeString,
Computed: true,
},

"user_arn": {
Type: schema.TypeString,
Required: true,
Expand Down