-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ds/ec2_instance_type_offering locations: Add locations attribute #16704
ds/ec2_instance_type_offering locations: Add locations attribute #16704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @orgito 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
0b0c6e4
to
3fae369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSEc2InstanceTypeOfferingsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2InstanceTypeOfferingsDataSource_ -timeout 180m
=== RUN TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== RUN TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
=== CONT TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== CONT TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (9.89s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (11.85s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 15.649s
8253a62
to
383202e
Compare
@orgito Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #16703
Release note for CHANGELOG:
Output from acceptance testing: