Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added locations and location_types to the output of aws_ec2_instance_type_offerings. #15272 #17794

Closed
wants to merge 1 commit into from

Conversation

mjulianotq
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15272

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2InstanceTypeOfferingsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2InstanceTypeOfferingsDataSource_ -timeout 120m
=== RUN   TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== RUN   TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
=== CONT  TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== CONT  TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (22.55s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (26.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       26.979s

@mjulianotq mjulianotq requested a review from a team as a code owner February 24, 2021 14:56
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 24, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 24, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mjulianotq 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@mjulianotq mjulianotq changed the title Added locations and location_types to the output. #15272 Added locations and location_types to the output of aws_ec2_instance_type_offerings. #15272 Feb 26, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 23, 2021
@ewbankkit
Copy link
Contributor

@mjulianotq Thanks for the contribution 🎉 👏.
I have cherry picked your commit into #16704.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2_instance_type_offerings should have an attribute for location_types and locations
2 participants