Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Config Organization Conformance Pack resource #17298

Merged

Conversation

ctrawick
Copy link
Contributor

@ctrawick ctrawick commented Jan 27, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11098

Output from acceptance testing:

$ time AWS_PROFILE=terraform-test make testacc TESTARGS='-run=TestAccAWSConfig_serial/OrganizationConformancePack'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSConfig_serial/OrganizationConformancePack -timeout 120m
=== RUN   TestAccAWSConfig_serial
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/S3Template
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/ExcludedAccounts
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/basic
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/disappears
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/InputParameters
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/S3Delivery
--- PASS: TestAccAWSConfig_serial (4410.30s)
    --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack (4410.30s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/S3Template (761.03s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/ExcludedAccounts (771.40s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/basic (685.72s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/disappears (756.77s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/InputParameters (768.84s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/S3Delivery (666.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       4412.048s


@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 27, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 27, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ctrawick 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 27, 2021
@ctrawick ctrawick marked this pull request as ready for review January 27, 2021 17:14
@ctrawick ctrawick requested a review from a team as a code owner January 27, 2021 17:14
@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 11, 2021
@anGie44 anGie44 self-assigned this Feb 11, 2021
@anGie44
Copy link
Contributor

anGie44 commented Feb 11, 2021

Hi again @ctrawick 👋 Thank you for your work on this PR! Similar to #17313 , this PR looks great overall and just needs some minor adjustments to be merged. Make sure that you have checked the box "Allow edits from maintainers." Again, thank you for your help and we look forward to this addition to the AWS provider!

@anGie44 anGie44 force-pushed the f-aws_config_organization_conformance_pack-add branch from c66efc4 to eba6d82 Compare February 12, 2021 01:10
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 17, 2021
@anGie44 anGie44 force-pushed the f-aws_config_organization_conformance_pack-add branch 5 times, most recently from 3f9744f to eba6d82 Compare February 17, 2021 21:54
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Feb 17, 2021
@anGie44 anGie44 force-pushed the f-aws_config_organization_conformance_pack-add branch 2 times, most recently from 24cab02 to 2abedd1 Compare April 16, 2021 05:57
@anGie44 anGie44 force-pushed the f-aws_config_organization_conformance_pack-add branch from 2abedd1 to 23adde2 Compare April 16, 2021 06:02
@dooreelko
Copy link
Contributor

Any progress with this? Please please please?

@matt-cahill
Copy link

Yes, any ETA on this PR would be very much appreciated if one is available. I'm currently holding out on a click-ops implementation of organization conformance packs in a new deployment. Wondering if we should wait, or go for it and deal with the import later?

@RobReus
Copy link

RobReus commented Jun 2, 2021

Any ETA on this pull request @anGie44 ? Would be great to know if we should invest time in a work around right now, or if we can just wait for this to be released.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jun 16, 2021
@anGie44 anGie44 force-pushed the f-aws_config_organization_conformance_pack-add branch 9 times, most recently from 0c9ce53 to 6ec3c87 Compare July 9, 2021 02:23
@anGie44 anGie44 modified the milestones: Roadmap, v3.50.0 Jul 9, 2021
@anGie44 anGie44 force-pushed the f-aws_config_organization_conformance_pack-add branch from 6ec3c87 to 3030e8e Compare July 9, 2021 02:39
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this one in 🚀 Thanks again for your contributions @ctrawick and to those following along this feature, ty for your patience!

Output of acceptance tests:

    --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/basic (430.88s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/disappears (433.61s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/inputParameters (509.58s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/excludedAccounts (715.79s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/forceNew (1174.17s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/S3Delivery (456.54s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateTemplateBody (739.65s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/S3Template (433.01s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateInputParameters (694.38s)        
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateS3Delivery (606.38s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateS3Template (576.01s)

@anGie44 anGie44 merged commit bae3b38 into hashicorp:main Jul 9, 2021
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/configservice Issues and PRs that pertain to the configservice service. size/XL Managed by automation to categorize the size of a PR. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants