-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AWS Config Organization Conformance Pack resource #17298
Added AWS Config Organization Conformance Pack resource #17298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ctrawick 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hi again @ctrawick 👋 Thank you for your work on this PR! Similar to #17313 , this PR looks great overall and just needs some minor adjustments to be merged. Make sure that you have checked the box "Allow edits from maintainers." Again, thank you for your help and we look forward to this addition to the AWS provider! |
c66efc4
to
eba6d82
Compare
3f9744f
to
eba6d82
Compare
24cab02
to
2abedd1
Compare
2abedd1
to
23adde2
Compare
Any progress with this? Please please please? |
Yes, any ETA on this PR would be very much appreciated if one is available. I'm currently holding out on a click-ops implementation of organization conformance packs in a new deployment. Wondering if we should wait, or go for it and deal with the import later? |
Any ETA on this pull request @anGie44 ? Would be great to know if we should invest time in a work around right now, or if we can just wait for this to be released. |
0c9ce53
to
6ec3c87
Compare
6ec3c87
to
3030e8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this one in 🚀 Thanks again for your contributions @ctrawick and to those following along this feature, ty for your patience!
Output of acceptance tests:
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/basic (430.88s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/disappears (433.61s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/inputParameters (509.58s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/excludedAccounts (715.79s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/forceNew (1174.17s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/S3Delivery (456.54s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateTemplateBody (739.65s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/S3Template (433.01s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateInputParameters (694.38s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateS3Delivery (606.38s)
--- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateS3Template (576.01s)
This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #11098
Output from acceptance testing: