Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS Config Conformance Pack resource #17313

Merged
merged 8 commits into from
Feb 11, 2021
Merged

Added AWS Config Conformance Pack resource #17313

merged 8 commits into from
Feb 11, 2021

Conversation

ctrawick
Copy link
Contributor

@ctrawick ctrawick commented Jan 27, 2021 •
edited by anGie44
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11098

Output from acceptance testing:

$ time AWS_PROFILE=terraform-test make testacc TESTARGS='-run=TestAccAWSConfig_serial/ConformancePack'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSConfig_serial/ConformancePack -timeout 120m
=== RUN   TestAccAWSConfig_serial
=== RUN   TestAccAWSConfig_serial/ConformancePack
=== RUN   TestAccAWSConfig_serial/ConformancePack/basic
=== RUN   TestAccAWSConfig_serial/ConformancePack/disappears
=== RUN   TestAccAWSConfig_serial/ConformancePack/InputParameters
=== RUN   TestAccAWSConfig_serial/ConformancePack/S3Delivery
=== RUN   TestAccAWSConfig_serial/ConformancePack/S3Template
--- PASS: TestAccAWSConfig_serial (776.44s)
    --- PASS: TestAccAWSConfig_serial/ConformancePack (776.44s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/basic (185.64s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/disappears (129.40s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/InputParameters (173.69s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/S3Delivery (142.46s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/S3Template (145.26s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       778.161s

...

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 27, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 27, 2021
@ctrawick ctrawick marked this pull request as ready for review January 27, 2021 17:14
@ctrawick ctrawick requested a review from a team as a code owner January 27, 2021 17:14
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Feb 10, 2021
@anGie44
Copy link
Contributor

anGie44 commented Feb 10, 2021

Hi @ctrawick 👋 Thank you for your work on this PR! In order to expedite the process and get this into our upcoming release, I will likely make some minor adjustments. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider!

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 11, 2021
@anGie44 anGie44 force-pushed the f-aws_config_conformance_pack-add branch 2 times, most recently from 4145375 to dc70059 Compare February 11, 2021 07:04
@anGie44 anGie44 force-pushed the f-aws_config_conformance_pack-add branch from dc70059 to 76758ea Compare February 11, 2021 07:12
anGie44
anGie44 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @ctrawick 🚀 !

Output of acceptance tests (commercial):

--- PASS: TestAccAWSConfig_serial (3499.26s)
    --- PASS: TestAccAWSConfig_serial/OrganizationCustomRule (12.05s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/TriggerTypes (1.95s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/basic (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/errorHandling (0.12s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/ExcludedAccounts (2.99s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/MaximumExecutionFrequency (0.14s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/ResourceTypesScope (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/TagKeyScope (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/TagValueScope (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/disappears (5.58s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/Description (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/InputParameters (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/LambdaFunctionArn (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationCustomRule/ResourceIdScope (0.35s)
    --- PASS: TestAccAWSConfig_serial/OrganizationManagedRule (17.08s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/RuleIdentifier (2.89s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/TagKeyScope (0.79s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/TagValueScope (0.12s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/basic (5.49s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/disappears (0.14s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/errorHandling (0.12s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/ExcludedAccounts (0.12s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/ResourceTypesScope (0.86s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/Description (6.17s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/InputParameters (0.12s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/MaximumExecutionFrequency (0.13s)
        --- SKIP: TestAccAWSConfig_serial/OrganizationManagedRule/ResourceIdScope (0.13s)
 --- PASS: TestAccAWSConfig_serial/RemediationConfiguration (349.60s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/basic (82.70s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/disappears (80.57s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/recreates (94.59s)
        --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/updates (91.74s)
    --- PASS: TestAccAWSConfig_serial/Config (836.18s)
        --- PASS: TestAccAWSConfig_serial/Config/scopeTagKey (89.58s)
        --- PASS: TestAccAWSConfig_serial/Config/scopeTagValue (90.77s)
        --- PASS: TestAccAWSConfig_serial/Config/tags (103.63s)
        --- PASS: TestAccAWSConfig_serial/Config/basic (79.25s)
        --- PASS: TestAccAWSConfig_serial/Config/customlambda (111.90s)
        --- PASS: TestAccAWSConfig_serial/Config/importLambda (120.10s)
        --- PASS: TestAccAWSConfig_serial/Config/ownerAws (79.81s)
        --- PASS: TestAccAWSConfig_serial/Config/importAws (81.37s)
        --- PASS: TestAccAWSConfig_serial/Config/scopeTagKeyEmpty (79.76s)
    --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus (145.23s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus/basic (34.74s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus/startEnabled (74.71s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorderStatus/importBasic (35.78s)
    --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder (102.06s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder/allParams (32.96s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder/importBasic (35.00s)
        --- PASS: TestAccAWSConfig_serial/ConfigurationRecorder/basic (34.10s)
    --- PASS: TestAccAWSConfig_serial/ConformancePack (1936.62s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/basic (130.50s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/forceNew (258.31s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/inputParameters (129.64s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/S3Delivery (137.50s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/S3Template (140.32s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/S3TemplateAndTemplateBody (139.88s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/updateInputParameters (200.73s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/updateS3Template (244.06s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/updateTemplateBody (236.78s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/disappears (127.68s)
        --- PASS: TestAccAWSConfig_serial/ConformancePack/updateS3Delivery (191.22s)
    --- PASS: TestAccAWSConfig_serial/DeliveryChannel (100.43s)
        --- PASS: TestAccAWSConfig_serial/DeliveryChannel/basic (33.20s)
        --- PASS: TestAccAWSConfig_serial/DeliveryChannel/allParams (32.94s)
        --- PASS: TestAccAWSConfig_serial/DeliveryChannel/importBasic (34.30s)
PASS

@anGie44 anGie44 added this to the v3.28.0 milestone Feb 11, 2021
@anGie44 anGie44 added the new-resource Introduces a new resource. label Feb 11, 2021
@anGie44 anGie44 merged commit 87303f7 into hashicorp:main Feb 11, 2021
anGie44 added a commit that referenced this pull request Feb 11, 2021
@anGie44
Update CHANGELOG for #17313
40e2a37
@anGie44 anGie44 mentioned this pull request Feb 11, 2021
Merged
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/configservice Issues and PRs that pertain to the configservice service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ctrawick @anGie44