Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for Network Loadbalancers #1806

Merged
merged 1 commit into from
Oct 4, 2017

Commits on Oct 4, 2017

  1. provider/aws: Add support for Network Loadbalancers

    Fixes: hashicorp#1618
    
    In terraform, we had the idea of an alb. In AWS this doesn't exist. ALBs
    are actually Load balancers of type `application`
    
    Therefore, the first part of this PR adds a new parameter to ALBs called
    `load_balancer_type`. We default this to `application` to follow the
    same idea as the current behaviour
    
    The next part of the PR will then change the idea of an alb -> lb
    
    In order to preserve backwards compatibility, we have added another
    resource name to the same schema type. This means we effectively have an
    alias of aws_alb and aws_lb. This includes updating *all* of the tests
    to make sure and remove the idea of ALB and rename to LB and then we
    will add a check to make sure we can still check that an ALB can be
    created in the old resource
    stack72 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    1af53b1 View commit details
    Browse the repository at this point in the history