New Resource: ECR Lifecycle Policy #1869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Importer Remove `arn` attribute
Since June 2016 SMS recipients no longer need to opt-in to SNS. See also https://aws.amazon.com/blogs/aws/new-worldwide-delivery-of-amazon-sns-messages-via-sms/
Fixes: hashicorp#1588 ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSALBTargetGroup_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSALBTargetGroup_ -timeout 120m === RUN TestAccAWSALBTargetGroup_basic --- PASS: TestAccAWSALBTargetGroup_basic (73.55s) === RUN TestAccAWSALBTargetGroup_namePrefix --- PASS: TestAccAWSALBTargetGroup_namePrefix (72.26s) === RUN TestAccAWSALBTargetGroup_generatedName --- PASS: TestAccAWSALBTargetGroup_generatedName (74.94s) === RUN TestAccAWSALBTargetGroup_changeNameForceNew --- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (129.78s) === RUN TestAccAWSALBTargetGroup_changeProtocolForceNew --- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (151.66s) === RUN TestAccAWSALBTargetGroup_changePortForceNew --- PASS: TestAccAWSALBTargetGroup_changePortForceNew (129.73s) === RUN TestAccAWSALBTargetGroup_changeVpcForceNew --- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (112.48s) === RUN TestAccAWSALBTargetGroup_tags --- PASS: TestAccAWSALBTargetGroup_tags (124.72s) === RUN TestAccAWSALBTargetGroup_updateHealthCheck --- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (122.61s) === RUN TestAccAWSALBTargetGroup_updateSticknessEnabled --- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (170.23s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1161.982s ```
It’s a valid combination to set `self false` and `cidr_blocks`. So changing the validation to reflect this as currently you cannot actively set `self` to `false` without getting a validation error.
… documentation to fall in line with changes in AWS
AWS has updated the idle connection timeout to 4000 seconds (http://docs.aws.amazon.com/elasticloadbalancing/latest/classic/config-idle-timeout.html). This change is to bring the provider current with that setting.
Ninir
added
the
enhancement
Link to Elastic Beanstalk Supported Platforms documentation for solution stack name reference.
Update ELB create to align with 4000s idle timeout
website: Add AWS documentation link to elastic_beanstalk_solution_stack datasource
resource/aws_spot_fleet_request: Add support for instance_interruption_behaviour
…ry_stream (hashicorp#1605) * First attempt at resolving hashicorp#1601 * Removing unused method * Add acceptance test for aws_kinesis_firehose_delivery_stream using Kinesis Stream as source * Updated "source_configuration" to be "kinesis_source_configuration"
Added missing attribute in db_option_group documentation
aws_instance resources export ipv6_addresses which may be used like:
```
value = "${element(aws_instance.consul_server.*.ipv6_addresses[0], count.index)}"
```
…-route-waiters r/vpn_connection_route: Wait until route is available/deleted
…dtrail_service_account Add 'aws_cloudtrail_service_account' data source
Add support for SQS queue tags
…tance-subnet-id r/spot_instances_request: Fix failing acceptance test (SubnetId)
…latest vendor: Update hashicorp/terraform to latest
* some test config cleanups * refactor to re-use the same config
|
@radeksimko I reflect all of your feedbacks, rebase master and run testacc. |
…corp#1811) * r/aws_{ami,ami_copy,ami_from_instance}: Configurable timeouts. * r/aws_{ami,ami_copy,ami_from_instance}: Configurable timeouts: pass timeout directly rather than entire `ResourceData`.
|
Sorry I made a mistake when rebasing... 🙇 @radeksimko |
|
@radeksimko I made a mistake when rebasing and it seems difficult for me to fix it... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
waiting-response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1868