-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include additional kinesis-settings in dms endpoint #18750
Conversation
added the following settings: IncludeTransactionDetails IncludePartitionValue PartitionIncludeSchemaTable IncludeTableAlterOperations IncludeControlDetails IncludeNullAndEmpty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @kduvekot-wehkamp-nl 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
added the new elements to the schema of the Kinesis settings
all checks looks to be passing .. it looks "similar" to the pull request that created the kinesis endpoint initially. I hope you can do a good review of this pull request .. and that it can be incorporated in the a next version. It would certainly make our platform team happy .. so they can move away from the manual updates via the CLI for this. |
@kduvekot-wehkamp-nl Thank you for submitting this PR! It looks like a promising start. However, in order to progress, we ask that you include an acceptance test that verifies the new arguments and run the tests to make sure everything works. You'll find more here: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/running-and-writing-acceptance-tests.md |
Thanks for the pointers ... I will do my best to get it included. |
Superseded by #20904. |
@kduvekot-wehkamp-nl Thanks for the contribution 🎉 👏. |
@ewbankkit how to proceed with this one? |
Commits incorporated into #20084. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
added the following settings:
IncludeTransactionDetails
IncludePartitionValue
PartitionIncludeSchemaTable
IncludeTableAlterOperations
IncludeControlDetails
IncludeNullAndEmpty
I am not a programmer, not am I able to check if this is correct, but I thought I would make the effort to start this pull request because in a project that I am working on we needed to have these settings.
Community Note
Relates OR Closes #0000
Output from acceptance testing: