Add S3 Connection Attributes to DMS Endpoint

[sbrandtb]

Adds a few commonly used parameters to the explicit S3 connection block.

Please note that IMO, we should not default those settings because they are defaulted on AWS side. However, the API is a bit inconsistent in which properties the API returns on GET if the resource was not created with particular resources (i.e.
parquet_timestamp_in_millisecond is always returned, data_format is not if it was not explicitly used for creation, yet it defaults to csv. In order to make tests and usage of the provider a bit more sane, I defaulted all properties.

Please also note that, if you test this and try to update extra connection attributes that it does not trigger an update of the resource. This is not a bug introduced with this pull request. It exists in current main.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

 $ make testacc TESTARGS='-run=TestAccAwsDmsEndpoint_S3'    
==> Checking that code complies with gofmt requirements...                                                
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDmsEndpoint_S3 -timeout 120m               
=== RUN   TestAccAwsDmsEndpoint_S3            
=== PAUSE TestAccAwsDmsEndpoint_S3                   
=== RUN   TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes           
=== PAUSE TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes                                              
=== CONT  TestAccAwsDmsEndpoint_S3                 
=== CONT  TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
--- PASS: TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes (63.72s)                                     
--- PASS: TestAccAwsDmsEndpoint_S3 (108.84s)
PASS                                   
ok      github.com/terraform-providers/terraform-provider-aws/aws       108.966s 

...

[github-actions]

Welcome @sbrandtb 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[sbrandtb]

Added two more properties and updated tests.

[YakDriver]

Related #14340
Related #14620
Related #18750

[sbrandtb]

I want to note that I am slightly disappointed by this pull request being open for more than three months now with seven upvotes while for instance #19371 got merged after a few days with only one, while the official statement is that upvotes is how you prioritize pull requests.

I was planning to contribute more after this, but honestly after waiting for three months without any official feedback, I am more than demotivated.

[anGie44]

Hi @sbrandtb , thank you for this PR and apologies for the wait! Please note that having a PR linked to an existing Github issue is recommended to ensure visibility for maintainers. Overall, looks great just a couple comments to address. Also, please add a .changelog/17591.txt file to this PR in accordance with our guidelines seen here: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/pullrequest-submission-and-lifecycle.md#changelog-process.

Please reach out if you have any additional questions. If you are not readily available to submit the requested changes, not a problem! Feel free to drop us a note and we'll continue the work you have here 😃

[sbrandtb]

Thanks for the re-review :) I did not test it yet myself, just wanted to show activity 😆 Will work on that later this week.

[anGie44]

No worries @sbrandtb , appreciate the efforts!
Reach out when ready :)

[anGie44]

Hi @sbrandtb , just checking in to see how things are going. Anything I can help with?

[sbrandtb]

I'll be working on it tomorrow. Sorry for the delay.

[anGie44]

Hi @sbrandtb , thank you for all your changes! This enhancement LGTM 🚀

Output of acceptance tests (commercial):

--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes (171.26s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (171.49s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (171.50s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (171.60s)
--- PASS: TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes (171.72s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (188.12s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (223.91s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (224.03s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (231.87s)
--- PASS: TestAccAwsDmsEndpoint_basic (231.95s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (232.09s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (234.65s)
--- PASS: TestAccAwsDmsEndpoint_S3 (234.95s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb_Update (237.47s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (253.79s)

[github-actions]

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.