Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pending] New Resource: aws_workspaces_workspace #1917

Closed

Conversation

atsushi-ishibashi
Copy link
Contributor

#434
I have to crawl a website which only suits IE so I'd like to add workspaces resource.
AWS API provides CreateWorkspaces which can create some workspaces at a time, but it's complicated to write multi workspaces in one resource like below.

resource "aws_workspaces_workspaces" "hoge" {
  workspace = {
    a = a1
    b = b1
    ....
  }

  workspace = {
    a = a2
    b = b2
    ....
  }
}

So I'm going to add aws_workspaces_workspace and for each CreateWorkspaces works with one element.

@radeksimko radeksimko added the new-resource Introduces a new resource. label Oct 16, 2017
@radeksimko radeksimko added the size/XXL Managed by automation to categorize the size of a PR. label Nov 15, 2017
@radeksimko radeksimko added the service/workspaces Issues and PRs that pertain to the workspaces service. label Jan 16, 2018
@radeksimko radeksimko changed the title [WIP]New Resource: Workspaces [WIP] New Resource: aws_workspaces_workspace Jan 16, 2018
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. and removed size/XXL Managed by automation to categorize the size of a PR. labels Feb 4, 2018
@atsushi-ishibashi
Copy link
Contributor Author

atsushi-ishibashi commented Feb 17, 2018

I got the below error and I couldn't api to register the directory to workspaces.

The specified directory could not be found in the specified region.

I asked aws support but they said that they could't support api to register so you had to do it from web console.

So this PR is pending until aws will support it.

@atsushi-ishibashi atsushi-ishibashi changed the title [WIP] New Resource: aws_workspaces_workspace [Pending] New Resource: aws_workspaces_workspace Feb 17, 2018
@liamjbennett
Copy link
Contributor

Reached the same issue here: hashicorp/terraform#7806

@bcornils
Copy link
Contributor

looks like we have a check failing and the branch has conflicts. Has anyone had time to assess or review criticality of the failure?

@sstarcher
Copy link

@atsushi-ishibashi are you going to be able to pick this back up or do you need someone to take it over.

@bflad
Copy link
Contributor

bflad commented Oct 9, 2018

Closing this PR due to lack of response. I should note that the aws_workspaces_bundle data source is separately being merged in #3243 and that will be released in version 1.40.0 of the AWS provider, likely middle of this week. 👍

@bflad bflad closed this Oct 9, 2018
@cmaxwellau
Copy link

cmaxwellau commented Nov 1, 2018

@atsushi-ishibashi @liamjbennett

I work for AWS, and have a customer that would like to use terraform for workspaces.

Would one of you be able to concisely describe the issue for me so that I can pass it on to the service teams?

Cam

@tamsky
Copy link
Contributor

tamsky commented Jan 30, 2019

@cmaxwellau

Would one of you be able to concisely describe the issue for me so that I can pass it on to the service teams?

tl;dr:
The AWS service team must create a new API endpoint, which currently doesn't exist (endpoint name is up to the service team, but this is my guess as to what it would be called:) CreateWorkspaceDirectories.


Given that there hasn't been a reply from anyone else in the last 90 days,
I'll try my best to give you my (admittedly non-expert) understanding of the issue.

To anyone reading this, it's highly likely that you know this issue better than I.
Please correct me if you see anything wrong here:

AIUI, in order to create a workspace, using the API call CreateWorkspaces[1] one must first have already registered a workspace directory and provide a valid DirectoryId in the API call payload.

The act of "registering a workspace directory" is currently described in the adminguide at [2].
This appears to be an interactive process that demands a human use a web browser to click and type on the AWS web console.

Terraform automated tests require api-based environment creation/destruction, so we can't automate tests unless we have an API endpoint for creating a Workspace Directory.

@tamsky
Copy link
Contributor

tamsky commented Jan 30, 2019

I see now that @liamjbennett replied over in
hashicorp/terraform#10794 (comment)

An AWS rep recently replied in the aws forum [1] with some low-voltage news:

Our internal team has confirmed that there is already an existing feature request placed on our system to address this requirement.
At this moment, we don't have an ETA on when this feature will be released.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. new-resource Introduces a new resource. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants