[WIP] provider/aws: Add aws_workspace resource

[liamjbennett]

• CRUD
• Exported Attributes
• Timeouts (> 20 mins)
• Acceptance Tests
• Docs

[liamjbennett]

Question: how do I make the resource work with the count parameter?

[radeksimko]

@liamjbennett It should just work out of the box - that's a terraform's core feature, not resource specific thing.

The only thing to keep in mind is that you can replicate resources, but not inner nested blocks inside resources. e.g. you can use count for aws_elb to create as many ELBs as you want, but you cannot use count for aws_elb.listeners to create N listeners for a given ELB.

[stack72]

we can wrap this log and return err into

return fmt.Errorf("Error finding bundle: %q"m err)

[stack72]

Hey @liamjbennett

A few small comments inline. Nothing major.

Please can you drop the results of the test into the PR as well for reference :)

P.

[liamjbennett]

@stack72 @radeksimko
Getting an error when running the first acceptence test:

panic: interface conversion: interface {} is nil, not *aws.AWSClient

Full Gist

[radeksimko]

@liamjbennett Have a look at the diff of builtin/providers/aws/provider.go:

 -      ConfigureFunc: providerConfigure,

That's most likely the cause of that error 😉

[liamjbennett]

@radeksimko Doh. Yes that solved the issue.

I am now getting a genuine test failure - which I beleieve might be something to do with the active directory dependency. Is there anyway to see the TF run that is executed as part of the test?

[radeksimko]

Is there anyway to see the TF run that is executed as part of the test?

You mean to see the debug output from tests? Setting the right ENV variables may help: https://github.com/hashicorp/terraform/blob/master/website/source/docs/internals/debugging.html.md#debugging-terraform

[liamjbennett]

This is currently blocked because the workspace api support registering the directory e.g.

https://docs.aws.amazon.com/workspaces/latest/adminguide/registration.html

[liamjbennett]

Ref: aws/aws-sdk-go#814

[liamjbennett]

Given that we are unable to test this due to the missing api's and the total silence from aws on the matter I am going to close this PR for now and come back to it at a future point in time.

[jayyvis]

@liamjbennett
If directory registration API is the only missing piece, then how about separating it out of workspace provisioning?

Cloud Formation currently handles it that way.

Before creating a Workspace in CloudFormation, you must register a Directory Service directory with Workspaces.

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-workspaces-workspace.html

[liamjbennett]

@jayyvis yes we do that with cloud formation also but for the sake of this PR there is no way to actually run the tests without manually performing that registration, which is not acceptable.

[wmantly]

A year on, is there any way to get this done now?

[apparentlymart]

Since the AWS provider is no longer developed in this repository, the tracking issue for this is hashicorp/terraform-provider-aws#434 . There will be no further updates posted here because the relevant code is no longer in this repository.