Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/servicecatalog: New resources (constraint, product_portfolio_association) #19385

Merged
merged 34 commits into from
May 19, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogConstraint_disappears (30.13s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (32.54s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (51.03s)

--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (70.62s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (72.07s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogConstraint_disappears (32.37s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (35.45s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (56.15s)

--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (73.96s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (76.10s)

@YakDriver YakDriver requested a review from a team as a code owner May 14, 2021 19:03
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 14, 2021
@ghost ghost removed the size/XL Managed by automation to categorize the size of a PR. label May 17, 2021
@YakDriver YakDriver changed the title [WIP] r/servicecatalog_constraint: New resource r/servicecatalog_constraint: New resource May 17, 2021
@YakDriver YakDriver changed the title r/servicecatalog_constraint: New resource r/servicecatalog: New resources (constraint, product_portfolio_association) May 17, 2021
@ewbankkit ewbankkit self-assigned this May 18, 2021

```terraform
resource "aws_servicecatalog_constraint" "example" {
description = "Back off, man. I'm a scientist."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suitably professional 😄.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogConstraint_basic
=== PAUSE TestAccAWSServiceCatalogConstraint_basic
=== RUN   TestAccAWSServiceCatalogConstraint_disappears
=== PAUSE TestAccAWSServiceCatalogConstraint_disappears
=== RUN   TestAccAWSServiceCatalogConstraint_update
=== PAUSE TestAccAWSServiceCatalogConstraint_update
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== CONT  TestAccAWSServiceCatalogConstraint_basic
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== CONT  TestAccAWSServiceCatalogConstraint_update
=== CONT  TestAccAWSServiceCatalogConstraint_disappears
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (34.07s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (35.60s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (57.56s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (72.15s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (74.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	77.395s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogConstraint_basic
=== PAUSE TestAccAWSServiceCatalogConstraint_basic
=== RUN   TestAccAWSServiceCatalogConstraint_disappears
=== PAUSE TestAccAWSServiceCatalogConstraint_disappears
=== RUN   TestAccAWSServiceCatalogConstraint_update
=== PAUSE TestAccAWSServiceCatalogConstraint_update
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== CONT  TestAccAWSServiceCatalogConstraint_basic
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== CONT  TestAccAWSServiceCatalogConstraint_update
=== CONT  TestAccAWSServiceCatalogConstraint_disappears
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (37.16s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (39.65s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (65.73s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (75.69s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (77.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	80.995s

@ewbankkit ewbankkit removed their assignment May 18, 2021
@YakDriver YakDriver added this to the v3.42.0 milestone May 19, 2021
@YakDriver YakDriver merged commit 91cf32b into main May 19, 2021
@YakDriver YakDriver deleted the f-servicecat-constraint branch May 19, 2021 13:26
github-actions bot pushed a commit that referenced this pull request May 19, 2021
@ghost
Copy link

ghost commented May 20, 2021

This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants