r/servicecatalog: New resources (constraint, product_portfolio_association)

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogConstraint_disappears (30.13s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (32.54s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (51.03s)

--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (70.62s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (72.07s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogConstraint_disappears (32.37s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (35.45s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (56.15s)

--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (73.96s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (76.10s)

[ewbankkit]

Suitably professional 😄.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogConstraint_basic
=== PAUSE TestAccAWSServiceCatalogConstraint_basic
=== RUN   TestAccAWSServiceCatalogConstraint_disappears
=== PAUSE TestAccAWSServiceCatalogConstraint_disappears
=== RUN   TestAccAWSServiceCatalogConstraint_update
=== PAUSE TestAccAWSServiceCatalogConstraint_update
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== CONT  TestAccAWSServiceCatalogConstraint_basic
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== CONT  TestAccAWSServiceCatalogConstraint_update
=== CONT  TestAccAWSServiceCatalogConstraint_disappears
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (34.07s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (35.60s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (57.56s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (72.15s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (74.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	77.395s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogConstraint_basic
=== PAUSE TestAccAWSServiceCatalogConstraint_basic
=== RUN   TestAccAWSServiceCatalogConstraint_disappears
=== PAUSE TestAccAWSServiceCatalogConstraint_disappears
=== RUN   TestAccAWSServiceCatalogConstraint_update
=== PAUSE TestAccAWSServiceCatalogConstraint_update
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== RUN   TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== CONT  TestAccAWSServiceCatalogConstraint_basic
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== CONT  TestAccAWSServiceCatalogConstraint_update
=== CONT  TestAccAWSServiceCatalogConstraint_disappears
=== CONT  TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (37.16s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (39.65s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (65.73s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (75.69s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (77.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	80.995s

[ghost]

This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.