-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/servicecatalog: New resources (constraint, product_portfolio_association) #19385
Conversation
027be98
to
76e267d
Compare
|
||
```terraform | ||
resource "aws_servicecatalog_constraint" "example" { | ||
description = "Back off, man. I'm a scientist." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suitably professional 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_ -timeout 180m
=== RUN TestAccAWSServiceCatalogConstraint_basic
=== PAUSE TestAccAWSServiceCatalogConstraint_basic
=== RUN TestAccAWSServiceCatalogConstraint_disappears
=== PAUSE TestAccAWSServiceCatalogConstraint_disappears
=== RUN TestAccAWSServiceCatalogConstraint_update
=== PAUSE TestAccAWSServiceCatalogConstraint_update
=== RUN TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== RUN TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== CONT TestAccAWSServiceCatalogConstraint_basic
=== CONT TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== CONT TestAccAWSServiceCatalogConstraint_update
=== CONT TestAccAWSServiceCatalogConstraint_disappears
=== CONT TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (34.07s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (35.60s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (57.56s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (72.15s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (74.49s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 77.395s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogConstraint_\|TestAccAWSServiceCatalogProductPortfolioAssociation_ -timeout 180m
=== RUN TestAccAWSServiceCatalogConstraint_basic
=== PAUSE TestAccAWSServiceCatalogConstraint_basic
=== RUN TestAccAWSServiceCatalogConstraint_disappears
=== PAUSE TestAccAWSServiceCatalogConstraint_disappears
=== RUN TestAccAWSServiceCatalogConstraint_update
=== PAUSE TestAccAWSServiceCatalogConstraint_update
=== RUN TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== RUN TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
=== CONT TestAccAWSServiceCatalogConstraint_basic
=== CONT TestAccAWSServiceCatalogProductPortfolioAssociation_basic
=== CONT TestAccAWSServiceCatalogConstraint_update
=== CONT TestAccAWSServiceCatalogConstraint_disappears
=== CONT TestAccAWSServiceCatalogProductPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (37.16s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (39.65s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (65.73s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (75.69s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (77.91s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 80.995s
This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #15369
Relates #18074
Relates #19122
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):