Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds/servicecatalog_constraint: New data source #19499

Merged
merged 9 commits into from
May 28, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 24, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19385

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogConstraintDataSource_basic (32.17s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogConstraintDataSource_basic (35.02s)

@YakDriver YakDriver requested a review from a team as a code owner May 24, 2021 15:57
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label May 24, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 24, 2021
@anGie44 anGie44 self-assigned this May 26, 2021
@anGie44 anGie44 added the new-data-source Introduces a new data source. label May 26, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a couple small comments

Output of acceptance test in commercial:

--- PASS: TestAccAWSServiceCatalogConstraintDataSource_basic (304.00s)

@YakDriver YakDriver merged commit 4929519 into main May 28, 2021
@YakDriver YakDriver deleted the f-servicecat-ds-constraint branch May 28, 2021 14:14
@github-actions github-actions bot added this to the v3.43.0 milestone May 28, 2021
github-actions bot pushed a commit that referenced this pull request May 28, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants