Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter/semgrep: Restore domain name check #22076

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 7, 2021

Restores the Semgrep check for domain names

Relates #20000

Output from acceptance testing:

N/A

@gdavison gdavison added the linter Pertains to changes to or issues with the various linters. label Dec 7, 2021
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Dec 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% semgrep --config .semgrep.yml 
Running 27 rules...
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|27/27
ran 27 rules on 3698 files: 0 findings

@gdavison gdavison merged commit 660bdbe into main Dec 7, 2021
@gdavison gdavison deleted the semgrep-restore-domainname branch December 7, 2021 21:24
@github-actions github-actions bot added this to the v3.69.0 milestone Dec 7, 2021
github-actions bot pushed a commit that referenced this pull request Dec 7, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants