Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter/semgrep: Restore domain name check #22076

Merged
merged 2 commits into from
Dec 7, 2021
Merged

linter/semgrep: Restore domain name check #22076

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b78db8f
Restores `domain-name` Semgrep rule
gdavison Nov 17, 2021
01c20be
Makes inclusion and exclusion more explicit
gdavison Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions .semgrep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,10 +559,29 @@ rules:
message: Domain names should be in the namespaces defined in RFC 6761 (https://datatracker.ietf.org/doc/html/rfc6761) as reserved for testing
paths:
include:
- aws/data_source*.go
- aws/resource_aws_a*.go
- aws/resource_aws_b*.go
- aws/resource_aws_workspaces_*.go
- internal/service/**/*_data_source_test.go
- internal/service/[a-b]*
- internal/service/d*
- internal/service/[f-z]*
exclude:
- internal/service/firehose/delivery_stream_test.go
- internal/service/globalaccelerator/accelerator_test.go
- internal/service/iam/openid_connect_provider_test.go
- internal/service/lightsail/domain_test.go
- internal/service/mq/broker_test.go
- internal/service/opsworks/application_test.go
- internal/service/opsworks/stack_test.go
- internal/service/ram/resource_share_accepter_test.go
- internal/service/rds/instance_test.go
- internal/service/route53/sweep.go
- internal/service/s3/bucket_test.go
- internal/service/s3control/bucket_test.go
- internal/service/sagemaker/code_repository_test.go
- internal/service/sagemaker/notebook_instance_test.go
- internal/service/shield/protection_test.go
- internal/service/storagegateway/cached_iscsi_volume.go
- internal/service/storagegateway/cached_iscsi_volume_test.go
- internal/service/transfer/server_test.go
patterns:
- patterns:
- pattern-regex: '[\"`].*(?<!(example))\.(com|net|org)\b'
Expand Down