Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS Acceptance Test Failures #23560

Merged
merged 32 commits into from
Mar 14, 2022
Merged

RDS Acceptance Test Failures #23560

merged 32 commits into from
Mar 14, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 8, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21541
Closes #21879

Output from acceptance testing:

% make testacc TESTS=TestAccRDSCertificateDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCertificateDataSource_'  -timeout 180m
--- PASS: TestAccRDSCertificateDataSource_latestValidTill (13.09s)
--- PASS: TestAccRDSCertificateDataSource_id (13.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	16.679s
% make testacc TESTS=TestAccRDSClusterParameterGroup_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterParameterGroup_'  -timeout 180m
--- PASS: TestAccRDSClusterParameterGroup_disappears (16.54s)
--- PASS: TestAccRDSClusterParameterGroup_namePrefix (22.08s)
--- PASS: TestAccRDSClusterParameterGroup_generatedName (22.11s)
--- PASS: TestAccRDSClusterParameterGroup_withApplyMethod (22.23s)
--- PASS: TestAccRDSClusterParameterGroup_NamePrefix_parameter (22.25s)
--- PASS: TestAccRDSClusterParameterGroup_only (22.33s)
--- PASS: TestAccRDSClusterParameterGroup_GeneratedName_parameter (22.35s)
--- PASS: TestAccRDSClusterParameterGroup_caseParameters (31.01s)
--- PASS: TestAccRDSClusterParameterGroup_updateParameters (35.47s)
--- PASS: TestAccRDSClusterParameterGroup_basic (78.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	80.373s
% make testacc TESTS=TestAccRDSClusterRoleAssociation_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterRoleAssociation_'  -timeout 180m
--- PASS: TestAccRDSClusterRoleAssociation_basic (130.47s)
--- PASS: TestAccRDSClusterRoleAssociation_Disappears_cluster (137.65s)
--- PASS: TestAccRDSClusterRoleAssociation_disappears (148.14s)
--- PASS: TestAccRDSClusterRoleAssociation_Disappears_role (148.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	149.790s
% make testacc TESTS=TestAccRDSClusterEndpoint_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterEndpoint_'  -timeout 180m
--- PASS: TestAccRDSClusterEndpoint_tags (1362.08s)
--- PASS: TestAccRDSClusterEndpoint_basic (1407.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1408.436s
% make testacc TESTS=TestAccRDSClusterSnapshotDataSource_ PKG=rds                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterSnapshotDataSource_'  -timeout 180m
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterIdentifier (150.25s)
--- PASS: TestAccRDSClusterSnapshotDataSource_mostRecent (172.59s)
--- PASS: TestAccRDSClusterSnapshotDataSource_dbClusterSnapshotIdentifier (191.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	193.158s
% make testacc TESTS=TestAccRDSClusterInstance_ PKG=rds                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterInstance_'  -timeout 180m
--- PASS: TestAccRDSClusterInstance_caCertificateIdentifier (546.83s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql (676.96s)
--- PASS: TestAccRDSClusterInstance_kmsKey (714.28s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL2 (719.62s)
--- PASS: TestAccRDSClusterInstance_generatedName (736.41s)
--- PASS: TestAccRDSClusterInstance_namePrefix (736.51s)
--- PASS: TestAccRDSClusterInstance_copyTagsToSnapshot (737.57s)
--- PASS: TestAccRDSClusterInstance_disappears (756.88s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey (757.53s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey (798.39s)
--- PASS: TestAccRDSClusterInstance_publiclyAccessible (848.29s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL2_defaultKeyToCustomKey (851.02s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1 (912.43s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql (912.63s)
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled (951.22s)
--- PASS: TestAccRDSClusterInstance_performanceInsightsRetentionPeriod (1021.53s)
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled (1101.36s)
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved (1102.97s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1 (662.00s)
--- PASS: TestAccRDSClusterInstance_monitoringInterval (1359.55s)
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL2 (835.83s)
--- PASS: TestAccRDSClusterInstance_az (789.08s)
--- PASS: TestAccRDSClusterInstance_isAlreadyBeingDeleted (821.47s)
--- PASS: TestAccRDSClusterInstance_basic (1573.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1575.090s
% make testacc TESTS=TestAccRDSEngineVersionDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEngineVersionDataSource_'  -timeout 180m
--- PASS: TestAccRDSEngineVersionDataSource_upgradeTargets (12.02s)
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnly (12.02s)
--- PASS: TestAccRDSEngineVersionDataSource_basic (12.02s)
--- PASS: TestAccRDSEngineVersionDataSource_preferred (15.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	16.757s
% make testacc TESTS=TestAccRDSClusterSnapshot_ PKG=rds     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterSnapshot_'  -timeout 180m
--- PASS: TestAccRDSClusterSnapshot_basic (162.65s)
--- PASS: TestAccRDSClusterSnapshot_tags (271.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	273.123s
% make testacc TESTS=TestAccRDSEventCategoriesDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEventCategoriesDataSource_'  -timeout 180m
--- PASS: TestAccRDSEventCategoriesDataSource_sourceType (11.29s)
--- PASS: TestAccRDSEventCategoriesDataSource_basic (11.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	12.535s
% make testacc TESTS=TestAccRDSEventSubscription_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEventSubscription_'  -timeout 180m
--- PASS: TestAccRDSEventSubscription_disappears (77.78s)
--- PASS: TestAccRDSEventSubscription_basic (82.81s)
--- PASS: TestAccRDSEventSubscription_Name_generated (82.94s)
--- PASS: TestAccRDSEventSubscription_namePrefix (83.07s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (97.11s)
--- PASS: TestAccRDSEventSubscription_tags (109.29s)
--- PASS: TestAccRDSEventSubscription_categories (187.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	188.467s
% make testacc TESTS=TestAccRDSInstanceDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceDataSource_'  -timeout 180m
--- PASS: TestAccRDSInstanceDataSource_ec2Classic (541.95s)
--- PASS: TestAccRDSInstanceDataSource_basic (577.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	578.471s
% make testacc TESTS=TestAccRDSOptionGroup_ PKG=rds    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSOptionGroup_'  -timeout 180m
--- PASS: TestAccRDSOptionGroup_namePrefix (28.31s)
--- PASS: TestAccRDSOptionGroup_basic (30.09s)
--- PASS: TestAccRDSOptionGroup_optionGroupDescription (32.09s)
--- PASS: TestAccRDSOptionGroup_timeoutBlock (32.32s)
--- PASS: TestAccRDSOptionGroup_generatedName (33.98s)
--- PASS: TestAccRDSOptionGroup_multipleOptions (45.25s)
--- PASS: TestAccRDSOptionGroup_Option_optionSettings (58.99s)
--- PASS: TestAccRDSOptionGroup_OptionOptionSettings_multipleNonDefault (61.15s)
--- PASS: TestAccRDSOptionGroup_oracleOptionsUpdate (66.00s)
--- PASS: TestAccRDSOptionGroup_tags (66.86s)
--- PASS: TestAccRDSOptionGroup_Tags_withOptions (77.48s)
--- PASS: TestAccRDSOptionGroup_sqlServerOptionsUpdate (96.21s)
--- PASS: TestAccRDSOptionGroup_OptionOptionSettings_iamRole (123.10s)
--- PASS: TestAccRDSOptionGroup_basicDestroyWithInstance (532.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	533.568s
% make testacc TESTS=TestAccRDSParameterGroup_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSParameterGroup_'  -timeout 180m
--- PASS: TestAccRDSParameterGroup_disappears (13.50s)
--- PASS: TestAccRDSParameterGroup_generatedName (16.69s)
--- PASS: TestAccRDSParameterGroup_only (17.57s)
--- PASS: TestAccRDSParameterGroup_namePrefix (18.42s)
--- PASS: TestAccRDSParameterGroup_withApplyMethod (19.69s)
--- PASS: TestAccRDSParameterGroup_matchDefault (21.71s)
--- PASS: TestAccRDSParameterGroup_caseWithMixedParameters (26.89s)
--- PASS: TestAccRDSParameterGroup_updateParameters (28.34s)
--- PASS: TestAccRDSParameterGroup_caseParameters (28.94s)
--- PASS: TestAccRDSParameterGroup_limit (36.03s)
--- PASS: TestAccRDSParameterGroup_basic (37.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	39.147s
% make testacc TESTS=TestAccRDSInstanceRoleAssociation_basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceRoleAssociation_basic'  -timeout 180m
--- PASS: TestAccRDSInstanceRoleAssociation_disappears (983.08s)
--- PASS: TestAccRDSInstanceRoleAssociation_basic (860.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	984.319s
% make testacc TESTS=TestAccRDSOrderableInstanceDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSOrderableInstanceDataSource_'  -timeout 180m
--- PASS: TestAccRDSOrderableInstanceDataSource_basic (32.95s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication (308.73s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion (323.25s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling (344.97s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring (348.54s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption (362.83s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredVersion (380.21s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights (396.05s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClass (412.67s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIops (443.27s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication (474.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	475.678s
% make testacc TESTS=TestAccRDSProxyDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSProxyDataSource_'  -timeout 180m
--- PASS: TestAccRDSProxyDataSource_basic (622.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	623.919s
% make testacc TESTS=TestAccRDSProxyEndpoint_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSProxyEndpoint_'  -timeout 180m
--- PASS: TestAccRDSProxyEndpoint_disappears (709.69s)
--- PASS: TestAccRDSProxyEndpoint_Disappears_proxy (716.42s)
--- PASS: TestAccRDSProxyEndpoint_basic (743.50s)
--- PASS: TestAccRDSProxyEndpoint_targetRole (770.53s)
--- PASS: TestAccRDSProxyEndpoint_tags (812.63s)
--- PASS: TestAccRDSProxyEndpoint_vpcSecurityGroupIDs (925.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	926.834s
% make testacc TESTS=TestAccRDSProxyDefaultTargetGroup_ PKG=rds 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSProxyDefaultTargetGroup_'  -timeout 180m
--- PASS: TestAccRDSProxyDefaultTargetGroup_maxIdleConnectionsPercent (470.62s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_disappears (472.35s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_emptyConnectionPool (536.29s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_connectionBorrowTimeout (542.23s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_basic (558.64s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_maxConnectionsPercent (603.35s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_initQuery (612.57s)
--- PASS: TestAccRDSProxyDefaultTargetGroup_sessionPinningFilters (652.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	653.868s
% make testacc TESTS=TestAccRDSSecurityGroup_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSecurityGroup_'  -timeout 180m
--- PASS: TestAccRDSSecurityGroup_basic (16.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	17.898s
% make testacc TESTS=TestAccRDSProxy_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSProxy_'  -timeout 180m
--- PASS: TestAccRDSProxy_basic (500.79s)
--- PASS: TestAccRDSProxy_disappears (580.11s)
--- PASS: TestAccRDSProxy_tags (617.12s)
--- PASS: TestAccRDSProxy_idleClientTimeout (619.45s)
--- PASS: TestAccRDSProxy_requireTLS (640.22s)
--- PASS: TestAccRDSProxy_roleARN (641.70s)
--- PASS: TestAccRDSProxy_debugLogging (660.34s)
--- PASS: TestAccRDSProxy_name (681.18s)
--- PASS: TestAccRDSProxy_authIAMAuth (682.45s)
--- PASS: TestAccRDSProxy_authSecretARN (691.07s)
--- PASS: TestAccRDSProxy_vpcSecurityGroupIDs (693.43s)
--- PASS: TestAccRDSProxy_authDescription (700.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	702.384s
% make testacc TESTS=TestAccRDSSnapshotDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSnapshotDataSource_'  -timeout 180m
--- PASS: TestAccRDSSnapshotDataSource_basic (625.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	627.150s
% make testacc TESTS=TestAccRDSProxyTarget_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSProxyTarget_'  -timeout 180m
--- PASS: TestAccRDSProxyTarget_cluster (551.51s)
--- PASS: TestAccRDSProxyTarget_disappears (2114.23s)
--- PASS: TestAccRDSProxyTarget_instance (2197.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2198.939s
% make testacc TESTS=TestAccRDSSubnetGroupDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSubnetGroupDataSource_'  -timeout 180m
--- PASS: TestAccRDSSubnetGroupDataSource_nonexistent (3.15s)
--- PASS: TestAccRDSSubnetGroupDataSource_basic (20.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	22.097s
% make testacc TESTS=TestAccRDSSubnetGroup_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSubnetGroup_'  -timeout 180m
--- PASS: TestAccRDSSubnetGroup_generatedName (21.03s)
--- PASS: TestAccRDSSubnetGroup_namePrefix (21.71s)
--- PASS: TestAccRDSSubnetGroup_basic (23.59s)
--- PASS: TestAccRDSSubnetGroup_withUndocumentedCharacters (23.63s)
--- PASS: TestAccRDSSubnetGroup_updateDescription (37.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	39.009s
% make testacc TESTS=TestAccRDSSnapshot_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSnapshot_'  -timeout 180m
--- PASS: TestAccRDSSnapshot_tags (664.71s)
--- PASS: TestAccRDSSnapshot_basic (757.58s)
--- PASS: TestAccRDSSnapshot_disappears (786.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	787.744s
% make testacc TESTS=TestAccRDSCluster_ PKG=rds                             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_'  -timeout 180m
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (148.65s)
--- PASS: TestAccRDSCluster_backupsUpdate (165.17s)
--- PASS: TestAccRDSCluster_basic (166.57s)
--- PASS: TestAccRDSCluster_tags (167.93s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (169.36s)
--- PASS: TestAccRDSCluster_port (185.90s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (193.02s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (194.62s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (221.87s)
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (275.54s)
--- PASS: TestAccRDSCluster_deletionProtection (177.79s)
--- PASS: TestAccRDSCluster_iamAuth (176.53s)
--- PASS: TestAccRDSCluster_scaling (368.87s)
--- PASS: TestAccRDSCluster_snapshotIdentifier (394.71s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (418.53s)
--- PASS: TestAccRDSCluster_engineVersion (462.69s)
--- PASS: TestAccRDSCluster_kmsKey (162.27s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery (526.75s)
--- PASS: TestAccRDSCluster_EngineMode_global (187.61s)
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (371.87s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (377.33s)
--- PASS: TestAccRDSCluster_EngineMode_multiMaster (132.52s)
--- PASS: TestAccRDSCluster_EngineMode_parallelQuery (176.19s)
--- PASS: TestAccRDSCluster_engineMode (423.59s)
--- PASS: TestAccRDSCluster_missingUserNameCausesError (6.12s)
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (219.99s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (408.76s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (145.95s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (388.24s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (421.83s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (481.77s)
--- PASS: TestAccRDSCluster_updateIAMRoles (176.26s)
--- PASS: TestAccRDSCluster_encrypted (156.29s)
--- PASS: TestAccRDSCluster_dbSubnetGroupName (132.78s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (428.85s)
--- PASS: TestAccRDSCluster_generatedName (125.54s)
--- PASS: TestAccRDSCluster_takeFinalSnapshot (166.43s)
--- PASS: TestAccRDSCluster_clusterIdentifierPrefix (125.47s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (261.56s)
--- PASS: TestAccRDSCluster_availabilityZones (146.52s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (387.29s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (397.51s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (406.98s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (428.48s)
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (389.78s)
--- PASS: TestAccRDSCluster_backtrackWindow (198.35s)
--- PASS: TestAccRDSCluster_pointInTimeRestore (429.18s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (479.13s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1114.97s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (498.91s)
--- PASS: TestAccRDSCluster_onlyMajorVersion (710.35s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (1604.54s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (1926.25s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (2030.46s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2050.52s)
--- FAIL: TestAccRDSCluster_s3Restore (1518.86s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (1582.93s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (1889.58s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (1904.27s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2777.369s
% make testacc TESTS=TestAccRDSInstance_ PKG=rds
--- FAIL: TestAccRDSInstance_DBSubnetGroupName_ramShared (35.16s)
--- FAIL: TestAccRDSInstance_S3Import_basic (18.75s)
--- FAIL: TestAccRDSInstance_S3Import_nameDeprecated (18.25s)
--- FAIL: TestAccRDSInstance_S3Import_nameGenerated (19.91s)
--- FAIL: TestAccRDSInstance_S3Import_namePrefix (19.18s)
--- FAIL: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared (512.42s)
--- PASS: TestAccRDSInstance_allowMajorVersionUpgrade (480.46s)
--- PASS: TestAccRDSInstance_basic (487.89s)
--- PASS: TestAccRDSInstance_caCertificateIdentifier (452.84s)
--- PASS: TestAccRDSInstance_cloudWatchLogsExport (520.28s)
--- PASS: TestAccRDSInstance_dbSubnetGroupName (480.08s)
--- PASS: TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs (481.35s)
--- PASS: TestAccRDSInstance_deletionProtection (552.41s)
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL (899.31s)
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL (919.02s)
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle (890.96s)
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql (515.46s)
--- PASS: TestAccRDSInstance_finalSnapshotIdentifier (895.06s)
--- PASS: TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot (670.20s)
--- PASS: TestAccRDSInstance_iamAuth (475.04s)
--- PASS: TestAccRDSInstance_isAlreadyBeingDeleted (485.19s)
--- PASS: TestAccRDSInstance_kmsKey (481.57s)
--- PASS: TestAccRDSInstance_license (1073.50s)
--- PASS: TestAccRDSInstance_maxAllocatedStorage (603.63s)
--- PASS: TestAccRDSInstance_minorVersion (464.46s)
--- PASS: TestAccRDSInstance_monitoringInterval (1117.89s)
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled (809.45s)
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved (681.81s)
--- PASS: TestAccRDSInstance_MonitoringRoleARN_removedToEnabled (641.55s)
--- PASS: TestAccRDSInstance_MSSQL_domain (3946.53s)
--- PASS: TestAccRDSInstance_MSSQL_domainSnapshotRestore (3253.36s)
--- PASS: TestAccRDSInstance_MSSQL_domainSnapshotRestore (3270.20s)
--- PASS: TestAccRDSInstance_MSSQL_tz (1827.16s)
--- PASS: TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion (2015.47s)
--- PASS: TestAccRDSInstance_NameDeprecated_basic (407.25s)
--- PASS: TestAccRDSInstance_nameGenerated (455.33s)
--- PASS: TestAccRDSInstance_namePrefix (435.32s)
--- PASS: TestAccRDSInstance_NationalCharacterSet_oracle (872.70s)
--- PASS: TestAccRDSInstance_noDeleteAutomatedBackups (666.37s)
--- PASS: TestAccRDSInstance_NoNationalCharacterSet_oracle (808.06s)
--- PASS: TestAccRDSInstance_onlyMajorVersion (355.33s)
--- PASS: TestAccRDSInstance_optionGroup (412.35s)
--- PASS: TestAccRDSInstance_password (410.24s)
--- PASS: TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled (742.07s)
--- PASS: TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled (811.84s)
--- PASS: TestAccRDSInstance_performanceInsightsKMSKeyID (1217.43s)
--- PASS: TestAccRDSInstance_performanceInsightsRetentionPeriod (968.54s)
--- PASS: TestAccRDSInstance_portUpdate (566.24s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_addLater (1348.24s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorage (1454.15s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops (1677.27s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade (1330.80s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade (1382.47s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_availabilityZone (1116.04s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod (1543.54s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupWindow (1322.02s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1365.81s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier (1293.22s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName (1925.24s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled (1484.43s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iops (1820.57s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow (1415.19s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage (1533.60s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring (1394.30s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_multiAZ (2006.62s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_nameGenerated (1496.93s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_namePrefix (1372.81s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth (1480.10s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue (1470.54s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth (1591.58s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica (1568.54s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep (2525.46s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled (1936.63s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_port (1682.54s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_replicaMode (2295.63s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs (1250.72s)
--- PASS: TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared (1896.55s)
--- PASS: TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs (2019.62s)
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier (1581.98s)
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceResourceID (1406.26s)
--- PASS: TestAccRDSInstance_separateIopsUpdate (557.05s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_allocatedStorage (1534.50s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade (1962.73s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved (1135.58s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade (1168.11s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_availabilityZone (1329.98s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride (1564.21s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset (1710.72s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupWindow (1177.70s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_basic (1116.15s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName (914.89s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs (1169.50s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_deletionProtection (1214.57s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled (1212.26s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io1Storage (1511.68s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow (1054.71s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage (1329.87s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_monitoring (1219.34s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_multiAZ (2073.19s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer (5251.04s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_nameGenerated (1160.12s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_namePrefix (1143.39s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_parameterGroupName (1258.36s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled (1616.38s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_port (1178.59s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_tags (1021.23s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs (1053.95s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags (1196.72s)
--- PASS: TestAccRDSInstance_subnetGroup (683.45s)
--- SKIP: TestAccRDSInstance_coIPEnabled (0.38s)
--- SKIP: TestAccRDSInstance_CoIPEnabled_disabledToEnabled (2.02s)
--- SKIP: TestAccRDSInstance_CoIPEnabled_enabledToDisabled (1.87s)
--- SKIP: TestAccRDSInstance_CoIPEnabled_restoreToPointInTime (1.91s)
--- SKIP: TestAccRDSInstance_CoIPEnabled_snapshotIdentifier (1.87s)
--- SKIP: TestAccRDSInstance_ec2Classic (0.76s)
--- SKIP: TestAccRDSInstance_ReplicateSourceDB_deletionProtection (0.00s)
--- SKIP: TestAccRDSInstance_SnapshotIdentifier_tagsRemove (0.00s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	10801.637s
% make testacc TESTS=TestAccRDSGlobalCluster_ PKG=rds             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSGlobalCluster_'  -timeout 180m
--- PASS: TestAccRDSGlobalCluster_disappears (17.88s)
--- PASS: TestAccRDSGlobalCluster_basic (22.72s)
--- PASS: TestAccRDSGlobalCluster_Engine_aurora (22.91s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_auroraMySQL (24.57s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL (24.62s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_aurora (24.70s)
--- PASS: TestAccRDSGlobalCluster_databaseName (35.11s)
--- PASS: TestAccRDSGlobalCluster_storageEncrypted (35.30s)
--- PASS: TestAccRDSGlobalCluster_deletionProtection (64.67s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (148.96s)
--- PASS: TestAccRDSGlobalCluster_sourceDBClusterIdentifier (158.77s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMinor (1303.56s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMajor (1338.38s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion (3099.56s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion (3815.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	3817.793s
  • Failures are normal in the nightly and, unfortunately, not fixed by this PR.

@YakDriver YakDriver marked this pull request as draft March 8, 2022 01:19
@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 8, 2022
@bschaatsbergen
Copy link
Member

bschaatsbergen commented Mar 8, 2022 •
edited
Loading

Thanks for fixing these, bumped into this when working on the multi-az rds cluster support :(!

@bschaatsbergen bschaatsbergen mentioned this pull request Mar 8, 2022
Closed
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 11, 2022
@YakDriver YakDriver force-pushed the t-rds-acctest-failures branch from 15f2733 to 7a2dea7 Compare March 11, 2022 01:48
@YakDriver YakDriver marked this pull request as ready for review March 11, 2022 01:50
@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. sweeper Pertains to changes to or issues with the sweeper. labels Mar 11, 2022
ewbankkit
ewbankkit approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some terrafmt and providerlint ❤️, otherwise LGTM 🚀.

@YakDriver YakDriver force-pushed the t-rds-acctest-failures branch from f790b60 to d888392 Compare March 14, 2022 16:27
@YakDriver YakDriver added this to the v4.6.0 milestone Mar 14, 2022
@YakDriver YakDriver merged commit 84ebd6c into main Mar 14, 2022
@YakDriver YakDriver deleted the t-rds-acctest-failures branch March 14, 2022 19:32
github-actions bot pushed a commit that referenced this pull request Mar 14, 2022
Update CHANGELOG.md for #23560
f8a28ca
@ewbankkit ewbankkit mentioned this pull request Mar 15, 2022
Closed
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Apr 19, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.6.0
3 participants
@YakDriver @bschaatsbergen @ewbankkit