Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_pinpointsmsvoicev2_phone_number - new resource #25036

Merged
Merged
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
84c22f8
feat: pinpoint phone number resource
JamesMarino May 25, 2022
9ad391d
feat: pinpoint opt out list resource
JamesMarino May 25, 2022
a139456
fix: code cleanup and added more tests
JamesMarino May 25, 2022
7e4ebfd
docs: added in documentation
JamesMarino May 25, 2022
86e1c31
fix: linting fixes
JamesMarino May 25, 2022
2aac8a6
docs: added resources in changelog
JamesMarino May 25, 2022
2651161
Merge branch 'main' into HEAD
ewbankkit Sep 13, 2024
db2e552
pinpointsmsvoicev2: Use AWS SDK for Go v2.
ewbankkit Sep 13, 2024
48c5812
Run 'make gen'.
ewbankkit Sep 13, 2024
6b7e1ee
Run 'go get github.com/aws/aws-sdk-go-v2/service/pinpointsmsvoicev2@v…
ewbankkit Sep 13, 2024
5f2ec74
r/aws_pinpointsmsvoicev2_opt_out_list: Migrate to AWS SDK for Go v2.
ewbankkit Sep 13, 2024
0dffd68
Add 'TestAccPinpointSMSVoiceV2OptOutList_tags'.
ewbankkit Sep 13, 2024
638140b
r/aws_pinpointsmsvoicev2_phone_number: Migrate to AWS SDK for Go v2.
ewbankkit Sep 13, 2024
c1e35d9
Add 'TestAccPinpointSMSVoiceV2PhoneNumber_tags'.
ewbankkit Sep 13, 2024
86b1a51
Run 'make fix-constants PKG=pinpointsmsvoicev2'.
ewbankkit Sep 13, 2024
9d113c9
Fix semgrep 'ci.semgrep.pluginsdk.return-diags-not-nil'.
ewbankkit Sep 13, 2024
ed9f12b
Fix semgrep 'ci.semgrep.pluginsdk.avoid-diag_Errorf'.
ewbankkit Sep 13, 2024
342398a
Add 'sdkv2.HasNonZeroValues'.
ewbankkit Sep 13, 2024
ccd0b0f
r/aws_pinpointsmsvoicev2_phone_number: Avoid update-after-create.
ewbankkit Sep 13, 2024
652dd7f
r/aws_pinpointsmsvoicev2_phone_number: 'number_capabilities' is a set.
ewbankkit Sep 13, 2024
61e9ff1
r/aws_pinpointsmsvoicev2_phone_number: Use ConfigStateChecks in accep…
ewbankkit Sep 13, 2024
d3978ea
Fix golangci-lint 'unparam'.
ewbankkit Sep 13, 2024
144b79f
Acceptance test output:
ewbankkit Sep 13, 2024
f15f207
r/aws_pinpointsmsvoicev2_phone_number: Add sweeper.
ewbankkit Sep 16, 2024
170f8db
Run 'make gen'.
ewbankkit Sep 16, 2024
1c190fb
pinpoint: Generate paginator.
ewbankkit Sep 16, 2024
761aaae
r/aws_pinpoint_app: Tidy up sweeper.
ewbankkit Sep 16, 2024
fa755bb
r/aws_pinpointsmsvoicev2_phone_number: Use SIMULATOR phone numbers in…
ewbankkit Sep 16, 2024
e402c22
Acceptance test output:
ewbankkit Sep 16, 2024
ced48c9
pinpointsmsvoicev2: Human-friendly name is 'End User Messaging SMS'.
ewbankkit Sep 16, 2024
029a5e5
pinpointsmsvoicev2: 'End User Messaging' -> 'End User Messaging SMS' …
ewbankkit Sep 16, 2024
9048865
pinpointsmsvoicev2: 'End User Messaging' -> 'End User Messaging SMS' …
ewbankkit Sep 16, 2024
a57db51
README not used.
ewbankkit Sep 16, 2024
48b92f6
Merge branch 'main' into HEAD
ewbankkit Sep 16, 2024
f91ed53
pinpointsmsvoicev2: Remove 'sdk.client_version'.
ewbankkit Sep 16, 2024
b5b33f5
r/aws_pinpointsmsvoicev2_opt_out_list: Migrate to Terraform Plugin Fr…
ewbankkit Sep 16, 2024
a3c56d1
r/aws_pinpointsmsvoicev2_phone_number: Migrate to Terraform Plugin Fr…
ewbankkit Sep 16, 2024
62ca78f
Fix golangci-lint 'nolintlint'.
ewbankkit Sep 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/25036.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:new-resource
aws_pinpointsmsvoicev2_phone_number
```

```release-note:new-resource
aws_pinpointsmsvoicev2_opt_out_list
```
15 changes: 15 additions & 0 deletions .ci/.semgrep-service-name0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4254,3 +4254,18 @@ rules:
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: connect-in-test-name
languages:
- go
message: Include "Connect" in test name
paths:
include:
- internal/service/connect/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccConnect"
- pattern-regex: ^TestAcc.*
severity: WARNING
47 changes: 32 additions & 15 deletions .ci/.semgrep-service-name1.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: connect-in-test-name
languages:
- go
message: Include "Connect" in test name
paths:
include:
- internal/service/connect/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccConnect"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: connect-in-const-name
languages:
- go
Expand Down Expand Up @@ -4244,3 +4229,35 @@ rules:
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: iot-in-var-name
languages:
- go
message: Do not use "IoT" in var name inside iot package
paths:
include:
- internal/service/iot
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: iotanalytics-in-func-name
languages:
- go
message: Do not use "IoTAnalytics" in func name inside iotanalytics package
paths:
include:
- internal/service/iotanalytics
exclude:
- internal/service/iotanalytics/list_pages_gen.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoTAnalytics"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
107 changes: 61 additions & 46 deletions .ci/.semgrep-service-name2.yml
Original file line number Diff line number Diff line change
@@ -1,37 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: iot-in-var-name
languages:
- go
message: Do not use "IoT" in var name inside iot package
paths:
include:
- internal/service/iot
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: iotanalytics-in-func-name
languages:
- go
message: Do not use "IoTAnalytics" in func name inside iotanalytics package
paths:
include:
- internal/service/iotanalytics
exclude:
- internal/service/iotanalytics/list_pages_gen.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoTAnalytics"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: iotanalytics-in-test-name
languages:
- go
Expand Down Expand Up @@ -3554,6 +3522,67 @@ rules:
patterns:
- pattern-regex: "(?i)Pinpoint"
severity: WARNING
- id: pinpointsmsvoicev2-in-func-name
languages:
- go
message: Do not use "PinpointSMSVoiceV2" in func name inside pinpointsmsvoicev2 package
paths:
include:
- internal/service/pinpointsmsvoicev2
exclude:
- internal/service/pinpointsmsvoicev2/list_pages_gen.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)PinpointSMSVoiceV2"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: pinpointsmsvoicev2-in-test-name
languages:
- go
message: Include "PinpointSMSVoiceV2" in test name
paths:
include:
- internal/service/pinpointsmsvoicev2/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccPinpointSMSVoiceV2"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: pinpointsmsvoicev2-in-const-name
languages:
- go
message: Do not use "PinpointSMSVoiceV2" in const name inside pinpointsmsvoicev2 package
paths:
include:
- internal/service/pinpointsmsvoicev2
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)PinpointSMSVoiceV2"
severity: WARNING
- id: pinpointsmsvoicev2-in-var-name
languages:
- go
message: Do not use "PinpointSMSVoiceV2" in var name inside pinpointsmsvoicev2 package
paths:
include:
- internal/service/pinpointsmsvoicev2
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)PinpointSMSVoiceV2"
severity: WARNING
- id: pipes-in-func-name
languages:
- go
Expand Down Expand Up @@ -4233,17 +4262,3 @@ rules:
patterns:
- pattern-regex: "(?i)recyclebin"
severity: WARNING
- id: recyclebin-in-var-name
languages:
- go
message: Do not use "recyclebin" in var name inside rbin package
paths:
include:
- internal/service/rbin
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
severity: WARNING
14 changes: 14 additions & 0 deletions .ci/.semgrep-service-name3.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: recyclebin-in-var-name
languages:
- go
message: Do not use "recyclebin" in var name inside rbin package
paths:
include:
- internal/service/rbin
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
severity: WARNING
- id: redshift-in-func-name
languages:
- go
Expand Down
2 changes: 2 additions & 0 deletions .github/labeler-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,8 @@ service/pinpointemail:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_pinpointemail_'
service/pinpointsmsvoice:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_pinpointsmsvoice_'
service/pinpointsmsvoicev2:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_pinpointsmsvoicev2_'
service/pipes:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_pipes_'
service/polly:
Expand Down
6 changes: 6 additions & 0 deletions .github/labeler-pr-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1665,6 +1665,12 @@ service/pinpointsmsvoice:
- any-glob-to-any-file:
- 'internal/service/pinpointsmsvoice/**/*'
- 'website/**/pinpointsmsvoice_*'
service/pinpointsmsvoicev2:
- any:
- changed-files:
- any-glob-to-any-file:
- 'internal/service/pinpointsmsvoicev2/**/*'
- 'website/**/pinpointsmsvoicev2_*'
service/pipes:
- any:
- changed-files:
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services_all.kt
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ val services = mapOf(
"pcaconnectorad" to ServiceSpec("Private CA Connector for Active Directory"),
"pcs" to ServiceSpec("Parallel Computing Service"),
"pinpoint" to ServiceSpec("Pinpoint"),
"pinpointsmsvoicev2" to ServiceSpec("End User Messaging SMS"),
"pipes" to ServiceSpec("EventBridge Pipes"),
"polly" to ServiceSpec("Polly"),
"pricing" to ServiceSpec("Pricing Calculator", regionOverride = "us-east-1"),
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/pcaconnectorad v1.7.6
github.com/aws/aws-sdk-go-v2/service/pcs v1.0.2
github.com/aws/aws-sdk-go-v2/service/pinpoint v1.32.6
github.com/aws/aws-sdk-go-v2/service/pinpointsmsvoicev2 v1.12.8
github.com/aws/aws-sdk-go-v2/service/pipes v1.15.0
github.com/aws/aws-sdk-go-v2/service/polly v1.43.2
github.com/aws/aws-sdk-go-v2/service/pricing v1.30.6
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,8 @@ github.com/aws/aws-sdk-go-v2/service/pcs v1.0.2 h1:+PSbd/wTgCueA9agqNNeSmVoOgcgA
github.com/aws/aws-sdk-go-v2/service/pcs v1.0.2/go.mod h1:acm3akB4exauzjZeKNonTwkxCPIdWT1LWLRM09eZP7c=
github.com/aws/aws-sdk-go-v2/service/pinpoint v1.32.6 h1:S5SxTH9Ue7cwK9O76RQKkt9xY+zapTJv6dutXEyKOGQ=
github.com/aws/aws-sdk-go-v2/service/pinpoint v1.32.6/go.mod h1:2yK6vZtj8t8tmEOk2/XBk/7oC9QggiRIDhwt1rUNkPE=
github.com/aws/aws-sdk-go-v2/service/pinpointsmsvoicev2 v1.12.8 h1:3GiUwkpy6GXMqVdfIfbWkBR86dOsd38obv4sBwyRxZ8=
github.com/aws/aws-sdk-go-v2/service/pinpointsmsvoicev2 v1.12.8/go.mod h1:Ek88Y1SlTvTDgX9L7DWUPfQIYtT++3eqK7cMK0TdW8Q=
github.com/aws/aws-sdk-go-v2/service/pipes v1.15.0 h1:2P3Y9TFqZP2V8rJquXMEcXQ3D2Ybdvj+qD9wG9m0Sio=
github.com/aws/aws-sdk-go-v2/service/pipes v1.15.0/go.mod h1:JKl45FQijnuqkji3jAlVTH0tRTbYYZSUb00P9HClkRg=
github.com/aws/aws-sdk-go-v2/service/polly v1.43.2 h1:AmoLJRNIJQvN4CcXPhLwXPaDOnke2EXAWe9T+MNloEE=
Expand Down
1 change: 1 addition & 0 deletions infrastructure/repository/labels-service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ variable "service_labels" {
"pinpoint",
"pinpointemail",
"pinpointsmsvoice",
"pinpointsmsvoicev2",
"pipes",
"polly",
"pricing",
Expand Down
5 changes: 5 additions & 0 deletions internal/conns/awsclient_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/provider/service_packages_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions internal/sdkv2/resource_differ.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,13 @@ type ResourceDiffer interface {
HasChanges(...string) bool
Id() string
}

// HasNonZeroValues returns true if any of the keys have non-zero values.
func HasNonZeroValues(d ResourceDiffer, keys ...string) bool {
for _, key := range keys {
if _, ok := d.GetOk(key); ok {
return true
}
}
return false
}
1 change: 1 addition & 0 deletions internal/service/pinpoint/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-License-Identifier: MPL-2.0

//go:generate go run ../../generate/tags/main.go -ListTags -ListTagsOutTagsElem=TagsModel.Tags -ServiceTagsMap "-TagInCustomVal=&awstypes.TagsModel{Tags: Tags(updatedTags.IgnoreAWS())}" -TagInTagsElem=TagsModel -UpdateTags -KVTValues
//go:generate go run ../../generate/listpages/main.go -ListOps=GetApps -OutputPaginator=ApplicationsResponse.NextToken -InputPaginator=Token
//go:generate go run ../../generate/servicepackage/main.go
// ONLY generate directives and package declaration! Do not add anything else to this file.

Expand Down
27 changes: 27 additions & 0 deletions internal/service/pinpoint/list_pages_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading