-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Eventbridge API Destination Invocation Rate Limit to be greater than 300 #25277
Allow Eventbridge API Destination Invocation Rate Limit to be greater than 300 #25277
Conversation
@justinretzolk would it be possible to rebuild the providerlint action step? Unsure why it failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEventsAPIDestination_' PKG=events ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 2 -run=TestAccEventsAPIDestination_ -timeout 180m
=== RUN TestAccEventsAPIDestination_basic
=== PAUSE TestAccEventsAPIDestination_basic
=== RUN TestAccEventsAPIDestination_optional
=== PAUSE TestAccEventsAPIDestination_optional
=== RUN TestAccEventsAPIDestination_disappears
=== PAUSE TestAccEventsAPIDestination_disappears
=== CONT TestAccEventsAPIDestination_basic
=== CONT TestAccEventsAPIDestination_disappears
--- PASS: TestAccEventsAPIDestination_disappears (16.50s)
=== CONT TestAccEventsAPIDestination_optional
--- PASS: TestAccEventsAPIDestination_basic (45.83s)
--- PASS: TestAccEventsAPIDestination_optional (44.54s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 64.736s
@jordanfinners Thanks for the contribution 🎉 👏. |
@jordanfinners Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25276