Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit - For AWS Internal Review #25289

Conversation

meetreks
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #25276

Output from acceptance testing:

Negative Test - with rate as 312 and Positive Test with rate as 12
$ make testacc PKG=events TESTS=TestAccEventsAPIDestination_optional


...
<img width="699" alt="Negative FAIL" src="https://user-images.githubusercontent.com/12427542/173249569-7f7ab931-9d7d-4e36-929d-6589ea52d300.PNG">
<img width="702" alt="Postive - PASS" src="https://user-images.githubusercontent.com/12427542/173249578-c5f3d04d-de0c-4ea6-98ed-43e498586b80.PNG">

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/events Issues and PRs that pertain to the events service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 12, 2022
@ewbankkit ewbankkit changed the title Initial Commit - For AWS Internal Review Eventbridge: Support Invocation Rate > 300 Jun 17, 2022
@ewbankkit ewbankkit changed the title Eventbridge: Support Invocation Rate > 300 Initial Commit - For AWS Internal Review Jun 17, 2022
@GlennChia GlennChia self-requested a review June 27, 2022 14:09
@ewbankkit
Copy link
Contributor

Superseded by #25277.

@ewbankkit ewbankkit closed this Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partner Contribution from a partner. service/events Issues and PRs that pertain to the events service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants