Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagemaker example of "deploy your own model" #2585

Closed

Conversation

jckuester
Copy link
Contributor

@jckuester jckuester commented Dec 7, 2017

Please review only the last commit of this PR, which contains the example itself (the other commits are from rebasing the referenced PRs below, which contain the new SageMaker resources).

This example shows how to use the three new SageMaker resources

to deploy your own model algorithm container.

This PR can only be merged once the referenced PRs above are merged, as this example depends on the three new resources.

@jckuester jckuester mentioned this pull request Dec 7, 2017
@jckuester jckuester force-pushed the feature/sagemaker-example branch 2 times, most recently from f7bd20a to e7740dc Compare December 8, 2017 21:03
@radeksimko radeksimko added the new-resource Introduces a new resource. label Dec 12, 2017
@radeksimko
Copy link
Member

Hi @jckuester
I appreciate this is still WIP - just so you know we always prefer 1 resource per PR to keep diff small and easier to review. 😉

Just let us know when it's ready for review and we can take a look.

@jckuester
Copy link
Contributor Author

jckuester commented Dec 12, 2017

Hi @radeksimko
Thanks. I know - I hope I've read all of the developer guidelines :-) This PR is the last of 4 PRs that all depend on each other. The first three contain the new sagemaker resources and this last one an example (I rebased the branch of this PR on top of the other ones, so I can get the example working).

Actually, the first PR of the series is now ready to review (#2478). I am looking fwd to your feedback :)

@jckuester jckuester force-pushed the feature/sagemaker-example branch 2 times, most recently from ea72220 to 8b76f49 Compare December 18, 2017 11:51
@jckuester jckuester force-pushed the feature/sagemaker-example branch from 8b76f49 to 54a72ed Compare January 7, 2018 19:07
@jckuester jckuester changed the title [WIP] Sagemaker example of "deploy your own model" Sagemaker example of "deploy your own model" Jan 7, 2018
@radeksimko radeksimko added service/sagemaker Issues and PRs that pertain to the sagemaker service. documentation Introduces or discusses updates to documentation. and removed new-resource Introduces a new resource. labels Jan 16, 2018
@jckuester jckuester force-pushed the feature/sagemaker-example branch 2 times, most recently from d5838ed to d107e25 Compare January 21, 2018 00:31
@jckuester jckuester force-pushed the feature/sagemaker-example branch from d107e25 to 0a99c09 Compare April 26, 2018 19:22
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. labels Apr 26, 2018
@jckuester jckuester force-pushed the feature/sagemaker-example branch from 0a99c09 to 52fdc6e Compare July 21, 2018 18:13
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jul 21, 2018
@aeschright aeschright requested a review from a team June 25, 2019 18:51
@aeschright aeschright added the new-resource Introduces a new resource. label Aug 19, 2019
@bflad
Copy link
Contributor

bflad commented Aug 20, 2019

Hey @jckuester 👋 Thanks for submitting this -- since we merged a bunch of the required resources here with changes, this PR is showing conflicts with pretty much every previous file and requires a rebase. If you are interested in submitting this, please re-submit it with only the last commit against master so it can get reviewed. Thanks again.

@bflad bflad closed this Aug 20, 2019
@jckuester
Copy link
Contributor Author

Ok, @bflad. Resubmitted and tested that the example is still working: #9948

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants