Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagemaker example of "deploy your own model" #9948

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

jckuester
Copy link
Contributor

This example shows how to use the three new SageMaker resources

to deploy your own model algorithm container.

@jckuester jckuester requested a review from a team September 2, 2019 08:50
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Sep 2, 2019
@bflad
Copy link
Contributor

bflad commented Jun 29, 2020

Hi @jckuester 👋 Apologies for the minor hassle, could you rebase this pull request against master and push to this pull request branch? This should trigger our automatic examples/ testing and we can get it in when that's passing. Thanks for writing this up!

@bflad bflad self-assigned this Jun 29, 2020
@bflad bflad added examples Introduces or discusses updates to examples. waiting-response Maintainers are waiting on response from community or contributor. labels Jun 29, 2020
@jckuester
Copy link
Contributor Author

jckuester commented Jun 29, 2020

Hi @bflad, rebase is done. Tests for Terraform 12 seem to fail, do you want me to change the example code to be Terraform 12 conform?

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 29, 2020
@bflad
Copy link
Contributor

bflad commented Jun 30, 2020

@jckuester let's go ahead and get it 0.12 compliant and feel free to exclude it in the GitHub Action workflow file (https://github.com/terraform-providers/terraform-provider-aws/blob/a1a03e9da9136eca583c5e97abf27ec9ba9335ff/.github/workflows/examples.yml#L47-L49) for 0.11 if necessary since we'll be converting these in the next week or so anyways. Thanks!

@ghost ghost added provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 5, 2020
@jckuester
Copy link
Contributor Author

jckuester commented Jul 6, 2020

@bflad I addressed your feedback.

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added this to the v2.70.0 milestone Jul 6, 2020
@bflad bflad merged commit ac7b019 into hashicorp:master Jul 6, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.70.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Introduces or discusses updates to examples. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants