-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sagemaker example of "deploy your own model" #9948
Conversation
Hi @jckuester 👋 Apologies for the minor hassle, could you rebase this pull request against master and push to this pull request branch? This should trigger our automatic |
961fe2e
to
96acec7
Compare
Hi @bflad, rebase is done. Tests for Terraform 12 seem to fail, do you want me to change the example code to be Terraform 12 conform? |
@jckuester let's go ahead and get it 0.12 compliant and feel free to exclude it in the GitHub Action workflow file (https://github.com/terraform-providers/terraform-provider-aws/blob/a1a03e9da9136eca583c5e97abf27ec9ba9335ff/.github/workflows/examples.yml#L47-L49) for 0.11 if necessary since we'll be converting these in the next week or so anyways. Thanks! |
96acec7
to
c7c6f18
Compare
@bflad I addressed your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This has been released in version 2.70.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This example shows how to use the three new SageMaker resources
resource_aws_sagemaker_model
(New Resource: aws_sagemaker_model #2478),resource_aws_sagemaker_endpoint_configuration
(New Resource: aws_sagemaker_endpoint_configuration #2477), andresource_aws_sagemaker_endpoint
(New Resource: aws_sagemaker_endpoint #2479)to deploy your own model algorithm container.