Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch/domain: Allow fine-grained access control to be enabled #26503

Merged
merged 12 commits into from
Aug 29, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 26, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22955

Output from acceptance testing:

% make testacc TESTS=TestAccOpenSearchDomain_AdvancedSecurityOptions PKG=opensearch 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_AdvancedSecurityOptions'  -timeout 180m
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_iam (1671.35s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled (1740.94s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB (1732.27s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth (4110.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	4112.037s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/opensearch Issues and PRs that pertain to the opensearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 26, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 26, 2022
@github-actions github-actions bot added service/elasticsearch Issues and PRs that pertain to the elasticsearch service. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. labels Aug 29, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchDomain_AdvancedSecurityOptions_\|TestAccOpenSearchDomain_basic' PKG=opensearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 2  -run=TestAccOpenSearchDomain_AdvancedSecurityOptions_\|TestAccOpenSearchDomain_basic -timeout 180m
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_iam
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_iam
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled
=== CONT  TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_iam (1666.89s)
=== CONT  TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth
--- PASS: TestAccOpenSearchDomain_basic (1694.26s)
=== CONT  TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled (1719.33s)
=== CONT  TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB (1822.06s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth (5742.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	5754.942s

@YakDriver YakDriver merged commit aedfd9a into main Aug 29, 2022
@YakDriver YakDriver deleted the f-opensearch-fgac branch August 29, 2022 15:54
@github-actions github-actions bot added this to the v4.29.0 milestone Aug 29, 2022
github-actions bot pushed a commit that referenced this pull request Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/opensearch Issues and PRs that pertain to the opensearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable fine-grained access control in Opensearch 1.1 for existing clusters
2 participants