Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STS: Migrate all data services to Terraform Plugin Framework #27276

Merged
merged 9 commits into from
Oct 17, 2022
Merged

STS: Migrate all data services to Terraform Plugin Framework #27276

merged 9 commits into from
Oct 17, 2022

Conversation

ewbankkit
Copy link
Contributor

Description

Migrates the aws_caller_identity sts data source to Terraform Plugin Framework.

Relations

Relates #27221.
Relates #26027.
Relates #26101.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (11.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	15.894s

@ewbankkit
d/aws_caller_identity: Switch to 'WithoutTimeout' CRUD handlers (#15090…
c5bb83b 
…).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (16.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	22.887s
@ewbankkit
tools/tfsdk2fw: Emit structure for top-level attributes.
13d6cc4
@ewbankkit
STS: Generate service data.
3c1988b
@ewbankkit
d/aws_caller_identity: Implement using terraform-plugin-framework.
d742ff0 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (12.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	16.172s
@ewbankkit
d/aws_caller_identity: Remove terraform-plugin-sdk implementation.
d55b9c5
@ewbankkit
tools/tfsdk2fw: Special case code generation for ARNs.
2eb6ffa
@ewbankkit
d/aws_caller_identity: Use 'fwtypes.ARNType'.
a39ad20 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (11.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	15.894s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/medialive Issues and PRs that pertain to the medialive service. service/meta service/sts Issues and PRs that pertain to the sts service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Oct 17, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. documentation Introduces or discusses updates to documentation. service/medialive Issues and PRs that pertain to the medialive service. flex Pertains to FLatteners and EXpanders. service/meta labels Oct 17, 2022
@ewbankkit ewbankkit merged commit bb3ba43 into main Oct 17, 2022
@ewbankkit ewbankkit deleted the td-migrate-sts-data-sources-to-framework branch October 17, 2022 20:51
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 17, 2022
This was referenced Oct 17, 2022
Merged
Merged
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/sts Issues and PRs that pertain to the sts service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.36.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit