Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleDB: Migrate aws_simpledb_domain to Terraform Plugin Framework #27304

Merged
merged 35 commits into from
Oct 20, 2022
Merged

SimpleDB: Migrate aws_simpledb_domain to Terraform Plugin Framework #27304

merged 35 commits into from
Oct 20, 2022

Conversation

ewbankkit
Copy link
Contributor

Description

Migrates the aws_simpledb_domain resource to Terraform Plugin Framework.
This is the first migrated resource.

Relations

Relates #27282.
Relates #27276.
Relates #27221.
Relates #26027.
Relates #26101.

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@ewbankkit
r/aws_simpledb_domain: Switch to 'WithoutTimeout' CRUD handlers (#15090…
8d7eac2 
…).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_basic
--- PASS: TestAccSimpleDBDomain_basic (22.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	29.460s
@ewbankkit
r/aws_simpledb_domain: Add 'TestAccSimpleDBDomain_disappears'.
a5f3912 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_disappears' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_disappears -timeout 180m
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (17.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	21.229s
@ewbankkit
SimpleDB: Add sweeper.
57e7241
@ewbankkit
Add ServiceData.FrameworkResources.
583fdd3
@ewbankkit
SimpleDB: Generate service data.
d4fdef3
@ewbankkit
tools/tfsdk2fw: Template for resources.
5366a36
@ewbankkit
r/aws_simpledb_domain: Implement using terraform-plugin-framework.
2a20ad9 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (14.60s)
=== CONT  TestAccSimpleDBDomain_basic
    domain_test.go:22: Step 2/2 error running import: exit status 1

        Error: Resource Import Not Implemented

        This resource does not support import. Please contact the provider developer
        for additional information.

--- FAIL: TestAccSimpleDBDomain_basic (18.16s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	22.260s
FAIL
make: *** [testacc] Error 1
@ewbankkit
r/aws_simpledb_domain: Remove terraform-plugin-sdk implementation.
3df8110
@ewbankkit
r/aws_simpledb_domain: Add 'resource.RequiresReplace' PlanModifier to…
d02932e 
… 'name'.
@ewbankkit
tools/tfsdk2fw: Emit ForceNew-equivalent PlanModifier.
330134e
@ewbankkit
tools/tfsdk2fw: Emit Resource.ImportState if necessary.
ebf473f
@ewbankkit
tools/tfsdk2fw: Only emit Resource.Update skeleton if necessary.
20674aa
@ewbankkit
r/aws_simpledb_domain: Correct ImportState.
96ef614 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (14.73s)
--- PASS: TestAccSimpleDBDomain_basic (19.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	23.698s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/meta service/simpledb Issues and PRs that pertain to the simpledb service. service/sts Issues and PRs that pertain to the sts service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/simpledb Issues and PRs that pertain to the simpledb service. provider Pertains to the provider itself, rather than any interaction with AWS. service/sts Issues and PRs that pertain to the sts service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. service/meta labels Oct 18, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 18, 2022
@ewbankkit
experimental/depgraph: A simple dependency graph.
267f3b0
@ewbankkit
Add README.
dbafb64
@ewbankkit
experimental/depgraph: Use 'go-cmp' in acceptance tests.
54efb54
@ewbankkit
d/aws_billing_service_account: Computed-only ARNs are of types.String.
8d78fd1 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccMetaBillingServiceAccountDataSource_' PKG=meta
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20  -run=TestAccMetaBillingServiceAccountDataSource_ -timeout 180m
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (16.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	26.155s
@ewbankkit
tools/tfsdk2fw: Computed-only ARN attributes are easiest handled as s…
5ac85e0 
…trings.
@ewbankkit
r/aws_simpledb_domain: Log resource deletion.
fd1ca92
@ewbankkit
Terraform Plugin Framework variants of sweeper helpers.
b489588
@ewbankkit
r/aws_simpledb_domain: Use 'sweep.NewSweepFrameworkResource'.
7ca9933
@ewbankkit
r/aws_simpledb_domain: Remove SDK-implementation stub used for tests …
a78e1cb 
…and sweeper.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (14.76s)
--- PASS: TestAccSimpleDBDomain_basic (19.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	23.870s
@ewbankkit
tools/tfsdk2fw: Log resource deletion.
fc79f0d
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Oct 19, 2022
@ewbankkit
Copy link
Contributor Author

Sweeper helper additions - see #27311.

@github-actions github-actions bot added the client-connections Pertains to the AWS Client and service connections. label Oct 19, 2022
@ewbankkit
r/aws_simpledb_domain: Verify migration (https://developer.hashicorp.…
18cd478 
…com/terraform/plugin/framework/migrating/testing#testing-migration).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_MigrateFromPluginSDK' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_MigrateFromPluginSDK -timeout 180m
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (85.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	92.554s
@ewbankkit
d/aws_globalaccelerator_accelerator: Verify migration (https://develo…
a61bf70 
…per.hashicorp.com/terraform/plugin/framework/migrating/testing#testing-migration).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccGlobalAcceleratorAcceleratorDataSource_MigrateFromPluginSDK' PKG=globalaccelerator
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20  -run=TestAccGlobalAcceleratorAcceleratorDataSource_MigrateFromPluginSDK -timeout 180m
=== RUN   TestAccGlobalAcceleratorAcceleratorDataSource_MigrateFromPluginSDK
=== PAUSE TestAccGlobalAcceleratorAcceleratorDataSource_MigrateFromPluginSDK
=== CONT  TestAccGlobalAcceleratorAcceleratorDataSource_MigrateFromPluginSDK
--- PASS: TestAccGlobalAcceleratorAcceleratorDataSource_MigrateFromPluginSDK (163.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	167.573s
@ewbankkit ewbankkit merged commit b5a2bd7 into main Oct 20, 2022
@ewbankkit ewbankkit deleted the td-migrate-simpledb-resources-to-framework branch October 20, 2022 21:40
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 20, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/simpledb Issues and PRs that pertain to the simpledb service. service/sts Issues and PRs that pertain to the sts service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.36.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit