Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds/cluster/cluster_instance: engine becomes required #31112

Merged
merged 5 commits into from
May 3, 2023
Merged

rds/cluster/cluster_instance: engine becomes required #31112

merged 5 commits into from
May 3, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 2, 2023 •
edited
Loading

Description

Relations

Closes #27960

References

Output from Acceptance Testing

(Failures unrelated to these changes.)

% make t T=TestAccRDSClusterInstance_ K=rds P=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3 -run='TestAccRDSClusterInstance_'  -timeout 180m
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== RUN   TestAccRDSClusterInstance_disappears
=== PAUSE TestAccRDSClusterInstance_disappears
=== RUN   TestAccRDSClusterInstance_tags
=== PAUSE TestAccRDSClusterInstance_tags
=== RUN   TestAccRDSClusterInstance_isAlreadyBeingDeleted
=== PAUSE TestAccRDSClusterInstance_isAlreadyBeingDeleted
=== RUN   TestAccRDSClusterInstance_az
=== PAUSE TestAccRDSClusterInstance_az
=== RUN   TestAccRDSClusterInstance_identifierPrefix
=== PAUSE TestAccRDSClusterInstance_identifierPrefix
=== RUN   TestAccRDSClusterInstance_identifierGenerated
=== PAUSE TestAccRDSClusterInstance_identifierGenerated
=== RUN   TestAccRDSClusterInstance_kmsKey
=== PAUSE TestAccRDSClusterInstance_kmsKey
=== RUN   TestAccRDSClusterInstance_publiclyAccessible
=== PAUSE TestAccRDSClusterInstance_publiclyAccessible
=== RUN   TestAccRDSClusterInstance_copyTagsToSnapshot
=== PAUSE TestAccRDSClusterInstance_copyTagsToSnapshot
=== RUN   TestAccRDSClusterInstance_caCertificateIdentifier
=== PAUSE TestAccRDSClusterInstance_caCertificateIdentifier
=== RUN   TestAccRDSClusterInstance_monitoringInterval
=== PAUSE TestAccRDSClusterInstance_monitoringInterval
=== RUN   TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled
=== PAUSE TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled
=== RUN   TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved
=== PAUSE TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved
=== RUN   TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled
=== PAUSE TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey
=== RUN   TestAccRDSClusterInstance_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSClusterInstance_performanceInsightsRetentionPeriod
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql
=== RUN   TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey
=== PAUSE TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey
=== CONT  TestAccRDSClusterInstance_basic
=== CONT  TestAccRDSClusterInstance_monitoringInterval
=== CONT  TestAccRDSClusterInstance_identifierGenerated
--- PASS: TestAccRDSClusterInstance_identifierGenerated (879.18s)
=== CONT  TestAccRDSClusterInstance_copyTagsToSnapshot
--- PASS: TestAccRDSClusterInstance_basic (1174.64s)
=== CONT  TestAccRDSClusterInstance_caCertificateIdentifier
    cluster_instance_test.go:450: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: multiple RDS Certificates match the criteria; try changing search query
        
          with data.aws_rds_certificate.latest,
          on terraform_plugin_test.tf line 36, in data "aws_rds_certificate" "latest":
          36: data "aws_rds_certificate" "latest" {
        
--- FAIL: TestAccRDSClusterInstance_caCertificateIdentifier (2.83s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1
--- PASS: TestAccRDSClusterInstance_copyTagsToSnapshot (774.79s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey
--- PASS: TestAccRDSClusterInstance_monitoringInterval (1857.65s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraMySQL1 (951.86s)
=== CONT  TestAccRDSClusterInstance_performanceInsightsRetentionPeriod
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraPostgresql_defaultKeyToCustomKey (948.95s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyID_auroraPostgresql (819.14s)
=== CONT  TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled
--- PASS: TestAccRDSClusterInstance_performanceInsightsRetentionPeriod (1455.95s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsKMSKeyIDAuroraMySQL1_defaultKeyToCustomKey (1246.33s)
=== CONT  TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_removedToEnabled (1538.19s)
=== CONT  TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraPostgresql (890.07s)
=== CONT  TestAccRDSClusterInstance_publiclyAccessible
--- PASS: TestAccRDSClusterInstance_PerformanceInsightsEnabled_auroraMySQL1 (1228.32s)
=== CONT  TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_enabledToRemoved (1408.14s)
=== CONT  TestAccRDSClusterInstance_kmsKey
--- PASS: TestAccRDSClusterInstance_publiclyAccessible (1319.76s)
=== CONT  TestAccRDSClusterInstance_isAlreadyBeingDeleted
--- PASS: TestAccRDSClusterInstance_MonitoringRoleARN_enabledToDisabled (1427.26s)
=== CONT  TestAccRDSClusterInstance_identifierPrefix
--- PASS: TestAccRDSClusterInstance_kmsKey (1469.01s)
=== CONT  TestAccRDSClusterInstance_az
--- PASS: TestAccRDSClusterInstance_isAlreadyBeingDeleted (1408.57s)
=== CONT  TestAccRDSClusterInstance_tags
--- PASS: TestAccRDSClusterInstance_identifierPrefix (815.22s)
=== CONT  TestAccRDSClusterInstance_disappears
--- PASS: TestAccRDSClusterInstance_az (1248.64s)
--- PASS: TestAccRDSClusterInstance_tags (1233.37s)
--- PASS: TestAccRDSClusterInstance_disappears (1446.11s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	8768.155s
% make t T=TestAccRDSCluster_ K=rds P=3 ACCTEST_TIMEOUT=720m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3 -run='TestAccRDSCluster_'  -timeout 720m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_identifierGenerated
=== PAUSE TestAccRDSCluster_identifierGenerated
=== RUN   TestAccRDSCluster_identifierPrefix
=== PAUSE TestAccRDSCluster_identifierPrefix
=== RUN   TestAccRDSCluster_allowMajorVersionUpgrade
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgrade
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccRDSCluster_onlyMajorVersion
=== PAUSE TestAccRDSCluster_onlyMajorVersion
=== RUN   TestAccRDSCluster_minorVersion
=== PAUSE TestAccRDSCluster_minorVersion
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_storageType
=== PAUSE TestAccRDSCluster_storageType
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_backtrackWindow
=== PAUSE TestAccRDSCluster_backtrackWindow
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== RUN   TestAccRDSCluster_missingUserNameCausesError
=== PAUSE TestAccRDSCluster_missingUserNameCausesError
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_kmsKey
=== PAUSE TestAccRDSCluster_kmsKey
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== RUN   TestAccRDSCluster_encrypted
=== PAUSE TestAccRDSCluster_encrypted
=== RUN   TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_backupsUpdate
=== PAUSE TestAccRDSCluster_backupsUpdate
=== RUN   TestAccRDSCluster_iamAuth
=== PAUSE TestAccRDSCluster_iamAuth
=== RUN   TestAccRDSCluster_deletionProtection
=== PAUSE TestAccRDSCluster_deletionProtection
=== RUN   TestAccRDSCluster_engineMode
=== PAUSE TestAccRDSCluster_engineMode
=== RUN   TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN   TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managed
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSCluster_port
=== PAUSE TestAccRDSCluster_port
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== RUN   TestAccRDSCluster_serverlessV2ScalingConfiguration
=== PAUSE TestAccRDSCluster_serverlessV2ScalingConfiguration
=== RUN   TestAccRDSCluster_Scaling_defaultMinCapacity
=== PAUSE TestAccRDSCluster_Scaling_defaultMinCapacity
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== RUN   TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless
    cluster_test.go:1915: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== RUN   TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== RUN   TestAccRDSCluster_password
=== PAUSE TestAccRDSCluster_password
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_engineVersion
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_basic (161.63s)
=== CONT  TestAccRDSCluster_password
--- PASS: TestAccRDSCluster_password (179.25s)
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
--- PASS: TestAccRDSCluster_engineVersion (462.86s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_snapshotIdentifier (481.49s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (372.38s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (423.14s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (470.22s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (434.24s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (469.48s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (522.04s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (489.59s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (460.26s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (440.47s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (408.99s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (463.01s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (482.54s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (470.58s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_dbSubnetGroupName (157.10s)
=== CONT  TestAccRDSCluster_deletionProtection
--- PASS: TestAccRDSCluster_deletionProtection (189.11s)
=== CONT  TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (522.87s)
=== CONT  TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_iamAuth (193.84s)
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_engineMode (465.57s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_backupsUpdate (221.63s)
=== CONT  TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (244.36s)
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_encrypted (197.30s)
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_kmsKey (184.44s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_networkType (255.75s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_updateIAMRoles (173.77s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (230.89s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (6.16s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_takeFinalSnapshot (288.94s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (443.39s)
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_pointInTimeRestore (422.91s)
=== CONT  TestAccRDSCluster_onlyMajorVersion
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2136.09s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_backtrackWindow (260.02s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2020.76s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (310.53s)
=== CONT  TestAccRDSCluster_serverlessV2ScalingConfiguration
--- PASS: TestAccRDSCluster_onlyMajorVersion (893.97s)
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (287.66s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_scaling (350.99s)
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (3008.42s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (2355.48s)
=== CONT  TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_iops (2223.42s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_availabilityZones (179.49s)
=== CONT  TestAccRDSCluster_minorVersion
--- PASS: TestAccRDSCluster_minorVersion (1212.14s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (158.66s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (223.20s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (151.27s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_allocatedStorage (2326.32s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_storageType (2468.90s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== NAME  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
    cluster_test.go:373: Step 3/3 error: Error running apply: exit status 1
        
        Error: updating RDS Cluster Instance (tf-acc-test-552019020713565634): InvalidParameterCombination: The parameter group tf-acc-test-55201902071356563420230503010544402100000007 with DBParameterGroupFamily aurora-postgresql13 can't be used for this instance. Use a parameter group with DBParameterGroupFamily aurora-postgresql12.
        	status code: 400, request id: 53fe7eec-f871-43d1-8b83-2d220a262abb
        
          with aws_rds_cluster_instance.test,
          on terraform_plugin_test.tf line 22, in resource "aws_rds_cluster_instance" "test":
          22: resource "aws_rds_cluster_instance" "test" {
        
--- FAIL: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (1308.23s)
=== CONT  TestAccRDSCluster_port
--- PASS: TestAccRDSCluster_port (219.22s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (157.49s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (2319.46s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2379.47s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (171.77s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (842.14s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (146.44s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (152.57s)
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2590.48s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (217.83s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1549.98s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_identifierGenerated (217.81s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_identifierPrefix (197.91s)
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_tags (209.81s)
--- PASS: TestAccRDSCluster_disappears (144.26s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2774.48s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	16321.765s

@github-actions
Copy link

github-actions bot commented May 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. labels May 2, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 2, 2023
@YakDriver YakDriver linked an issue May 2, 2023 that may be closed by this pull request
resource/aws_rds_cluster/aws_rds_cluster_instance: Remove default value from engine parameter #27960
Closed
2 tasks
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 3, 2023
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 3, 2023
@YakDriver YakDriver changed the title rds/cluster: engine becomes required rds/cluster/cluster_instance: engine becomes required May 3, 2023
@YakDriver YakDriver merged commit 5c327f7 into prerelease/5.x May 3, 2023
@YakDriver YakDriver deleted the t-rds-cluster-engine-default branch May 3, 2023 17:28
@github-actions github-actions bot added this to the v5.0.0 milestone May 3, 2023
github-actions bot pushed a commit that referenced this pull request May 3, 2023
Update CHANGELOG.md for #31112
cf51f5d
@jar-b jar-b mentioned this pull request May 23, 2023
Closed
2 tasks
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

resource/aws_rds_cluster/aws_rds_cluster_instance: Remove default value from engine parameter
1 participant
@YakDriver