Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds/cluster/cluster_instance: engine becomes required #31112

Merged
merged 5 commits into from
May 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changelog/31112.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
```release-note:breaking-change
resource/aws_rds_cluster: The `engine` argument is now required and has no default
```

```release-note:note
resource/aws_rds_cluster: Configurations not including the `engine` argument must be updated to include `engine` as it is now required. Previously, not including `engine` was equivalent to `engine = "aurora"` and created a MySQL-5.6-compatible cluster
```

```release-note:breaking-change
resource/aws_rds_cluster_instance: The `engine` argument is now required and has no default
```

```release-note:note
resource/aws_rds_cluster_instance: Configurations not including the `engine` argument must be updated to include `engine` as it is now required. Previously, not including `engine` was equivalent to `engine = "aurora"` and created a MySQL-5.6-compatible cluster instance
```
3 changes: 1 addition & 2 deletions internal/service/rds/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,8 @@ func ResourceCluster() *schema.Resource {
},
"engine": {
Type: schema.TypeString,
Optional: true,
Required: true,
ForceNew: true,
Default: ClusterEngineAurora,
ValidateFunc: validClusterEngine(),
},
"engine_mode": {
Expand Down
3 changes: 1 addition & 2 deletions internal/service/rds/cluster_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,8 @@ func ResourceClusterInstance() *schema.Resource {
},
"engine": {
Type: schema.TypeString,
Optional: true,
Required: true,
ForceNew: true,
Default: ClusterEngineAurora,
ValidateFunc: validClusterEngine(),
},
"engine_version": {
Expand Down
Loading