Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2825 supports classic EIP’s in data.aws_eip #3522

Merged
merged 1 commit into from
Nov 13, 2018
Merged

fixes #2825 supports classic EIP’s in data.aws_eip #3522

merged 1 commit into from
Nov 13, 2018

Conversation

richardbowden
Copy link
Contributor

No description provided.

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 25, 2018
@richardbowden richardbowden force-pushed the aws_eip_support_classic_eips_2825 branch from 5227715 to aa8b83f Compare February 25, 2018 16:11
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 25, 2018
@richardbowden richardbowden mentioned this pull request Feb 25, 2018
Merged
@bflad
Copy link
Contributor

bflad commented Feb 26, 2018 •
edited
Loading

@richardbowden do you think it makes more sense to instead deprecate the unclear id argument and instead use a new allocation_id argument? (id would remain an implicit Terraform attribute due to d.SetId()) I think that would simplify the data source usage and documentation. 😄

@bflad bflad added the service/ec2 Issues and PRs that pertain to the ec2 service. label Feb 26, 2018
@richardbowden
Copy link
Contributor Author

@bflad not to sure I follow what you mean? Do you mean replace the usage of id with allocation_id in the argument ref / schema or something else ?

@Ashex
Copy link

Ashex commented Mar 20, 2018 •
edited
Loading

@bflad Could you clarify the inquiry? This bug is a bit disruptive and I've had to wrap a module around an external data source as a workaround. This would resolve #2825

@bflad
Copy link
Contributor

bflad commented Mar 20, 2018

Do you mean replace the usage of id with allocation_id in the argument ref / schema or something else ?

Sorry, yes, I mean we should probably mark the id attribute in the schema as Deprecated: "Use allocation_id (VPC EIP) or public_ip (EC2-Classic EIP) instead" then create then allocation_id attribute with its appropriate handling.

@bflad bflad added this to the v1.45.0 milestone Nov 7, 2018
@bflad bflad merged commit aa8b83f into hashicorp:master Nov 13, 2018
bflad added a commit that referenced this pull request Nov 13, 2018
@bflad
data-source/aws_eip: Refactoring after merging #3505, #3522, and #3525
180fcee 
```
--- PASS: TestAccDataSourceAwsEip_PublicIP_EC2Classic (8.56s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (11.76s)
--- PASS: TestAccDataSourceAwsEip_Id (11.79s)
--- PASS: TestAccDataSourceAwsEip_Tags (12.45s)
--- PASS: TestAccDataSourceAwsEip_Filter (12.58s)
```
@bflad bflad modified the milestones: v1.45.0, v1.44.0 Nov 13, 2018
@bflad bflad mentioned this pull request Nov 13, 2018
Closed
bflad added a commit that referenced this pull request Nov 13, 2018
@bflad
Update CHANGELOG for #3505, #3522, and #3525
cf6a1ba
@bflad
Copy link
Contributor

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.
4 participants
@richardbowden @bflad @Ashex @www