Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source eip filters #5131

Closed
wants to merge 5 commits into from
Closed

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Jul 9, 2018

Fixes #4551

Changes proposed in this pull request:

  • add filter attribute
  • add association_id attribute
  • add private_ip attribute

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEip'
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsEip -timeout 120m
=== RUN   TestAccDataSourceAwsEip_basic
--- PASS: TestAccDataSourceAwsEip_basic (14.31s)
=== RUN   TestAccDataSourceAwsEip_filter
--- PASS: TestAccDataSourceAwsEip_filter (72.64s)
=== RUN   TestAccDataSourceAwsEip_association
--- PASS: TestAccDataSourceAwsEip_association (84.53s)
=== RUN   TestAccDataSourceAwsEip_private
--- PASS: TestAccDataSourceAwsEip_private (73.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	245.162s

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 9, 2018
@alexrudd
Copy link
Contributor

Hey, I think this would solve my use case in #4551

Thanks @kl4w :)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 10, 2018
@saravanan30erd
Copy link
Contributor

#3525

@kl4w
Copy link
Contributor Author

kl4w commented Jul 17, 2018

@saravanan30erd @bflad I'm happy to close this in favor of the others. Just let me know. Cheers.

@bflad
Copy link
Contributor

bflad commented Nov 13, 2018

Hi @kl4w 👋 Sorry for the very delayed response. I spent some time merging together #3505, #3522, and #3525 for the aws_eip data source, which required some refactoring to get everything working together and testing correctly on master. Would you be able to rebase this PR or submit a new one? Apologies for the hassle. 😅

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 13, 2018
@kl4w
Copy link
Contributor Author

kl4w commented Nov 13, 2018

@bflad i'm going to close this PR and submit a new one for setting some extra attributes

@kl4w kl4w closed this Nov 13, 2018
@kl4w kl4w deleted the data-source-eip-filters branch November 13, 2018 21:37
@kl4w
Copy link
Contributor Author

kl4w commented Nov 14, 2018

@bflad created a new PR: #6463

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_eip_association data source
5 participants