Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_mskconnect_worker_configuration: Add resource deletion support #37010

Conversation

arunderwood
Copy link

Description

Adds deletion support to the aws_mskconnect_worker_configuration resource.

Relations

Closes #36672

References

sdk-for-go KafkaConnect.DeleteWorkerConfigurationWithContext

Output from Acceptance Testing

% make testacc TESTS=TestAccKafkaConnectWorkerConfiguration PKG=kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run='TestAccKafkaConnectWorkerConfiguration'  -timeout 360m
=== RUN   TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== RUN   TestAccKafkaConnectWorkerConfiguration_basic
=== PAUSE TestAccKafkaConnectWorkerConfiguration_basic
=== RUN   TestAccKafkaConnectWorkerConfiguration_description
=== PAUSE TestAccKafkaConnectWorkerConfiguration_description
=== CONT  TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== CONT  TestAccKafkaConnectWorkerConfiguration_description
=== CONT  TestAccKafkaConnectWorkerConfiguration_basic
--- PASS: TestAccKafkaConnectWorkerConfigurationDataSource_basic (15.77s)
--- PASS: TestAccKafkaConnectWorkerConfiguration_description (16.38s)
--- PASS: TestAccKafkaConnectWorkerConfiguration_basic (23.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	26.931s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. labels Apr 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @arunderwood 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@arunderwood arunderwood changed the title Add deletion support to aws_mskconnect_worker_configuration f-aws_mskconnect_worker_configuration: Add resource deletion support Apr 20, 2024
@arunderwood arunderwood marked this pull request as ready for review April 20, 2024 02:45
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@twbecker
Copy link

What's the hold up on this PR?

@ewbankkit
Copy link
Contributor

@arunderwood Thanks for the contribution 🎉 👏.
This functionality has been included in #38270.

Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_mskconnect_worker_configuration resource does not implement deletion
4 participants