-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tags support to aws_mskconnect resources and data sources #38270
feat: Add tags support to aws_mskconnect resources and data sources #38270
Conversation
Community NoteVoting for Prioritization
For Submitters
|
bc9398c
to
1d32f2a
Compare
1d32f2a
to
0fc9a84
Compare
Just realized that #37010 already implemented the deletion logic for |
… && go mod tidy'.
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…s nil, not map[string]interface {}` panic when `log_delivery.worker_log_delivery` is empty (`{}`).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaConnect' PKG=kafkaconnect ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/kafkaconnect/... -v -count 1 -parallel 3 -run=TestAccKafkaConnect -timeout 720m
=== RUN TestAccKafkaConnectConnectorDataSource_basic
=== PAUSE TestAccKafkaConnectConnectorDataSource_basic
=== RUN TestAccKafkaConnectConnector_basic
=== PAUSE TestAccKafkaConnectConnector_basic
=== RUN TestAccKafkaConnectConnector_disappears
=== PAUSE TestAccKafkaConnectConnector_disappears
=== RUN TestAccKafkaConnectConnector_update
=== PAUSE TestAccKafkaConnectConnector_update
=== RUN TestAccKafkaConnectConnector_tags
=== PAUSE TestAccKafkaConnectConnector_tags
=== RUN TestAccKafkaConnectCustomPluginDataSource_basic
=== PAUSE TestAccKafkaConnectCustomPluginDataSource_basic
=== RUN TestAccKafkaConnectCustomPlugin_basic
=== PAUSE TestAccKafkaConnectCustomPlugin_basic
=== RUN TestAccKafkaConnectCustomPlugin_disappears
=== PAUSE TestAccKafkaConnectCustomPlugin_disappears
=== RUN TestAccKafkaConnectCustomPlugin_description
=== PAUSE TestAccKafkaConnectCustomPlugin_description
=== RUN TestAccKafkaConnectCustomPlugin_tags
=== PAUSE TestAccKafkaConnectCustomPlugin_tags
=== RUN TestAccKafkaConnectCustomPlugin_objectVersion
=== PAUSE TestAccKafkaConnectCustomPlugin_objectVersion
=== RUN TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic
=== RUN TestAccKafkaConnectWorkerConfiguration_basic
=== PAUSE TestAccKafkaConnectWorkerConfiguration_basic
=== RUN TestAccKafkaConnectWorkerConfiguration_disappears
=== PAUSE TestAccKafkaConnectWorkerConfiguration_disappears
=== RUN TestAccKafkaConnectWorkerConfiguration_description
=== PAUSE TestAccKafkaConnectWorkerConfiguration_description
=== RUN TestAccKafkaConnectWorkerConfiguration_tags
=== PAUSE TestAccKafkaConnectWorkerConfiguration_tags
=== CONT TestAccKafkaConnectConnectorDataSource_basic
=== CONT TestAccKafkaConnectCustomPlugin_description
=== CONT TestAccKafkaConnectWorkerConfiguration_basic
--- PASS: TestAccKafkaConnectCustomPlugin_description (34.97s)
=== CONT TestAccKafkaConnectWorkerConfiguration_description
--- PASS: TestAccKafkaConnectConnectorDataSource_basic (1852.52s)
=== CONT TestAccKafkaConnectWorkerConfiguration_tags
--- PASS: TestAccKafkaConnectWorkerConfiguration_description (13.36s)
=== CONT TestAccKafkaConnectCustomPlugin_objectVersion
--- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (40.77s)
=== CONT TestAccKafkaConnectWorkerConfigurationDataSource_basic
--- PASS: TestAccKafkaConnectWorkerConfiguration_basic (15.15s)
=== CONT TestAccKafkaConnectWorkerConfiguration_disappears
--- PASS: TestAccKafkaConnectWorkerConfiguration_tags (29.60s)
=== CONT TestAccKafkaConnectConnector_tags
--- PASS: TestAccKafkaConnectWorkerConfiguration_disappears (11.82s)
=== CONT TestAccKafkaConnectCustomPlugin_disappears
--- PASS: TestAccKafkaConnectWorkerConfigurationDataSource_basic (13.01s)
=== CONT TestAccKafkaConnectCustomPlugin_basic
--- PASS: TestAccKafkaConnectCustomPlugin_disappears (33.25s)
=== CONT TestAccKafkaConnectCustomPluginDataSource_basic
--- PASS: TestAccKafkaConnectCustomPlugin_basic (35.22s)
=== CONT TestAccKafkaConnectConnector_disappears
--- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (26.65s)
=== CONT TestAccKafkaConnectConnector_update
--- PASS: TestAccKafkaConnectConnector_tags (2786.41s)
=== CONT TestAccKafkaConnectConnector_basic
--- PASS: TestAccKafkaConnectConnector_basic (1863.57s)
=== CONT TestAccKafkaConnectCustomPlugin_tags
--- PASS: TestAccKafkaConnectConnector_disappears (2570.85s)
--- PASS: TestAccKafkaConnectCustomPlugin_tags (61.44s)
--- PASS: TestAccKafkaConnectConnector_update (3015.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 12465.262s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add tags support to the
aws_mskconnect
resources and data sources.While working on this feature, I also found that the
aws_mskconnect_worker_configuration
was missing resource deletion support. I am not sure if this was for historical reason, but the DeleteWorkerConfiguration API action exists. As such I have added it as part of the PR.Relations
Closes #36375.
Closes #38249.
Closes #36672.
Closes #37010.
Closes #36186.
Closes #28966.
References
Referred to the API reference for specs.
Output from Acceptance Testing
aws_mskconnect_connector
resource and data source:aws_mskconnect_custom_plugin
resource and data source:aws_mskconnect_worker_configuration
resource and data source: