Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tags support to aws_mskconnect resources and data sources #38270

Merged
merged 16 commits into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .changelog/38270.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
```release-note:enhancement
resource/aws_mskconnect_connector: Add `tags` argument and `tags_all` attribute
```

```release-note:enhancement
resource/aws_mskconnect_custom_plugin: Add `tags` argument and `tags_all` attribute
```

```release-note:enhancement
resource/aws_mskconnect_worker_configuration: Add `tags` argument and `tags_all` attribute
```

```release-note:enhancement
resource/aws_mskconnect_worker_configuration: Add resource deletion logic
```

```release-note:enhancement
data-source/aws_mskconnect_connector: Add `tags` attribute
```

```release-note:enhancement
data-source/aws_mskconnect_custom_plugin: Add `tags` attribute
```

```release-note:enhancement
data-source/aws_mskconnect_worker_configuration: Add `tags` attribute
```

```release-note:bug
resource/aws_mskconnect_connector: Fix `interface conversion: interface {} is nil, not map[string]interface {}` panic when `log_delivery.worker_log_delivery` is empty (`{}`)
```
1 change: 1 addition & 0 deletions .ci/semgrep/migrate/context.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ rules:
- pattern-not: conn.Options()
- pattern-not: codestarconnections_sdkv2.$API()
- pattern-not: connectcases_sdkv2.$API()
- pattern-not: kafkaconnect_sdkv2.$API()
- pattern-not: mediaconnect_sdkv2.$API()
- pattern-not: pcaconnectorad_sdkv2.$API()
severity: ERROR
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/iotevents v1.25.1
github.com/aws/aws-sdk-go-v2/service/ivschat v1.14.1
github.com/aws/aws-sdk-go-v2/service/kafka v1.35.1
github.com/aws/aws-sdk-go-v2/service/kafkaconnect v1.19.1
github.com/aws/aws-sdk-go-v2/service/kendra v1.52.1
github.com/aws/aws-sdk-go-v2/service/keyspaces v1.12.1
github.com/aws/aws-sdk-go-v2/service/kinesis v1.29.1
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,8 @@ github.com/aws/aws-sdk-go-v2/service/ivschat v1.14.1 h1:rmVLJaE6iqVSSeipZnhul8BM
github.com/aws/aws-sdk-go-v2/service/ivschat v1.14.1/go.mod h1:IUQ9qdszWBPacNZ36JLkmOxGx/2LCzz/DOZjpg/8tz4=
github.com/aws/aws-sdk-go-v2/service/kafka v1.35.1 h1:Q4Jr/gf+7LHjBFTdecQJn4ugVoVszCHzyq1EztrHHkc=
github.com/aws/aws-sdk-go-v2/service/kafka v1.35.1/go.mod h1:7/xNH8gqz3k4p4OyW5+s8ecOp1Xg+vBTPMKpMNjeeik=
github.com/aws/aws-sdk-go-v2/service/kafkaconnect v1.19.1 h1:mtbyDAlKv06I6KWTcbhKEUPe51Vinm5RbcmzYI8UWPw=
github.com/aws/aws-sdk-go-v2/service/kafkaconnect v1.19.1/go.mod h1:8XzP4poz+dq07pMe/w+9707EuHp/5lP0OACGvQnVnlo=
github.com/aws/aws-sdk-go-v2/service/kendra v1.52.1 h1:mVfjPIVnnSYLWnGYPrTrPlXohOMmYvQpjmYiBLnTh4M=
github.com/aws/aws-sdk-go-v2/service/kendra v1.52.1/go.mod h1:mjdRASBq4jLAUxSSBk4jvXdyciq6hZl162yoJ1+BTdc=
github.com/aws/aws-sdk-go-v2/service/keyspaces v1.12.1 h1:OmIPCAjROLz+AJyzvNpJRD4cenApFQJAeAIWrkRXOo8=
Expand Down
6 changes: 3 additions & 3 deletions internal/conns/awsclient_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading