[36500] Allow to specify single DNS server when using Customer Manage Active Directory for RDS MSSQL

[kostasns]

Description

Currently when working with Customer Managed Active Directory it is not possible to provide a single domain controller IP by providing it twice, see reference below.
This PR changes type for 'domain_dns_ip' from Set to List to allow this option.

Relations

Closes #36500

References

https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ModifyDBInstance.html#API_ModifyDBInstance_RequestParameters

DomainDnsIps.member.N
The IPv4 DNS IP addresses of your primary and secondary Active Directory domain controllers.

Constraints:
Two IP addresses must be provided. If there isn't a secondary domain controller, use the IP address of the primary domain controller for both entries in the list.

Output from Acceptance Testing

I'm unable to run acc tests, this is a best effort implementation.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @kostasns 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

The CloudFormation AWS::RDS::DBInstance schema contains

    "DomainDnsIps": {
      "type": "array",
      "items": {
        "type": "string"
      },
      "description": "The IPv4 DNS IP addresses of your primary and secondary Active Directory domain controllers.\n Constraints:\n  +  Two IP addresses must be provided. If there isn't a secondary domain controller, use the IP address of the primary domain controller for both entries in the list.\n  \n Example: ``123.124.125.126,234.235.236.237``"
    },

so TypeList is appropriate.

[jar-b]

LGTM 🎉

% make testacc PKG=rds TESTS=TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP'  -timeout 360m
=== RUN   TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
=== PAUSE TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP (1204.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1211.008s

% make testacc PKG=rds TESTS=TestAccRDSInstance_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_'  -timeout 360m

--- PASS: TestAccRDSInstance_basic (528.71s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier
--- PASS: TestAccRDSInstance_newIdentifier_Pending (620.98s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_newIdentifier_Immediately (672.45s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_port
--- PASS: TestAccRDSInstance_Storage_changeIOPS (702.49s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica
--- PASS: TestAccRDSInstance_Storage_typePostgres (868.54s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName (986.35s)                                                                                                                                     === CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth
--- PASS: TestAccRDSInstance_Storage_throughputSSE (1012.35s)
=== CONT  TestAccRDSInstance_license
--- PASS: TestAccRDSInstance_SnapshotIdentifier_availabilityZone (1044.99s)
=== CONT  TestAccRDSInstance_Storage_changeIOPSThroughput
--- PASS: TestAccRDSInstance_PerformanceInsights_retentionPeriod (1058.56s)
=== CONT  TestAccRDSInstance_Storage_changeThroughput
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs (1167.54s)
=== CONT  TestAccRDSInstance_Storage_gp3SQLServer
--- PASS: TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade (1207.22s)
=== CONT  TestAccRDSInstance_Storage_gp3Postgres
--- PASS: TestAccRDSInstance_SnapshotIdentifier_ManageMasterPasswordKMSKey (1225.17s)
=== CONT  TestAccRDSInstance_Storage_gp3MySQL
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupWindow (1268.46s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_outOfBand
--- PASS: TestAccRDSInstance_SnapshotIdentifier_deletionProtection (1306.36s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth (1403.84s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride (1523.37s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen
--- PASS: TestAccRDSInstance_Storage_changeThroughput (704.01s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset (1778.83s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
--- PASS: TestAccRDSInstance_Storage_changeIOPSThroughput (744.24s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
--- PASS: TestAccRDSInstance_Storage_gp3MySQL (604.88s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_tags
--- PASS: TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade (1883.23s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
--- PASS: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupNameVPCSecurityGroupIDs (1944.78s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
--- PASS: TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs (1351.84s)
=== CONT  TestAccRDSInstance_Storage_maxAllocated
--- PASS: TestAccRDSInstance_ReplicateSourceDB_port (1322.57s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupNameRAMShared
    instance_test.go:1486: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alte
rnate AWS account.
--- SKIP: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupNameRAMShared (0.00s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName
--- PASS: TestAccRDSInstance_Storage_gp3Postgres (810.84s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_backupWindow
--- PASS: TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier (1688.38s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod
--- PASS: TestAccRDSInstance_license (1230.02s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_availabilityZone
--- PASS: TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen (858.33s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade
--- PASS: TestAccRDSInstance_BlueGreenDeployment_deletionProtectionBypassesBlueGreen (754.71s)                                                                                                                  === CONT  TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade
--- PASS: TestAccRDSInstance_Storage_gp3SQLServer (1124.55s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica (1636.26s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_iops
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue (1621.63s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_allocatedStorage
--- PASS: TestAccRDSInstance_BlueGreenDeployment_tags (709.35s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_basic
--- PASS: TestAccRDSInstance_Storage_maxAllocated (770.42s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_multiAZ
=== CONT  TestAccRDSInstance_ReplicateSourceDB_networkType
--- PASS: TestAccRDSInstance_ReplicateSourceDB_characterSet_Source (2750.53s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNamePostgres
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth (1967.20s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_basic (1119.42s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists
--- PASS: TestAccRDSInstance_ReplicateSourceDB_availabilityZone (1455.73s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection (2397.64s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_monitoring
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupWindow (1733.32s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade (1528.35s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops (1517.98s)                                                                                                               13:20:21 [1/460]
=== CONT  TestAccRDSInstance_ReplicateSourceDB_replicaMode
--- PASS: TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade (1559.65s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iops (1585.73s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica
--- PASS: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName (1934.70s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorage (1466.01s)
=== CONT  TestAccRDSInstance_optionGroup
--- PASS: TestAccRDSInstance_BlueGreenDeployment_outOfBand (2728.67s)
=== CONT  TestAccRDSInstance_Versions_onlyMajor
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2134.41s)
=== CONT  TestAccRDSInstance_isAlreadyBeingDeleted
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod (1934.94s)
=== CONT  TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup (2319.37s)
=== CONT  TestAccRDSInstance_FinalSnapshotIdentifier_basic
--- PASS: TestAccRDSInstance_ReplicateSourceDB_networkType (1514.03s)
=== CONT  TestAccRDSInstance_deletionProtection
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups (2511.13s)
=== CONT  TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_Versions_onlyMajor (470.80s)
=== CONT  TestAccRDSInstance_DBSubnetGroupName_ramShared
    instance_test.go:584: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRDSInstance_DBSubnetGroupName_ramShared (0.00s)
=== CONT  TestAccRDSInstance_Versions_allowMajor
--- PASS: TestAccRDSInstance_isAlreadyBeingDeleted (406.40s)
=== CONT  TestAccRDSInstance_iamAuth
--- PASS: TestAccRDSInstance_ReplicateSourceDB_multiAZ (1795.17s)
=== CONT  TestAccRDSInstance_networkType
--- PASS: TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot (397.60s)
=== CONT  TestAccRDSInstance_customIAMInstanceProfile
--- PASS: TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs (280.68s)
=== CONT  TestAccRDSInstance_kmsKey
--- PASS: TestAccRDSInstance_iamAuth (162.57s)
=== CONT  TestAccRDSInstance_DBSubnetGroupName_basic
--- PASS: TestAccRDSInstance_deletionProtection (384.61s)
=== CONT  TestAccRDSInstance_disappears
--- PASS: TestAccRDSInstance_Versions_allowMajor (184.90s)
=== CONT  TestAccRDSInstance_engineLifecycleSupport_disabled
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled (725.27s)
=== CONT  TestAccRDSInstance_ManageMasterPassword_convertToManaged
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring (951.32s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_namePrefix
--- PASS: TestAccRDSInstance_FinalSnapshotIdentifier_basic (453.78s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_basic
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists (999.72s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_nameGenerated
--- PASS: TestAccRDSInstance_optionGroup (787.77s)
=== CONT  TestAccRDSInstance_identifierGenerated
--- PASS: TestAccRDSInstance_kmsKey (283.29s)
=== CONT  TestAccRDSInstance_identifierPrefix
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow (1029.49s)
=== CONT  TestAccRDSInstance_MSSQL_tz
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica (3185.96s)
=== CONT  TestAccRDSInstance_Oracle_nationalCharacterSet
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage (1161.41s)
=== CONT  TestAccRDSInstance_PerformanceInsights_kmsKeyID
--- PASS: TestAccRDSInstance_networkType (581.08s)
=== CONT  TestAccRDSInstance_Outposts_backupTarget
    instance_test.go:5167: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_Outposts_backupTarget (0.48s)
=== CONT  TestAccRDSInstance_PerformanceInsights_enabledToDisabled
--- PASS: TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica (1234.30s)
=== CONT  TestAccRDSInstance_Outposts_coIPSnapshotIdentifier
    instance_test.go:5138: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_Outposts_coIPSnapshotIdentifier (0.19s)
=== CONT  TestAccRDSInstance_PerformanceInsights_disabledToEnabled
--- PASS: TestAccRDSInstance_disappears (526.76s)
=== CONT  TestAccRDSInstance_Outposts_coIPRestoreToPointInTime
    instance_test.go:5096: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_Outposts_coIPRestoreToPointInTime (0.18s)
=== CONT  TestAccRDSInstance_noDeleteAutomatedBackups
--- PASS: TestAccRDSInstance_engineLifecycleSupport_disabled (532.48s)
=== CONT  TestAccRDSInstance_Outposts_coIPEnabledToDisabled
    instance_test.go:5054: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_Outposts_coIPEnabledToDisabled (0.18s)
=== CONT  TestAccRDSInstance_dedicatedLogVolume_enableOnUpdate
--- PASS: TestAccRDSInstance_identifierGenerated (492.35s)
=== CONT  TestAccRDSInstance_Outposts_coIPDisabledToEnabled
    instance_test.go:5013: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_Outposts_coIPDisabledToEnabled (0.19s)
=== CONT  TestAccRDSInstance_dedicatedLogVolume_enableOnCreate
--- PASS: TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNamePostgres (2293.81s)
=== CONT  TestAccRDSInstance_Outposts_coIPEnabled
    instance_test.go:4988: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_Outposts_coIPEnabled (0.17s)
=== CONT  TestAccRDSInstance_CloudWatchLogsExport_postgresql
--- PASS: TestAccRDSInstance_ManageMasterPassword_convertToManaged (597.85s)
=== CONT  TestAccRDSInstance_Oracle_noNationalCharacterSet
--- PASS: TestAccRDSInstance_identifierPrefix (531.40s)
=== CONT  TestAccRDSInstance_CloudWatchLogsExport_oracle
--- PASS: TestAccRDSInstance_ReplicateSourceDB_replicaMode (1732.01s)
=== CONT  TestAccRDSInstance_CloudWatchLogsExport_msSQL
--- PASS: TestAccRDSInstance_DBSubnetGroupName_basic (1065.42s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_PerformanceInsights_disabledToEnabled (598.67s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_addLater
--- PASS: TestAccRDSInstance_dedicatedLogVolume_enableOnCreate (593.32s)
=== CONT  TestAccRDSInstance_ManageMasterPassword_kmsKey
--- PASS: TestAccRDSInstance_PerformanceInsights_enabledToDisabled (711.00s)
=== CONT  TestAccRDSInstance_ManageMasterPassword_basic
--- PASS: TestAccRDSInstance_CloudWatchLogsExport_postgresql (594.20s)
=== CONT  TestAccRDSInstance_password
--- PASS: TestAccRDSInstance_noDeleteAutomatedBackups (713.65s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_multiAZ
--- PASS: TestAccRDSInstance_ReplicateSourceDB_CrossRegion_parameterGroupNameEquivalent (2216.56s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_tags
--- PASS: TestAccRDSInstance_Oracle_nationalCharacterSet (1043.66s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_port
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep (2271.78s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
--- PASS: TestAccRDSInstance_PerformanceInsights_kmsKeyID (1076.57s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
--- PASS: TestAccRDSInstance_ReplicateSourceDB_namePrefix (1474.91s)
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore
--- PASS: TestAccRDSInstance_ReplicateSourceDB_nameGenerated (1553.19s)
=== CONT  TestAccRDSInstance_CloudWatchLogsExport_basic
--- PASS: TestAccRDSInstance_Oracle_noNationalCharacterSet (1009.88s)
=== CONT  TestAccRDSInstance_Versions_minor
--- PASS: TestAccRDSInstance_ManageMasterPassword_basic (492.61s)
=== CONT  TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
--- PASS: TestAccRDSInstance_ManageMasterPassword_kmsKey (497.31s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage
=== NAME  TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
    instance_test.go:4000: Step 1/1 error: Error running apply: exit status 1

        Error: creating RDS DB Instance (tf-acc-test-7654066073595661364): InvalidParameterCombination: Cannot find version 8.0.31 for mysql
                status code: 400, request id: cfa56b85-8781-4fb8-9e14-567ec6b391bd

          with aws_db_instance.test,
          on terraform_plugin_test.tf line 61, in resource "aws_db_instance" "test":
          61: resource "aws_db_instance" "test" {

--- FAIL: TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion (15.89s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_monitoring
--- PASS: TestAccRDSInstance_CloudWatchLogsExport_msSQL (833.65s)
=== CONT  TestAccRDSInstance_caCertificateIdentifier
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1738.34s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_manageMasterPassword
--- PASS: TestAccRDSInstance_CloudWatchLogsExport_oracle (1108.41s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_monitoring
--- PASS: TestAccRDSInstance_password (663.76s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
--- PASS: TestAccRDSInstance_dedicatedLogVolume_enableOnUpdate (1342.11s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
--- PASS: TestAccRDSInstance_CloudWatchLogsExport_basic (426.32s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow
--- PASS: TestAccRDSInstance_MSSQL_tz (1880.27s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs (1028.86s)
=== CONT  TestAccRDSInstance_Storage_separateIOPSUpdate_Io2
--- PASS: TestAccRDSInstance_Versions_minor (537.71s)
=== CONT  TestAccRDSInstance_Storage_separateIOPSUpdate_Io1
--- PASS: TestAccRDSInstance_caCertificateIdentifier (620.94s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
--- PASS: TestAccRDSInstance_customIAMInstanceProfile (2503.50s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_allocatedStorage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_tags (1269.13s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io2Storage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_port (1191.79s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== NAME  TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
    instance_test.go:5396: Step 2/3 error: Error running apply: exit status 1

        Error: updating RDS DB Instance (tf-acc-test-7649014543459908425): switching over Blue/Green Deployment: waiting for completion: timeout while waiting for state to become 'SWITCHOVER_COMPLETED' (last
state: 'AVAILABLE', timeout: 1h1m55.774935417s)

          with aws_db_instance.test,
          on terraform_plugin_test.tf line 29, in resource "aws_db_instance" "test":
          29: resource "aws_db_instance" "test" {

--- PASS: TestAccRDSInstance_ReplicateSourceDB_addLater (1575.74s)
=== CONT  TestAccRDSInstance_monitoringInterval
--- PASS: TestAccRDSInstance_SnapshotIdentifier_parameterGroupName (1390.79s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io2 (712.15s)
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomain
--- FAIL: TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass (5703.93s)
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
--- PASS: TestAccRDSInstance_Storage_separateIOPSUpdate_Io1 (707.42s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
--- PASS: TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage (1211.50s)
=== CONT  TestAccRDSInstance_CloudWatchLogsExport_mySQL
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved (915.33s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier (1183.49s)
=== CONT  TestAccRDSInstance_MSSQL_domainSnapshotRestore
--- PASS: TestAccRDSInstance_SnapshotIdentifier_monitoring (1382.28s)
=== CONT  TestAccRDSInstance_MSSQL_domain
--- PASS: TestAccRDSInstance_SnapshotIdentifier_multiAZ (1882.86s)
=== CONT  TestAccRDSInstance_portUpdate
--- PASS: TestAccRDSInstance_MonitoringRoleARN_removedToEnabled (776.66s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceResourceID (1319.33s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
--- PASS: TestAccRDSInstance_RestoreToPointInTime_manageMasterPassword (1502.45s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
--- PASS: TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow (1416.66s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_namePrefix
--- PASS: TestAccRDSInstance_RestoreToPointInTime_monitoring (1581.02s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_nameGenerated
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled (877.49s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags (1004.71s)
--- PASS: TestAccRDSInstance_portUpdate (753.36s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled (882.69s)
--- PASS: TestAccRDSInstance_CloudWatchLogsExport_mySQL (1069.46s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_allocatedStorage (1560.88s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io2Storage (1461.29s)
--- PASS: TestAccRDSInstance_monitoringInterval (1352.61s)
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomainSnapshotRestore (2571.24s)
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP (1216.83s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io1Storage (1662.46s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved (1043.29s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled (1266.98s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_nameGenerated (983.62s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_namePrefix (1043.58s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled (1645.01s)
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomain (2166.99s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer (4394.37s)
--- PASS: TestAccRDSInstance_MSSQL_domainSnapshotRestore (2967.40s)
--- PASS: TestAccRDSInstance_MSSQL_domain (3227.86s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/rds        10955.786s

Test failures unrelated to this change.

[jar-b]

Thanks for your contribution, @kostasns! 👍

[github-actions]

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.