Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[36500] Allow to specify single DNS server when using Customer Manage Active Directory for RDS MSSQL #37462

Merged
merged 4 commits into from
Jul 29, 2024
Merged

[36500] Allow to specify single DNS server when using Customer Manage Active Directory for RDS MSSQL #37462

merged 4 commits into from
Jul 29, 2024

Commits on May 13, 2024

  1. PR-36500 Change domain_dns_ips to List

    @kostasns
    kostasns committed May 13, 2024
    Configuration menu
    Copy the full SHA
    bcb66f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'main' into b-aws_rds_instance-36500

    @jar-b
    jar-b committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6450ce3 View commit details
    Browse the repository at this point in the history

  2. chore: tweak changelog

    @jar-b
    jar-b committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4f4d2f2 View commit details
    Browse the repository at this point in the history

  3. r/aws_db_instance(test): add MSSQL single domain DNS IP test 

    ```console
% make testacc PKG=rds TESTS=TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP'  -timeout 360m
=== RUN   TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
=== PAUSE TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
=== CONT  TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP
--- PASS: TestAccRDSInstance_MSSQL_selfManagedDomainSingleDomainDNSIP (1204.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1211.008s
```
    @jar-b
    jar-b committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c44f0cf View commit details
    Browse the repository at this point in the history