Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/aws glue catalog table #37891

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jun 8, 2024

Description

Relations

Closes #34018

References

Output from Acceptance Testing

% make testacc TESTS=TestAccGlueCatalogTable_ PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTable_'  -timeout 360m
=== RUN   TestAccGlueCatalogTable_basic
=== PAUSE TestAccGlueCatalogTable_basic
=== RUN   TestAccGlueCatalogTable_columnParameters
=== PAUSE TestAccGlueCatalogTable_columnParameters
=== RUN   TestAccGlueCatalogTable_full
=== PAUSE TestAccGlueCatalogTable_full
=== RUN   TestAccGlueCatalogTable_Update_addValues
=== PAUSE TestAccGlueCatalogTable_Update_addValues
=== RUN   TestAccGlueCatalogTable_Update_replaceValues
=== PAUSE TestAccGlueCatalogTable_Update_replaceValues
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== RUN   TestAccGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccGlueCatalogTable_Disappears_database
=== PAUSE TestAccGlueCatalogTable_Disappears_database
=== RUN   TestAccGlueCatalogTable_targetTable
=== PAUSE TestAccGlueCatalogTable_targetTable
=== RUN   TestAccGlueCatalogTable_disappears
=== PAUSE TestAccGlueCatalogTable_disappears
=== RUN   TestAccGlueCatalogTable_openTableFormat
=== PAUSE TestAccGlueCatalogTable_openTableFormat
=== CONT  TestAccGlueCatalogTable_basic
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== CONT  TestAccGlueCatalogTable_Update_addValues
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== CONT  TestAccGlueCatalogTable_columnParameters
=== CONT  TestAccGlueCatalogTable_full
=== CONT  TestAccGlueCatalogTable_openTableFormat
=== CONT  TestAccGlueCatalogTable_disappears
=== CONT  TestAccGlueCatalogTable_targetTable
=== CONT  TestAccGlueCatalogTable_Disappears_database
=== CONT  TestAccGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== CONT  TestAccGlueCatalogTable_Update_replaceValues
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_emptyBlock (136.82s)
--- PASS: TestAccGlueCatalogTable_disappears (141.14s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock (141.59s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock (142.80s)
--- PASS: TestAccGlueCatalogTable_Disappears_database (146.73s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesMultiple (161.05s)
--- PASS: TestAccGlueCatalogTable_full (161.43s)
--- PASS: TestAccGlueCatalogTable_columnParameters (161.52s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesSingle (161.85s)
--- PASS: TestAccGlueCatalogTable_basic (162.13s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN (162.64s)
--- PASS: TestAccGlueCatalogTable_targetTable (162.73s)
--- PASS: TestAccGlueCatalogTable_Update_replaceValues (192.64s)
--- PASS: TestAccGlueCatalogTable_Update_addValues (192.65s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues (192.66s)
--- PASS: TestAccGlueCatalogTable_openTableFormat (193.88s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReference (194.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	210.853s

...

Copy link

github-actions bot commented Jun 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. labels Jun 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 8, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 11, 2024
@johnsonaj johnsonaj self-assigned this Jun 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
@johnsonaj johnsonaj requested a review from a team as a code owner June 14, 2024 15:24
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccGlueCatalogTable_\|TestAccGlueCatalogTableDataSource_' PKG=glue

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueCatalogTable_\|TestAccGlueCatalogTableDataSource_ -timeout 360m
--- PASS: TestAccGlueCatalogTable_disappears (29.49s)
--- PASS: TestAccGlueCatalogTable_Disappears_database (29.71s)
--- PASS: TestAccGlueCatalogTableDataSource_basic (30.01s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_emptyBlock (30.30s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock (31.07s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock (31.16s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesSingle (32.52s)
--- PASS: TestAccGlueCatalogTable_basic (32.72s)
--- PASS: TestAccGlueCatalogTable_columnParameters (32.85s)
--- PASS: TestAccGlueCatalogTable_full (34.33s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesMultiple (34.51s)
--- PASS: TestAccGlueCatalogTable_targetTable (35.20s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN (35.40s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues (43.26s)
--- PASS: TestAccGlueCatalogTable_Update_replaceValues (43.33s)
--- PASS: TestAccGlueCatalogTable_Update_addValues (43.34s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReference (44.86s)
--- PASS: TestAccGlueCatalogTable_openTableFormat (45.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	50.989s

@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 46b15e9 into hashicorp:main Jun 14, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 14, 2024
@nikhil-goenka nikhil-goenka deleted the f/aws_glue_catalog_table branch June 16, 2024 13:01
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 20, 2024
Copy link

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add AdditionalLocations parameter to aws_glue_catalog_table
3 participants