Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Outposts resources to AWS SDK V2 #38075

Merged
merged 32 commits into from
Jul 8, 2024
Merged

Migrate Outposts resources to AWS SDK V2 #38075

merged 32 commits into from
Jul 8, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Jun 22, 2024 •
edited by ewbankkit
Loading

Description

This PR migrates the Outposts resources to AWS SDKv2.

Note for the reviewer, that I wasn't able to run the tests as my account doesn't have any Outposts.

Relations

Closes #36196

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2Outposts' PKG=ec2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2Outposts -timeout 360m
=== RUN   TestAccEC2OutpostsCoIPPoolDataSource_filter
=== PAUSE TestAccEC2OutpostsCoIPPoolDataSource_filter
=== RUN   TestAccEC2OutpostsCoIPPoolDataSource_id
=== PAUSE TestAccEC2OutpostsCoIPPoolDataSource_id
=== RUN   TestAccEC2OutpostsCoIPPoolsDataSource_basic
=== PAUSE TestAccEC2OutpostsCoIPPoolsDataSource_basic
=== RUN   TestAccEC2OutpostsCoIPPoolsDataSource_filter
=== PAUSE TestAccEC2OutpostsCoIPPoolsDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayRoute_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRoute_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRoute_disappears
=== PAUSE TestAccEC2OutpostsLocalGatewayRoute_disappears
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
=== RUN   TestAccEC2OutpostsLocalGatewaysDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewaysDataSource_basic
=== CONT  TestAccEC2OutpostsCoIPPoolDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
=== CONT  TestAccEC2OutpostsLocalGatewayRoute_disappears
=== CONT  TestAccEC2OutpostsLocalGatewayRoute_basic
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewaysDataSource_basic
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
=== CONT  TestAccEC2OutpostsLocalGatewayDataSource_basic
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
=== CONT  TestAccEC2OutpostsCoIPPoolsDataSource_basic
=== CONT  TestAccEC2OutpostsCoIPPoolsDataSource_filter
=== NAME  TestAccEC2OutpostsLocalGatewaysDataSource_basic
    outposts_local_gateways_data_source_test.go:19: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewaysDataSource_basic (1.42s)
=== CONT  TestAccEC2OutpostsCoIPPoolDataSource_id
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
    outposts_local_gateway_route_table_data_source_test.go:64: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID (1.46s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
=== NAME  TestAccEC2OutpostsCoIPPoolDataSource_filter
    outposts_coip_pool_data_source_test.go:20: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolDataSource_filter (1.49s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
    outposts_local_gateway_virtual_interface_data_source_test.go:47: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id (1.54s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
=== NAME  TestAccEC2OutpostsCoIPPoolDataSource_id
    outposts_coip_pool_data_source_test.go:41: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolDataSource_id (0.23s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
    outposts_local_gateway_virtual_interface_group_data_source_test.go:66: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags (0.25s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
    outposts_local_gateway_route_table_vpc_association_test.go:60: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears (0.23s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
    outposts_local_gateway_route_table_vpc_association_test.go:83: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags (0.23s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
    outposts_local_gateway_route_table_vpc_association_test.go:30: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic (0.25s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
    outposts_local_gateway_route_table_data_source_test.go:86: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN (0.22s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
    outposts_local_gateway_route_table_data_source_test.go:20: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic (6.42s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
    outposts_local_gateway_route_tables_data_source_test.go:38: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter (6.46s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
    outposts_local_gateway_route_table_data_source_test.go:42: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter (6.48s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
    outposts_local_gateway_virtual_interface_groups_data_source_test.go:41: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter (6.49s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
    outposts_local_gateway_virtual_interface_group_data_source_test.go:43: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID (6.55s)
=== NAME  TestAccEC2OutpostsLocalGatewayRoute_basic
    outposts_local_gateway_route_test.go:30: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRoute_basic (10.80s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
    outposts_local_gateway_virtual_interface_groups_data_source_test.go:62: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags (10.86s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
    outposts_local_gateway_virtual_interface_data_source_test.go:22: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter (11.15s)
=== NAME  TestAccEC2OutpostsLocalGatewayDataSource_basic
    outposts_local_gateway_data_source_test.go:20: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayDataSource_basic (11.30s)
=== NAME  TestAccEC2OutpostsLocalGatewayRoute_disappears
    outposts_local_gateway_route_test.go:60: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRoute_disappears (11.51s)
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
    outposts_local_gateway_route_tables_data_source_test.go:19: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic (11.57s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
    outposts_local_gateway_virtual_interface_data_source_test.go:74: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags (11.58s)
=== NAME  TestAccEC2OutpostsCoIPPoolsDataSource_basic
    outposts_coip_pools_data_source_test.go:19: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolsDataSource_basic (11.60s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
    outposts_local_gateway_virtual_interface_group_data_source_test.go:22: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter (11.64s)
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
    outposts_local_gateway_virtual_interface_groups_data_source_test.go:21: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic (11.65s)
=== NAME  TestAccEC2OutpostsCoIPPoolsDataSource_filter
    outposts_coip_pools_data_source_test.go:38: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolsDataSource_filter (12.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        16.502s
➜  terraform-provider-aws git:(f/migrate-outposts-sdkv2)

@DanielRieske
feat: migrated d/ec2_outposts_coip_pool to SDKv2
d6d5072
@DanielRieske
feat: migrated d/ec2_outposts_coip_pools to SDKv2
2f79ee4
@DanielRieske
feat: migrated d/ec2_outposts_local_gateway to SDKv2
b182e74
@DanielRieske
feat: migrated d/ec2_outposts_local_gateway_route_table to SDKv2
30b7383
@DanielRieske
feat: migrated r/ec2_outposts_local_gateway_route_table_vpc_associati…
6772be7 
…on to SDKv2
@DanielRieske
feat: migrated r/ec2_outposts_local_gateway_route to SDKv2
91afc73
@DanielRieske
feat: migrated d/ec2_outposts_local_gateways to SDKv2
144a087
@DanielRieske
feat: migrated d/ec2_outposts_local_gateway_route_tables to SDKv2
a946086
@DanielRieske
feat: migrated d/ec2_outposts_local_gateway_virtual_interface to SDKv2
05c6592
@DanielRieske
feat: migrated d/ec2_outposts_local_gateway_virtual_interface_group t…
96a05c0 
…o SDKv2
@DanielRieske
feat: migrated d/ec2_outposts_local_gateway_virtual_interface_groups …
86aff35 
…to SDKv2
@DanielRieske
feat: migrate relevant wait functions to SDKv2
b21e1b2
@DanielRieske
feat: migrate relevant status functions to SDKv2
d6441d6
@DanielRieske
feat: migrate relevant find functions to SDKv2
5beb567
@DanielRieske
feat: reduce visibility
f6106bd
@DanielRieske
feat: run make gen
a6e3946
@DanielRieske DanielRieske requested a review from a team as a code owner June 22, 2024 13:03
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. labels Jun 22, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jun 22, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jun 22, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 25, 2024
@ewbankkit ewbankkit self-assigned this Jun 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 26, 2024
@ewbankkit
Copy link
Contributor 

% make testacc TESTARGS='-run=TestAccEC2Outposts' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2Outposts -timeout 360m
=== RUN   TestAccEC2OutpostsCoIPPoolDataSource_filter
=== PAUSE TestAccEC2OutpostsCoIPPoolDataSource_filter
=== RUN   TestAccEC2OutpostsCoIPPoolDataSource_id
=== PAUSE TestAccEC2OutpostsCoIPPoolDataSource_id
=== RUN   TestAccEC2OutpostsCoIPPoolsDataSource_basic
=== PAUSE TestAccEC2OutpostsCoIPPoolsDataSource_basic
=== RUN   TestAccEC2OutpostsCoIPPoolsDataSource_filter
=== PAUSE TestAccEC2OutpostsCoIPPoolsDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayRoute_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayRoute_basic
=== RUN   TestAccEC2OutpostsLocalGatewayRoute_disappears
=== PAUSE TestAccEC2OutpostsLocalGatewayRoute_disappears
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
=== RUN   TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
=== PAUSE TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
=== RUN   TestAccEC2OutpostsLocalGatewaysDataSource_basic
=== PAUSE TestAccEC2OutpostsLocalGatewaysDataSource_basic
=== CONT  TestAccEC2OutpostsCoIPPoolDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID
    outposts_local_gateway_virtual_interface_group_data_source_test.go:43: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_localGatewayID (0.82s)
=== CONT  TestAccEC2OutpostsLocalGatewaysDataSource_basic
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id
    outposts_local_gateway_virtual_interface_data_source_test.go:47: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_id (0.82s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
=== NAME  TestAccEC2OutpostsCoIPPoolDataSource_filter
    outposts_coip_pool_data_source_test.go:20: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolDataSource_filter (0.88s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter
    outposts_local_gateway_route_tables_data_source_test.go:38: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_filter (0.91s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags
    outposts_local_gateway_virtual_interface_groups_data_source_test.go:62: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_tags (0.17s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
=== NAME  TestAccEC2OutpostsLocalGatewaysDataSource_basic
    outposts_local_gateways_data_source_test.go:19: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewaysDataSource_basic (0.17s)
=== CONT  TestAccEC2OutpostsLocalGatewayRoute_disappears
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter
    outposts_local_gateway_virtual_interface_groups_data_source_test.go:41: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_filter (0.15s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic
    outposts_local_gateway_virtual_interface_groups_data_source_test.go:21: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupsDataSource_basic (0.16s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags
    outposts_local_gateway_virtual_interface_group_data_source_test.go:66: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_tags (0.16s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
=== NAME  TestAccEC2OutpostsLocalGatewayRoute_disappears
    outposts_local_gateway_route_test.go:60: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRoute_disappears (0.16s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter
    outposts_local_gateway_virtual_interface_data_source_test.go:22: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_filter (0.15s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter
    outposts_local_gateway_virtual_interface_group_data_source_test.go:22: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceGroupDataSource_filter (0.18s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic
    outposts_local_gateway_route_tables_data_source_test.go:19: skipping since no Outposts found
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID
    outposts_local_gateway_route_table_data_source_test.go:64: skipping since no Outposts found
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTablesDataSource_basic (0.18s)
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_localGatewayID (0.18s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags
    outposts_local_gateway_route_table_vpc_association_test.go:82: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_tags (0.19s)
=== CONT  TestAccEC2OutpostsLocalGatewayDataSource_basic
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears
    outposts_local_gateway_route_table_vpc_association_test.go:59: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_disappears (0.14s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic
    outposts_local_gateway_route_table_vpc_association_test.go:29: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableVPCAssociation_basic (0.15s)
=== CONT  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN
    outposts_local_gateway_route_table_data_source_test.go:86: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_outpostARN (0.15s)
=== CONT  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
=== NAME  TestAccEC2OutpostsLocalGatewayDataSource_basic
    outposts_local_gateway_data_source_test.go:20: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayDataSource_basic (0.15s)
=== CONT  TestAccEC2OutpostsCoIPPoolsDataSource_basic
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter
    outposts_local_gateway_route_table_data_source_test.go:42: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_filter (0.15s)
=== CONT  TestAccEC2OutpostsCoIPPoolsDataSource_filter
=== NAME  TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic
    outposts_local_gateway_route_table_data_source_test.go:20: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRouteTableDataSource_basic (0.16s)
=== CONT  TestAccEC2OutpostsLocalGatewayRoute_basic
=== NAME  TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags
    outposts_local_gateway_virtual_interface_data_source_test.go:74: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource_tags (0.18s)
=== CONT  TestAccEC2OutpostsCoIPPoolDataSource_id
=== NAME  TestAccEC2OutpostsCoIPPoolsDataSource_basic
    outposts_coip_pools_data_source_test.go:19: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolsDataSource_basic (0.21s)
=== NAME  TestAccEC2OutpostsCoIPPoolsDataSource_filter
    outposts_coip_pools_data_source_test.go:38: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolsDataSource_filter (0.23s)
=== NAME  TestAccEC2OutpostsLocalGatewayRoute_basic
    outposts_local_gateway_route_test.go:30: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsLocalGatewayRoute_basic (0.20s)
=== NAME  TestAccEC2OutpostsCoIPPoolDataSource_id
    outposts_coip_pool_data_source_test.go:41: skipping since no Outposts found
--- SKIP: TestAccEC2OutpostsCoIPPoolDataSource_id (0.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	6.783s

@DanielRieske We are going to work with AWS to try and get this tested against actual Outposts instances.

@DanielRieske
Copy link
Contributor Author

Sounds good, let me know if there is anything more I can do for this PR.

@github-actions github-actions bot added the service/transitgateway Issues and PRs that pertain to the transitgateway service. label Jun 28, 2024
ewbankkit
ewbankkit approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Going to merge this one to unblock migration of VPC resources (which should complete the migration of the ec2 service package).
We will test this (and other Outposts functionality) once we get access.

@ewbankkit ewbankkit merged commit dc0956d into hashicorp:main Jul 8, 2024
45 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@breathingdust breathingdust mentioned this pull request Jul 18, 2024
Closed
@DanielRieske DanielRieske mentioned this pull request Aug 10, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.58.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Outposts (EC2) Service
3 participants
@DanielRieske @ewbankkit @justinretzolk