-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate S3 on Outposts
resource to AWS SDK v2
#38816
Migrate S3 on Outposts
resource to AWS SDK v2
#38816
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
S3 on Outposts
resources to AWS SDK v2S3 on Outposts
resource to AWS SDK v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3Outposts' PKG=s3outposts
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/s3outposts/... -v -count 1 -parallel 20 -run=TestAccS3Outposts -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/s3outposts v1.26.3
=== RUN TestAccS3OutpostsEndpoint_basic
=== PAUSE TestAccS3OutpostsEndpoint_basic
=== RUN TestAccS3OutpostsEndpoint_private
=== PAUSE TestAccS3OutpostsEndpoint_private
=== RUN TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== PAUSE TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== RUN TestAccS3OutpostsEndpoint_disappears
=== PAUSE TestAccS3OutpostsEndpoint_disappears
=== CONT TestAccS3OutpostsEndpoint_basic
=== CONT TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== CONT TestAccS3OutpostsEndpoint_disappears
=== CONT TestAccS3OutpostsEndpoint_private
endpoint_test.go:65: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_private (0.78s)
=== NAME TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
endpoint_test.go:101: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool (0.81s)
=== NAME TestAccS3OutpostsEndpoint_disappears
endpoint_test.go:138: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_disappears (0.81s)
=== NAME TestAccS3OutpostsEndpoint_basic
endpoint_test.go:29: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_basic (0.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts 5.823s
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR migrates the
S3 on Outposts
resource to AWS SDKv2.Unfortunately I am not able to test this as I don't have an Outpost instance, most likely going to need the same as in PR #38075
Relations
Closes #36207
Relates #32976
References
Output from Acceptance Testing