Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate S3 on Outposts resource to AWS SDK v2 #38816

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

DanielRieske
Copy link
Contributor

Description

This PR migrates the S3 on Outposts resource to AWS SDKv2.

Unfortunately I am not able to test this as I don't have an Outpost instance, most likely going to need the same as in PR #38075

Relations

Closes #36207
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAcc' PKG=s3outposts
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/s3outposts/... -v -count 1 -parallel 20  -run=TestAcc -timeout 360m
=== RUN   TestAccS3OutpostsEndpoint_basic
=== PAUSE TestAccS3OutpostsEndpoint_basic
=== RUN   TestAccS3OutpostsEndpoint_private
=== PAUSE TestAccS3OutpostsEndpoint_private
=== RUN   TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== PAUSE TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== RUN   TestAccS3OutpostsEndpoint_disappears
=== PAUSE TestAccS3OutpostsEndpoint_disappears
=== CONT  TestAccS3OutpostsEndpoint_basic
=== CONT  TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== CONT  TestAccS3OutpostsEndpoint_disappears
=== CONT  TestAccS3OutpostsEndpoint_private
=== NAME  TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
    endpoint_test.go:101: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool (1.31s)
=== NAME  TestAccS3OutpostsEndpoint_disappears
    endpoint_test.go:138: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_disappears (1.31s)
=== NAME  TestAccS3OutpostsEndpoint_basic
    endpoint_test.go:29: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_basic (1.36s)
=== NAME  TestAccS3OutpostsEndpoint_private
    endpoint_test.go:65: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_private (1.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts 6.120s

@DanielRieske DanielRieske requested a review from a team as a code owner August 10, 2024 13:43
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@DanielRieske DanielRieske changed the title Migrate S3 on Outposts resources to AWS SDK v2 Migrate S3 on Outposts resource to AWS SDK v2 Aug 10, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3outposts Issues and PRs that pertain to the s3outposts service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 10, 2024
@ewbankkit ewbankkit added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 12, 2024
@ewbankkit ewbankkit self-assigned this Aug 12, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 12, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3Outposts' PKG=s3outposts                          
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/s3outposts/... -v -count 1 -parallel 20  -run=TestAccS3Outposts -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/s3outposts v1.26.3
=== RUN   TestAccS3OutpostsEndpoint_basic
=== PAUSE TestAccS3OutpostsEndpoint_basic
=== RUN   TestAccS3OutpostsEndpoint_private
=== PAUSE TestAccS3OutpostsEndpoint_private
=== RUN   TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== PAUSE TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== RUN   TestAccS3OutpostsEndpoint_disappears
=== PAUSE TestAccS3OutpostsEndpoint_disappears
=== CONT  TestAccS3OutpostsEndpoint_basic
=== CONT  TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== CONT  TestAccS3OutpostsEndpoint_disappears
=== CONT  TestAccS3OutpostsEndpoint_private
    endpoint_test.go:65: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_private (0.78s)
=== NAME  TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
    endpoint_test.go:101: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool (0.81s)
=== NAME  TestAccS3OutpostsEndpoint_disappears
    endpoint_test.go:138: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_disappears (0.81s)
=== NAME  TestAccS3OutpostsEndpoint_basic
    endpoint_test.go:29: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_basic (0.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts	5.823s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0e574fb into hashicorp:main Aug 12, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/s3outposts Issues and PRs that pertain to the s3outposts service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] S3 on Outposts Service
2 participants