docs/resource/aws_ssm_association: Prefer targets InstanceIds over instance_id for schema version 2.0+ #4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance_id for schema version 2.0+
bflad
added
documentation
ghost
added
size/XS
tombuildsstuff
suggested changes
Apr 24, 2018
| @@ -60,7 +60,10 @@ DOC | |||
|
|
|||
| resource "aws_ssm_association" "foo" { | |||
| name = "test_document_association-%s" | |||
| instance_id = "${aws_instance.foo.id}" | |||
| targets { | |||
There was a problem hiding this comment.
the schemaVersion above is using 1.2 - can we update that to 2.0 to match the ssm_association?
There was a problem hiding this comment.
I went ahead and just removed the resource declarations above and instead provide an example ${aws_ssm_document.example.name} reference so we don't need to keep two documentation pages in sync. The details present before were not necessary here.
…s and just provide fake example references
ghost
added
documentation
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2840 by switching the example from
instance_idtotargetsand adding note about schema version 2.0+ ininstance_idargument.