Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/resource/aws_ssm_association: Prefer targets InstanceIds over instance_id for schema version 2.0+ #4328

Merged
merged 2 commits into from
Apr 24, 2018
Merged

docs/resource/aws_ssm_association: Prefer targets InstanceIds over instance_id for schema version 2.0+ #4328

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff59f5e
docs/resource/aws_ssm_association: Prefer targets InstanceIds over in…
bflad Apr 24, 2018
bafcaed
docs/resource/aws_ssm_association: Remove extraneous example resource…
bflad Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions website/docs/r/ssm_association.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ DOC

resource "aws_ssm_association" "foo" {
name = "test_document_association-%s"
instance_id = "${aws_instance.foo.id}"
targets {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the schemaVersion above is using 1.2 - can we update that to 2.0 to match the ssm_association?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and just removed the resource declarations above and instead provide an example ${aws_ssm_document.example.name} reference so we don't need to keep two documentation pages in sync. The details present before were not necessary here.

key = "InstanceIds"
values = "${aws_instance.foo.id}"
}
}
```

Expand All @@ -71,7 +74,7 @@ The following arguments are supported:
* `name` - (Required) The name of the SSM document to apply.
* `association_name` - (Optional) The descriptive name for the association.
* `document_version` - (Optional) The document version you want to associate with the target(s). Can be a specific version or the default version.
* `instance_id` - (Optional) The instance ID to apply an SSM document to.
* `instance_id` - (Optional) The instance ID to apply an SSM document to. Use `targets` with key `InstanceIds` for document schema versions 2.0 and above.
* `output_location` - (Optional) An output location block. Output Location is documented below.
* `parameters` - (Optional) A block of arbitrary string parameters to pass to the SSM document.
* `schedule_expression` - (Optional) A cron expression when the association will be applied to the target(s).
Expand Down