Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Go 1.11 #5721

Merged
merged 3 commits into from
Aug 29, 2018
Merged

Require Go 1.11 #5721

merged 3 commits into from
Aug 29, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 29, 2018

Builds on #5679 by updating the README documentation and TravisCI configuration.

Changes proposed in this pull request:

  • Add Go 1.11 requirement in README
  • Update TravisCI to use Go 1.11 instead of Go 1.9

Output from acceptance testing: A full acceptance test run was completed without new issues: Tests failed: 75, passed: 1970, ignored: 39 (omitted for brevity)

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. labels Aug 29, 2018
@bflad bflad mentioned this pull request Aug 29, 2018
@bflad bflad requested a review from a team August 29, 2018 11:55
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bflad bflad added this to the v1.34.0 milestone Aug 29, 2018
@bflad bflad merged commit 32d225c into master Aug 29, 2018
@bflad bflad deleted the f-go1.11 branch August 29, 2018 16:02
bflad added a commit that referenced this pull request Aug 29, 2018
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants