Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for validate funcs in neptune_event_subscription #5750

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

saravanan30erd
Copy link
Contributor

Changes proposed in this pull request:

  • Change 1
    added unit tests for validate funcs in neptune event subscription
    Output from acceptance testing:
$ make test
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
ok  	github.com/terraform-providers/terraform-provider-aws/aws	(cached)
...

@saravanan30erd
Copy link
Contributor Author

@bflad looks like make fmt did lot of changes :)-

@bflad
Copy link
Contributor

bflad commented Aug 31, 2018

Due to some changes to go fmt in the Go 1.11 release, we now require Go 1.11 (rather than trying to support both old and new Go versions) 🙁 See also #5721 and the NOTES entry from the release yesterday.

@saravanan30erd
Copy link
Contributor Author

@bflad thanks. Fixed the gofmt issues by upgrading go to 1.11.

$ make test
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.840s

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/neptune Issues and PRs that pertain to the neptune service. labels Sep 4, 2018
@bflad bflad added this to the v1.35.0 milestone Sep 4, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @saravanan30erd! 🚀

@bflad bflad merged commit 08a8d16 into hashicorp:master Sep 4, 2018
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/neptune Issues and PRs that pertain to the neptune service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants